From: Arnd Bergmann <arnd@arndb.de> To: linux-kernel@vger.kernel.org, Kalle Valo <kvalo@codeaurora.org>, "David S. Miller" <davem@davemloft.net>, "Gustavo A. R. Silva" <gustavo@embeddedor.com>, Michal Kazior <michal.kazior@tieto.com> Cc: Arnd Bergmann <arnd@arndb.de>, Kalle Valo <kvalo@qca.qualcomm.com>, Maharaja Kennadyrajan <mkenna@codeaurora.org>, Wen Gong <wgong@codeaurora.org>, Erik Stromdahl <erik.stromdahl@gmail.com>, ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 04/15] ath10k: fix gcc-10 zero-length-bounds warnings Date: Thu, 30 Apr 2020 23:30:46 +0200 [thread overview] Message-ID: <20200430213101.135134-5-arnd@arndb.de> (raw) In-Reply-To: <20200430213101.135134-1-arnd@arndb.de> gcc-10 started warning about out-of-bounds access for zero-length arrays: In file included from drivers/net/wireless/ath/ath10k/core.h:18, from drivers/net/wireless/ath/ath10k/htt_rx.c:8: drivers/net/wireless/ath/ath10k/htt_rx.c: In function 'ath10k_htt_rx_tx_fetch_ind': drivers/net/wireless/ath/ath10k/htt.h:1683:17: warning: array subscript 65535 is outside the bounds of an interior zero-length array 'struct htt_tx_fetch_record[0]' [-Wzero-length-bounds] 1683 | return (void *)&ind->records[le16_to_cpu(ind->num_records)]; | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/net/wireless/ath/ath10k/htt.h:1676:29: note: while referencing 'records' 1676 | struct htt_tx_fetch_record records[0]; | ^~~~~~~ The structure was already converted to have a flexible-array member in the past, but there are two zero-length members in the end and only one of them can be a flexible-array member. Swap the two around to avoid the warning, as 'resp_ids' is not accessed in a way that causes a warning. Fixes: 3ba225b506a2 ("treewide: Replace zero-length array with flexible-array member") Fixes: 22e6b3bc5d96 ("ath10k: add new htt definitions") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/net/wireless/ath/ath10k/htt.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/htt.h b/drivers/net/wireless/ath/ath10k/htt.h index e7096a73c6ca..7621f0a3dc77 100644 --- a/drivers/net/wireless/ath/ath10k/htt.h +++ b/drivers/net/wireless/ath/ath10k/htt.h @@ -1673,8 +1673,8 @@ struct htt_tx_fetch_ind { __le32 token; __le16 num_resp_ids; __le16 num_records; - struct htt_tx_fetch_record records[0]; - __le32 resp_ids[]; /* ath10k_htt_get_tx_fetch_ind_resp_ids() */ + __le32 resp_ids[0]; /* ath10k_htt_get_tx_fetch_ind_resp_ids() */ + struct htt_tx_fetch_record records[]; } __packed; static inline void * -- 2.26.0
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de> To: linux-kernel@vger.kernel.org, Kalle Valo <kvalo@codeaurora.org>, "David S. Miller" <davem@davemloft.net>, "Gustavo A. R. Silva" <gustavo@embeddedor.com>, Michal Kazior <michal.kazior@tieto.com> Cc: Maharaja Kennadyrajan <mkenna@codeaurora.org>, Arnd Bergmann <arnd@arndb.de>, Erik Stromdahl <erik.stromdahl@gmail.com>, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, Kalle Valo <kvalo@qca.qualcomm.com>, Wen Gong <wgong@codeaurora.org> Subject: [PATCH 04/15] ath10k: fix gcc-10 zero-length-bounds warnings Date: Thu, 30 Apr 2020 23:30:46 +0200 [thread overview] Message-ID: <20200430213101.135134-5-arnd@arndb.de> (raw) In-Reply-To: <20200430213101.135134-1-arnd@arndb.de> gcc-10 started warning about out-of-bounds access for zero-length arrays: In file included from drivers/net/wireless/ath/ath10k/core.h:18, from drivers/net/wireless/ath/ath10k/htt_rx.c:8: drivers/net/wireless/ath/ath10k/htt_rx.c: In function 'ath10k_htt_rx_tx_fetch_ind': drivers/net/wireless/ath/ath10k/htt.h:1683:17: warning: array subscript 65535 is outside the bounds of an interior zero-length array 'struct htt_tx_fetch_record[0]' [-Wzero-length-bounds] 1683 | return (void *)&ind->records[le16_to_cpu(ind->num_records)]; | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/net/wireless/ath/ath10k/htt.h:1676:29: note: while referencing 'records' 1676 | struct htt_tx_fetch_record records[0]; | ^~~~~~~ The structure was already converted to have a flexible-array member in the past, but there are two zero-length members in the end and only one of them can be a flexible-array member. Swap the two around to avoid the warning, as 'resp_ids' is not accessed in a way that causes a warning. Fixes: 3ba225b506a2 ("treewide: Replace zero-length array with flexible-array member") Fixes: 22e6b3bc5d96 ("ath10k: add new htt definitions") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/net/wireless/ath/ath10k/htt.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/htt.h b/drivers/net/wireless/ath/ath10k/htt.h index e7096a73c6ca..7621f0a3dc77 100644 --- a/drivers/net/wireless/ath/ath10k/htt.h +++ b/drivers/net/wireless/ath/ath10k/htt.h @@ -1673,8 +1673,8 @@ struct htt_tx_fetch_ind { __le32 token; __le16 num_resp_ids; __le16 num_records; - struct htt_tx_fetch_record records[0]; - __le32 resp_ids[]; /* ath10k_htt_get_tx_fetch_ind_resp_ids() */ + __le32 resp_ids[0]; /* ath10k_htt_get_tx_fetch_ind_resp_ids() */ + struct htt_tx_fetch_record records[]; } __packed; static inline void * -- 2.26.0 _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2020-04-30 21:32 UTC|newest] Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-04-30 21:30 [PATCH 00/15] gcc-10 warning fixes Arnd Bergmann 2020-04-30 21:30 ` Arnd Bergmann 2020-04-30 21:30 ` Arnd Bergmann 2020-04-30 21:30 ` [PATCH 01/15] crypto - Avoid free() namespace collision Arnd Bergmann 2020-05-08 6:06 ` Herbert Xu 2020-04-30 21:30 ` [PATCH 02/15] iwlwifi: mvm: fix gcc-10 zero-length-bounds warning Arnd Bergmann 2020-06-10 12:18 ` Luciano Coelho 2020-04-30 21:30 ` [PATCH 03/15] mwifiex: avoid -Wstringop-overflow warning Arnd Bergmann 2020-05-06 8:43 ` Kalle Valo 2020-04-30 21:30 ` Arnd Bergmann [this message] 2020-04-30 21:30 ` [PATCH 04/15] ath10k: fix gcc-10 zero-length-bounds warnings Arnd Bergmann 2020-04-30 21:45 ` Gustavo A. R. Silva 2020-04-30 21:45 ` Gustavo A. R. Silva 2020-04-30 21:44 ` Arnd Bergmann 2020-04-30 21:44 ` Arnd Bergmann 2020-05-04 11:54 ` Kalle Valo 2020-05-04 11:54 ` Kalle Valo 2020-05-04 16:09 ` Gustavo A. R. Silva 2020-05-04 16:09 ` Gustavo A. R. Silva 2020-05-05 4:56 ` Kalle Valo 2020-05-05 4:56 ` Kalle Valo 2020-04-30 21:30 ` [PATCH 05/15] bpf: avoid gcc-10 stringop-overflow warning Arnd Bergmann 2020-05-04 21:06 ` Daniel Borkmann 2020-04-30 21:30 ` [PATCH 06/15] netfilter: conntrack: avoid gcc-10 zero-length-bounds warning Arnd Bergmann 2020-05-10 21:48 ` Pablo Neira Ayuso 2020-04-30 21:30 ` [PATCH 07/15] drop_monitor: work around gcc-10 stringop-overflow warning Arnd Bergmann 2020-05-01 11:28 ` Neil Horman 2020-04-30 21:30 ` [PATCH 08/15] usb: ehci: avoid gcc-10 zero-length-bounds warning Arnd Bergmann 2020-05-01 2:42 ` Alan Stern 2020-05-01 20:06 ` Arnd Bergmann 2020-05-01 20:10 ` Alan Stern 2020-04-30 21:30 ` [PATCH 09/15] udf: avoid gcc-10 zero-length-bounds warnings Arnd Bergmann 2020-04-30 21:54 ` Pali Rohár 2020-05-01 20:30 ` Arnd Bergmann 2020-05-01 20:48 ` Jan Kara 2020-05-01 20:57 ` Pali Rohár 2020-04-30 21:30 ` [PATCH 10/15] hpfs: avoid gcc-10 zero-length-bounds warning Arnd Bergmann 2020-04-30 21:30 ` [PATCH 11/15] omfs: avoid gcc-10 stringop-overflow warning Arnd Bergmann 2020-04-30 21:30 ` [PATCH 12/15] media: s5k5baf: avoid gcc-10 zero-length-bounds warning Arnd Bergmann 2020-04-30 21:46 ` Gustavo A. R. Silva 2020-04-30 21:30 ` [PATCH 13/15] scsi: sas: " Arnd Bergmann 2020-05-01 7:47 ` John Garry 2020-05-01 7:54 ` Arnd Bergmann 2020-05-01 14:53 ` James Bottomley 2020-05-01 17:36 ` Arnd Bergmann 2020-04-30 21:30 ` [PATCH 14/15] isci: " Arnd Bergmann 2020-04-30 21:30 ` [PATCH 15/15] nvme: " Arnd Bergmann 2020-04-30 21:30 ` Arnd Bergmann 2020-05-01 7:32 ` Christoph Hellwig 2020-05-01 7:32 ` Christoph Hellwig
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200430213101.135134-5-arnd@arndb.de \ --to=arnd@arndb.de \ --cc=ath10k@lists.infradead.org \ --cc=davem@davemloft.net \ --cc=erik.stromdahl@gmail.com \ --cc=gustavo@embeddedor.com \ --cc=kvalo@codeaurora.org \ --cc=kvalo@qca.qualcomm.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-wireless@vger.kernel.org \ --cc=michal.kazior@tieto.com \ --cc=mkenna@codeaurora.org \ --cc=netdev@vger.kernel.org \ --cc=wgong@codeaurora.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.