From: "Ewan D. Milne" <emilne@redhat.com>
To: linux-scsi@vger.kernel.org
Cc: stable@vger.kernel.org, njavali@marvell.com, himanshu.madhani@oracle.com
Subject: [PATCH] scsi: qla2xxx: Do not log message when reading port speed via sysfs
Date: Mon, 4 May 2020 13:54:16 -0400 [thread overview]
Message-ID: <20200504175416.15417-1-emilne@redhat.com> (raw)
Calling ql_log() inside qla2x00_port_speed_show() is causing messages
to be output to the console for no particularly good reason. The sysfs
read routine should just return the information to userspace. The only
reason to log a message is when the port speed actually changes, and
this already occurs elsewhere.
Cc: <stable@vger.kernel.org> # v5.1+
Fixes: 4910b524ac9 ("scsi: qla2xxx: Add support for setting port speed")
Signed-off-by: Ewan D. Milne <emilne@redhat.com>
---
drivers/scsi/qla2xxx/qla_attr.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_attr.c b/drivers/scsi/qla2xxx/qla_attr.c
index 3325596..2c9e5ac 100644
--- a/drivers/scsi/qla2xxx/qla_attr.c
+++ b/drivers/scsi/qla2xxx/qla_attr.c
@@ -1850,9 +1850,6 @@ qla2x00_port_speed_show(struct device *dev, struct device_attribute *attr,
return -EINVAL;
}
- ql_log(ql_log_info, vha, 0x70d6,
- "port speed:%d\n", ha->link_data_rate);
-
return scnprintf(buf, PAGE_SIZE, "%s\n", spd[ha->link_data_rate]);
}
--
2.1.0
next reply other threads:[~2020-05-04 17:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-04 17:54 Ewan D. Milne [this message]
2020-05-04 18:00 ` [PATCH] scsi: qla2xxx: Do not log message when reading port speed via sysfs Laurence Oberman
2020-05-04 19:07 ` himanshu.madhani
2020-05-05 15:30 ` Lee Duncan
2020-05-08 1:16 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200504175416.15417-1-emilne@redhat.com \
--to=emilne@redhat.com \
--cc=himanshu.madhani@oracle.com \
--cc=linux-scsi@vger.kernel.org \
--cc=njavali@marvell.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.