All of lore.kernel.org
 help / color / mirror / Atom feed
From: Inga Stotland <inga.stotland@intel.com>
To: linux-bluetooth@vger.kernel.org
Cc: brian.gix@intel.com, Inga Stotland <inga.stotland@intel.com>
Subject: [PATCH BlueZ 4/4] mesh: Remove redundant call to save node configuration
Date: Fri,  8 May 2020 17:00:24 -0700	[thread overview]
Message-ID: <20200509000024.5704-5-inga.stotland@intel.com> (raw)
In-Reply-To: <20200509000024.5704-1-inga.stotland@intel.com>

This removes a redundant call to save node configuration in
add_local_node(): there is a number of unconditional calls to
mesh_config_write_<some_node_Setting>() within this function
which would result in the node configuration being saved implicitly.
---
 mesh/node.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/mesh/node.c b/mesh/node.c
index a96c0cae1..8914b639d 100644
--- a/mesh/node.c
+++ b/mesh/node.c
@@ -1366,8 +1366,6 @@ static bool add_local_node(struct mesh_node *node, uint16_t unicast, bool kr,
 
 	update_net_settings(node);
 
-	mesh_config_save(node->cfg, true, NULL, NULL);
-
 	/* Initialize configuration server model */
 	cfgmod_server_init(node, PRIMARY_ELE_IDX);
 
-- 
2.21.3


      parent reply	other threads:[~2020-05-09  0:00 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-09  0:00 [PATCH BlueZ 0/4] Allow some composition fields update Inga Stotland
2020-05-09  0:00 ` [PATCH BlueZ 1/4] mesh: On node attach, verify element/model composition only Inga Stotland
2020-05-09 13:49   ` Gix, Brian
2020-05-14 17:05   ` Gix, Brian
2020-05-09  0:00 ` [PATCH BlueZ 2/4] mesh: Avoid saving duplicate fields in node config Inga Stotland
2020-05-09  0:00 ` [PATCH BlueZ 3/4] mesh: Allow updating CID, PID, VID & CRPL on node attach Inga Stotland
2020-05-09  0:00 ` Inga Stotland [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200509000024.5704-5-inga.stotland@intel.com \
    --to=inga.stotland@intel.com \
    --cc=brian.gix@intel.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.