From: Mike Christie <mchristi@redhat.com> To: bvanassche@acm.org, bstroesser@ts.fujitsu.com, martin.petersen@oracle.com, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org Cc: Mike Christie <mchristi@redhat.com> Subject: [PATCH 13/15] target: add target_setup_session sysfs support Date: Sun, 10 May 2020 21:57:42 +0000 [thread overview] Message-ID: <20200510215744.21999-14-mchristi@redhat.com> (raw) In-Reply-To: <20200510215744.21999-1-mchristi@redhat.com> This adds a session dir per session for users of target_setup_session. Signed-off-by: Mike Christie <mchristi@redhat.com> --- drivers/target/target_core_transport.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/target/target_core_transport.c b/drivers/target/target_core_transport.c index 04cb042..7bfeab2 100644 --- a/drivers/target/target_core_transport.c +++ b/drivers/target/target_core_transport.c @@ -457,6 +457,7 @@ struct se_session * if (IS_ERR(sess)) return sess; + sess->tfo = tpg->se_tpg_tfo; sess->tpt_id = target_create_transport_id(tpg->proto_id, tpt_id_name, NULL); @@ -471,6 +472,10 @@ struct se_session * rc = -EACCES; goto free_sess; } + + rc = target_sysfs_add_session(tpg, sess); + if (rc) + goto free_sess; /* * Go ahead and perform any remaining fabric setup that is * required before transport_register_session(). @@ -478,12 +483,14 @@ struct se_session * if (callback != NULL) { rc = callback(tpg, sess, private); if (rc) - goto free_sess; + goto rm_sysfs; } transport_register_session(tpg, sess->se_node_acl, sess, private); return sess; +rm_sysfs: + target_sysfs_remove_session(sess); free_sess: transport_free_session(sess); return ERR_PTR(rc); @@ -674,6 +681,7 @@ void transport_deregister_session(struct se_session *se_sess) void target_remove_session(struct se_session *se_sess) { + target_sysfs_remove_session(se_sess); transport_deregister_session_configfs(se_sess); transport_deregister_session(se_sess); } -- 1.8.3.1
WARNING: multiple messages have this Message-ID (diff)
From: Mike Christie <mchristi@redhat.com> To: bvanassche@acm.org, bstroesser@ts.fujitsu.com, martin.petersen@oracle.com, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org Cc: Mike Christie <mchristi@redhat.com> Subject: [PATCH 13/15] target: add target_setup_session sysfs support Date: Sun, 10 May 2020 16:57:42 -0500 [thread overview] Message-ID: <20200510215744.21999-14-mchristi@redhat.com> (raw) In-Reply-To: <20200510215744.21999-1-mchristi@redhat.com> This adds a session dir per session for users of target_setup_session. Signed-off-by: Mike Christie <mchristi@redhat.com> --- drivers/target/target_core_transport.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/target/target_core_transport.c b/drivers/target/target_core_transport.c index 04cb042..7bfeab2 100644 --- a/drivers/target/target_core_transport.c +++ b/drivers/target/target_core_transport.c @@ -457,6 +457,7 @@ struct se_session * if (IS_ERR(sess)) return sess; + sess->tfo = tpg->se_tpg_tfo; sess->tpt_id = target_create_transport_id(tpg->proto_id, tpt_id_name, NULL); @@ -471,6 +472,10 @@ struct se_session * rc = -EACCES; goto free_sess; } + + rc = target_sysfs_add_session(tpg, sess); + if (rc) + goto free_sess; /* * Go ahead and perform any remaining fabric setup that is * required before transport_register_session(). @@ -478,12 +483,14 @@ struct se_session * if (callback != NULL) { rc = callback(tpg, sess, private); if (rc) - goto free_sess; + goto rm_sysfs; } transport_register_session(tpg, sess->se_node_acl, sess, private); return sess; +rm_sysfs: + target_sysfs_remove_session(sess); free_sess: transport_free_session(sess); return ERR_PTR(rc); @@ -674,6 +681,7 @@ void transport_deregister_session(struct se_session *se_sess) void target_remove_session(struct se_session *se_sess) { + target_sysfs_remove_session(se_sess); transport_deregister_session_configfs(se_sess); transport_deregister_session(se_sess); } -- 1.8.3.1
next prev parent reply other threads:[~2020-05-10 21:57 UTC|newest] Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-05-10 21:57 [PATCH v5 00/15] target: add sysfs support Mike Christie 2020-05-10 21:57 ` Mike Christie 2020-05-10 21:57 ` [PATCH 01/15] target: check enforce_pr_isids during registration Mike Christie 2020-05-10 21:57 ` Mike Christie 2020-05-11 6:08 ` Hannes Reinecke 2020-05-11 6:08 ` Hannes Reinecke 2020-05-13 20:55 ` Lee Duncan 2020-05-13 20:55 ` Lee Duncan 2020-05-10 21:57 ` [PATCH 02/15] target: separate acl name from port ids Mike Christie 2020-05-10 21:57 ` Mike Christie 2020-05-11 6:09 ` Hannes Reinecke 2020-05-11 6:09 ` Hannes Reinecke 2020-05-13 23:35 ` Lee Duncan 2020-05-13 23:35 ` Lee Duncan 2020-05-10 21:57 ` [PATCH 03/15] target: add helper to parse acl and transport name Mike Christie 2020-05-10 21:57 ` Mike Christie 2020-05-11 6:09 ` Hannes Reinecke 2020-05-11 6:09 ` Hannes Reinecke 2020-05-11 18:22 ` Bodo Stroesser 2020-05-11 18:22 ` Bodo Stroesser 2020-05-11 21:04 ` Mike Christie 2020-05-11 21:04 ` Mike Christie 2020-05-13 23:57 ` Lee Duncan 2020-05-13 23:57 ` Lee Duncan 2020-05-10 21:57 ` [PATCH 04/15] tcm loop: use target_parse_emulated_name Mike Christie 2020-05-10 21:57 ` Mike Christie 2020-05-11 6:10 ` Hannes Reinecke 2020-05-11 6:10 ` Hannes Reinecke 2020-05-13 23:59 ` Lee Duncan 2020-05-13 23:59 ` Lee Duncan 2020-05-10 21:57 ` [PATCH 05/15] vhost scsi: " Mike Christie 2020-05-10 21:57 ` Mike Christie 2020-05-11 6:11 ` Hannes Reinecke 2020-05-11 6:11 ` Hannes Reinecke 2020-05-10 21:57 ` [PATCH 06/15] xen scsiback: " Mike Christie 2020-05-10 21:57 ` Mike Christie 2020-05-11 6:11 ` Hannes Reinecke 2020-05-11 6:11 ` Hannes Reinecke 2020-05-11 6:16 ` Jürgen Groß 2020-05-11 6:16 ` Jürgen Groß 2020-05-10 21:57 ` [PATCH 07/15] iscsi target: setup transport_id Mike Christie 2020-05-10 21:57 ` Mike Christie 2020-05-11 6:12 ` Hannes Reinecke 2020-05-11 6:12 ` Hannes Reinecke 2020-05-10 21:57 ` [PATCH 08/15] target: use tpt_id in target_stat_iport_port_ident_show Mike Christie 2020-05-10 21:57 ` Mike Christie 2020-05-11 6:13 ` Hannes Reinecke 2020-05-11 6:13 ` Hannes Reinecke 2020-05-10 21:57 ` [PATCH 09/15] target: drop sess_get_initiator_sid from PR code Mike Christie 2020-05-10 21:57 ` Mike Christie 2020-05-11 6:13 ` Hannes Reinecke 2020-05-11 6:13 ` Hannes Reinecke 2020-05-10 21:57 ` [PATCH 10/15] target: drop sess_get_initiator_sid Mike Christie 2020-05-10 21:57 ` Mike Christie 2020-05-11 6:14 ` Hannes Reinecke 2020-05-11 6:14 ` Hannes Reinecke 2020-05-10 21:57 ` [PATCH 11/15] target: add sysfs support Mike Christie 2020-05-10 21:57 ` Mike Christie 2020-05-11 6:21 ` Hannes Reinecke 2020-05-11 6:21 ` Hannes Reinecke 2020-05-11 6:30 ` Greg Kroah-Hartman 2020-05-11 6:30 ` Greg Kroah-Hartman 2020-05-11 17:15 ` Mike Christie 2020-05-11 17:15 ` Mike Christie 2020-05-12 5:54 ` Greg Kroah-Hartman 2020-05-12 5:54 ` Greg Kroah-Hartman 2020-05-10 21:57 ` [PATCH 12/15] target: add sysfs session helper functions Mike Christie 2020-05-10 21:57 ` Mike Christie 2020-05-11 18:39 ` Bodo Stroesser 2020-05-11 18:39 ` Bodo Stroesser 2020-05-11 19:21 ` Bart Van Assche 2020-05-11 19:21 ` Bart Van Assche 2020-05-11 20:16 ` Mike Christie 2020-05-11 20:16 ` Mike Christie 2020-05-12 11:19 ` Bodo Stroesser 2020-05-12 11:19 ` Bodo Stroesser 2020-05-12 15:55 ` Mike Christie 2020-05-12 15:55 ` Mike Christie 2020-05-10 21:57 ` Mike Christie [this message] 2020-05-10 21:57 ` [PATCH 13/15] target: add target_setup_session sysfs support Mike Christie 2020-05-10 21:57 ` [PATCH 14/15] iscsi target: use session sysfs helpers Mike Christie 2020-05-10 21:57 ` Mike Christie 2020-05-10 21:57 ` [PATCH 15/15] target: drop sess_get_index Mike Christie 2020-05-10 21:57 ` Mike Christie
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200510215744.21999-14-mchristi@redhat.com \ --to=mchristi@redhat.com \ --cc=bstroesser@ts.fujitsu.com \ --cc=bvanassche@acm.org \ --cc=linux-scsi@vger.kernel.org \ --cc=martin.petersen@oracle.com \ --cc=target-devel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.