From: Andre Przywara <andre.przywara@arm.com> To: Rob Herring <robh@kernel.org>, Liviu Dudau <liviu.dudau@arm.com>, Sudeep Holla <sudeep.holla@arm.com>, Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Mark Rutland <mark.rutland@arm.com>, Marc Zyngier <maz@kernel.org> Subject: [PATCH v3 00/20] dts/dt-bindings: Fix Arm Ltd. ARMv8 "boards" Date: Wed, 13 May 2020 11:29:56 +0100 [thread overview] Message-ID: <20200513103016.130417-1-andre.przywara@arm.com> (raw) A few updates compared to v2. The most important is to fix the interrupt-maps, triggered by changing the number of address-cells in the GIC node. For this I split the former patch 07/17 into two (09/20 and 10/20), one for the foundation model, the other for Juno. Also I fixed a dtc complaint about device nodes without reg properties being inside simple-bus nodes, those are the new patches 04-06/20. Will took patch 01/17 from v2 already, so I removed this from this series. The rest of the patches stayed the same. ----------------------------------- The .dts files in the arch/arm64/boot/dts/arm directory describe several boards and platforms provided by Arm Ltd. (mostly Juno and fastmodels). Both the .dts files and some of their associated .yaml bindings were not fully compliant, for some boards a simple dtc run complains already. And make dtbs_check would create quite a list of violations. This series attempts to fix all of them, although some are not yet covered, as they require some discussion about potential binding or DT schema changes. The first and the last two patches fix some minor omissions in the yaml bindings. The rest of the series then address the violations that dtbs_check and dtc itself reported: many node name scheme mismatches, some missing properties or wrong child node handling. See the respective patches for more details. After applying this series I still see the following warnings: - vexpress-v2f-1xv7-ca53x2: leds: linux,default-trigger names not listed. The kernel provides triggers for each CPU core, which the DT tries to use. However cpu<x> is not listed in the binding, and I fail to add a regexp for a property *value* to express this easily. Alternatively we could drop any constraint on this string at all, since this might become a moving target and is not really a hardware property, rather than a convenience Linux configuration option. - juno: scp-sram: The compatible names for the SCPI child nodes are not fully converted to yaml yet, so dtbs_check fails to find a matching schema. Converting the SCPI bindings over is next on my list. - fvp-base-revc: panel: 'power-supply' is a required property Indeed the Linux driver depends on that property, not sure how this ever worked. I am about to test this, the fix should a rather easy addition of a fixed regulator. Please have a look, I am open to discussions. Cheers, Andre Changelog v2 ... v3: - drop patch v2 01/17, Will took that already - also move fixed devices for vexpress, foundation and Juno (04-06/20) - use "arm,gic-400" in addition to the "Cortex GIC" for the models - adjust all interrupt-map properties to reflect GIC #address-cells changes Changelog v1 ... v2: - drop GIC "compatible" changes for Juno - add "arm,gic-400", "arm,cortex-a15-gic" as a valid combination - reorder more controversial binding fixes to the end - add Robin's Acked-by: - fix subject lines in first three emails Andre Przywara (20): dt-bindings: arm: gic: Allow combining arm,gic-400 compatible strings arm64: dts: arm: Fix node address fields arm64: dts: arm: fvp: Move fixed devices out of bus node arm64: dts: arm: vexpress: Move fixed devices out of bus node arm64: dts: arm: foundation: Move fixed clocks out of bus node arm64: dts: arm: juno: Move fixed devices out of bus node arm64: dts: juno: Fix mem-timer arm64: dts: arm: model: Fix GIC compatible names arm64: dts: arm: juno: Fix GIC child nodes arm64: dts: arm: foundation: Fix GIC child nodes arm64: dts: arm: Fix ITS node names and #msi-cells arm64: dts: juno: usb: Use proper DT node name arm64: dts: arm: Fix serial node names arm64: dts: fvp: Fix SMMU DT node arm64: dts: arm: Fix bus node names arm64: dts: juno: Fix GPU interrupt order arm64: dts: arm: Fix VExpress LED names arm64: dts: juno: Fix SCPI shared mem node name dt-bindings: mali-midgard: Allow dma-coherent dt-bindings: ehci/ohci: Allow iommus property .../bindings/gpu/arm,mali-midgard.yaml | 2 + .../interrupt-controller/arm,gic.yaml | 6 + .../devicetree/bindings/usb/generic-ehci.yaml | 3 + .../devicetree/bindings/usb/generic-ohci.yaml | 3 + arch/arm/boot/dts/vexpress-v2m-rs1.dtsi | 328 +++++++++--------- .../boot/dts/arm/foundation-v8-gicv2.dtsi | 4 +- .../boot/dts/arm/foundation-v8-gicv3.dtsi | 11 +- arch/arm64/boot/dts/arm/foundation-v8.dtsi | 142 ++++---- arch/arm64/boot/dts/arm/fvp-base-revc.dts | 10 +- arch/arm64/boot/dts/arm/juno-base.dtsi | 82 ++--- arch/arm64/boot/dts/arm/juno-motherboard.dtsi | 166 ++++----- arch/arm64/boot/dts/arm/rtsm_ve-aemv8a.dts | 2 +- .../boot/dts/arm/rtsm_ve-motherboard-rs2.dtsi | 4 +- .../boot/dts/arm/rtsm_ve-motherboard.dtsi | 152 ++++---- 14 files changed, 465 insertions(+), 450 deletions(-) -- 2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: Andre Przywara <andre.przywara@arm.com> To: Rob Herring <robh@kernel.org>, Liviu Dudau <liviu.dudau@arm.com>, Sudeep Holla <sudeep.holla@arm.com>, Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> Cc: Mark Rutland <mark.rutland@arm.com>, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Marc Zyngier <maz@kernel.org> Subject: [PATCH v3 00/20] dts/dt-bindings: Fix Arm Ltd. ARMv8 "boards" Date: Wed, 13 May 2020 11:29:56 +0100 [thread overview] Message-ID: <20200513103016.130417-1-andre.przywara@arm.com> (raw) A few updates compared to v2. The most important is to fix the interrupt-maps, triggered by changing the number of address-cells in the GIC node. For this I split the former patch 07/17 into two (09/20 and 10/20), one for the foundation model, the other for Juno. Also I fixed a dtc complaint about device nodes without reg properties being inside simple-bus nodes, those are the new patches 04-06/20. Will took patch 01/17 from v2 already, so I removed this from this series. The rest of the patches stayed the same. ----------------------------------- The .dts files in the arch/arm64/boot/dts/arm directory describe several boards and platforms provided by Arm Ltd. (mostly Juno and fastmodels). Both the .dts files and some of their associated .yaml bindings were not fully compliant, for some boards a simple dtc run complains already. And make dtbs_check would create quite a list of violations. This series attempts to fix all of them, although some are not yet covered, as they require some discussion about potential binding or DT schema changes. The first and the last two patches fix some minor omissions in the yaml bindings. The rest of the series then address the violations that dtbs_check and dtc itself reported: many node name scheme mismatches, some missing properties or wrong child node handling. See the respective patches for more details. After applying this series I still see the following warnings: - vexpress-v2f-1xv7-ca53x2: leds: linux,default-trigger names not listed. The kernel provides triggers for each CPU core, which the DT tries to use. However cpu<x> is not listed in the binding, and I fail to add a regexp for a property *value* to express this easily. Alternatively we could drop any constraint on this string at all, since this might become a moving target and is not really a hardware property, rather than a convenience Linux configuration option. - juno: scp-sram: The compatible names for the SCPI child nodes are not fully converted to yaml yet, so dtbs_check fails to find a matching schema. Converting the SCPI bindings over is next on my list. - fvp-base-revc: panel: 'power-supply' is a required property Indeed the Linux driver depends on that property, not sure how this ever worked. I am about to test this, the fix should a rather easy addition of a fixed regulator. Please have a look, I am open to discussions. Cheers, Andre Changelog v2 ... v3: - drop patch v2 01/17, Will took that already - also move fixed devices for vexpress, foundation and Juno (04-06/20) - use "arm,gic-400" in addition to the "Cortex GIC" for the models - adjust all interrupt-map properties to reflect GIC #address-cells changes Changelog v1 ... v2: - drop GIC "compatible" changes for Juno - add "arm,gic-400", "arm,cortex-a15-gic" as a valid combination - reorder more controversial binding fixes to the end - add Robin's Acked-by: - fix subject lines in first three emails Andre Przywara (20): dt-bindings: arm: gic: Allow combining arm,gic-400 compatible strings arm64: dts: arm: Fix node address fields arm64: dts: arm: fvp: Move fixed devices out of bus node arm64: dts: arm: vexpress: Move fixed devices out of bus node arm64: dts: arm: foundation: Move fixed clocks out of bus node arm64: dts: arm: juno: Move fixed devices out of bus node arm64: dts: juno: Fix mem-timer arm64: dts: arm: model: Fix GIC compatible names arm64: dts: arm: juno: Fix GIC child nodes arm64: dts: arm: foundation: Fix GIC child nodes arm64: dts: arm: Fix ITS node names and #msi-cells arm64: dts: juno: usb: Use proper DT node name arm64: dts: arm: Fix serial node names arm64: dts: fvp: Fix SMMU DT node arm64: dts: arm: Fix bus node names arm64: dts: juno: Fix GPU interrupt order arm64: dts: arm: Fix VExpress LED names arm64: dts: juno: Fix SCPI shared mem node name dt-bindings: mali-midgard: Allow dma-coherent dt-bindings: ehci/ohci: Allow iommus property .../bindings/gpu/arm,mali-midgard.yaml | 2 + .../interrupt-controller/arm,gic.yaml | 6 + .../devicetree/bindings/usb/generic-ehci.yaml | 3 + .../devicetree/bindings/usb/generic-ohci.yaml | 3 + arch/arm/boot/dts/vexpress-v2m-rs1.dtsi | 328 +++++++++--------- .../boot/dts/arm/foundation-v8-gicv2.dtsi | 4 +- .../boot/dts/arm/foundation-v8-gicv3.dtsi | 11 +- arch/arm64/boot/dts/arm/foundation-v8.dtsi | 142 ++++---- arch/arm64/boot/dts/arm/fvp-base-revc.dts | 10 +- arch/arm64/boot/dts/arm/juno-base.dtsi | 82 ++--- arch/arm64/boot/dts/arm/juno-motherboard.dtsi | 166 ++++----- arch/arm64/boot/dts/arm/rtsm_ve-aemv8a.dts | 2 +- .../boot/dts/arm/rtsm_ve-motherboard-rs2.dtsi | 4 +- .../boot/dts/arm/rtsm_ve-motherboard.dtsi | 152 ++++---- 14 files changed, 465 insertions(+), 450 deletions(-) -- 2.17.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2020-05-13 10:30 UTC|newest] Thread overview: 94+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-05-13 10:29 Andre Przywara [this message] 2020-05-13 10:29 ` [PATCH v3 00/20] dts/dt-bindings: Fix Arm Ltd. ARMv8 "boards" Andre Przywara 2020-05-13 10:29 ` [PATCH v3 01/20] dt-bindings: arm: gic: Allow combining arm,gic-400 compatible strings Andre Przywara 2020-05-13 10:29 ` [PATCH v3 01/20] dt-bindings: arm: gic: Allow combining arm, gic-400 " Andre Przywara 2020-05-15 3:16 ` Rob Herring 2020-05-15 3:16 ` Rob Herring 2020-05-19 7:39 ` [PATCH v3 01/20] dt-bindings: arm: gic: Allow combining arm,gic-400 " Geert Uytterhoeven 2020-05-19 7:39 ` Geert Uytterhoeven 2020-05-19 9:19 ` André Przywara 2020-05-19 9:19 ` André Przywara 2020-05-26 15:49 ` Rob Herring 2020-05-26 15:49 ` Rob Herring 2020-05-13 10:29 ` [PATCH v3 02/20] arm64: dts: arm: Fix node address fields Andre Przywara 2020-05-13 10:29 ` Andre Przywara 2020-05-13 17:01 ` Sudeep Holla 2020-05-13 17:01 ` Sudeep Holla 2020-05-13 10:29 ` [PATCH v3 03/20] arm64: dts: arm: fvp: Move fixed devices out of bus node Andre Przywara 2020-05-13 10:29 ` Andre Przywara 2020-05-13 17:22 ` Sudeep Holla 2020-05-13 17:22 ` Sudeep Holla 2020-05-13 10:30 ` [PATCH v3 04/20] arm64: dts: arm: vexpress: " Andre Przywara 2020-05-13 10:30 ` Andre Przywara 2020-05-13 17:26 ` Sudeep Holla 2020-05-13 17:26 ` Sudeep Holla 2020-05-28 2:48 ` Guenter Roeck 2020-05-28 2:48 ` Guenter Roeck 2020-05-28 2:55 ` Guenter Roeck 2020-05-28 2:55 ` Guenter Roeck 2020-06-27 3:57 ` Guenter Roeck 2020-06-27 3:57 ` Guenter Roeck 2020-06-29 8:55 ` Sudeep Holla 2020-06-29 8:55 ` Sudeep Holla 2020-05-28 13:30 ` André Przywara 2020-05-28 13:30 ` André Przywara 2020-06-01 10:14 ` André Przywara 2020-06-01 10:14 ` André Przywara 2020-06-01 23:12 ` Rob Herring 2020-06-01 23:12 ` Rob Herring 2020-06-03 11:20 ` André Przywara 2020-06-03 11:20 ` André Przywara 2020-06-03 13:49 ` Rob Herring 2020-06-03 13:49 ` Rob Herring 2020-05-13 10:30 ` [PATCH v3 05/20] arm64: dts: arm: foundation: Move fixed clocks " Andre Przywara 2020-05-13 10:30 ` Andre Przywara 2020-05-13 10:30 ` [PATCH v3 06/20] arm64: dts: arm: juno: Move fixed devices " Andre Przywara 2020-05-13 10:30 ` Andre Przywara 2020-05-13 10:30 ` [PATCH v3 07/20] arm64: dts: juno: Fix mem-timer Andre Przywara 2020-05-13 10:30 ` Andre Przywara 2020-05-13 10:30 ` [PATCH v3 08/20] arm64: dts: arm: model: Fix GIC compatible names Andre Przywara 2020-05-13 10:30 ` Andre Przywara 2020-05-13 18:21 ` Sudeep Holla 2020-05-13 18:21 ` Sudeep Holla 2020-05-15 15:10 ` André Przywara 2020-05-15 15:10 ` André Przywara 2020-05-13 10:30 ` [PATCH v3 09/20] arm64: dts: arm: juno: Fix GIC child nodes Andre Przywara 2020-05-13 10:30 ` Andre Przywara 2020-05-13 10:30 ` [PATCH v3 10/20] arm64: dts: arm: foundation: " Andre Przywara 2020-05-13 10:30 ` Andre Przywara 2020-05-13 10:30 ` [PATCH v3 11/20] arm64: dts: arm: Fix ITS node names and #msi-cells Andre Przywara 2020-05-13 10:30 ` Andre Przywara 2020-05-13 10:30 ` [PATCH v3 12/20] arm64: dts: juno: usb: Use proper DT node name Andre Przywara 2020-05-13 10:30 ` Andre Przywara 2020-05-13 10:30 ` [PATCH v3 13/20] arm64: dts: arm: Fix serial node names Andre Przywara 2020-05-13 10:30 ` Andre Przywara 2020-05-13 10:30 ` [PATCH v3 14/20] arm64: dts: fvp: Fix SMMU DT node Andre Przywara 2020-05-13 10:30 ` Andre Przywara 2020-05-13 10:30 ` [PATCH v3 15/20] arm64: dts: arm: Fix bus node names Andre Przywara 2020-05-13 10:30 ` Andre Przywara 2020-05-13 10:30 ` [PATCH v3 16/20] arm64: dts: juno: Fix GPU interrupt order Andre Przywara 2020-05-13 10:30 ` Andre Przywara 2020-05-13 18:24 ` Sudeep Holla 2020-05-13 18:24 ` Sudeep Holla 2020-05-15 15:13 ` André Przywara 2020-05-15 15:13 ` André Przywara 2020-05-13 10:30 ` [PATCH v3 17/20] arm64: dts: arm: Fix VExpress LED names Andre Przywara 2020-05-13 10:30 ` Andre Przywara 2020-05-13 10:30 ` [PATCH v3 18/20] arm64: dts: juno: Fix SCPI shared mem node name Andre Przywara 2020-05-13 10:30 ` Andre Przywara 2020-05-13 10:30 ` [PATCH v3 19/20] dt-bindings: mali-midgard: Allow dma-coherent Andre Przywara 2020-05-13 10:30 ` Andre Przywara 2020-05-13 10:30 ` Andre Przywara 2020-05-15 3:16 ` Rob Herring 2020-05-15 3:16 ` Rob Herring 2020-05-15 3:16 ` Rob Herring 2020-05-13 10:30 ` [PATCH v3 20/20] dt-bindings: ehci/ohci: Allow iommus property Andre Przywara 2020-05-13 10:30 ` Andre Przywara 2020-05-13 18:28 ` Sudeep Holla 2020-05-13 18:28 ` Sudeep Holla 2020-05-15 3:17 ` Rob Herring 2020-05-15 3:17 ` Rob Herring 2020-05-18 8:15 ` [PATCH v3 00/20] dts/dt-bindings: Fix Arm Ltd. ARMv8 "boards" Sudeep Holla 2020-05-18 8:15 ` Sudeep Holla 2020-05-18 11:31 ` Sudeep Holla 2020-05-18 11:31 ` Sudeep Holla
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200513103016.130417-1-andre.przywara@arm.com \ --to=andre.przywara@arm.com \ --cc=devicetree@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=liviu.dudau@arm.com \ --cc=lorenzo.pieralisi@arm.com \ --cc=mark.rutland@arm.com \ --cc=maz@kernel.org \ --cc=robh@kernel.org \ --cc=sudeep.holla@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.