All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Thumshirn <johannes.thumshirn@wdc.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: "linux-block @ vger . kernel . org" <linux-block@vger.kernel.org>,
	Damien Le Moal <damien.lemoal@wdc.com>,
	Christoph Hellwig <hch@lst.de>, Coly Li <colyli@suse.de>,
	Johannes Thumshirn <johannes.thumshirn@wdc.com>
Subject: [PATCH] block: deny zone management ioctl on mounted fs
Date: Fri, 15 May 2020 01:26:43 +0900	[thread overview]
Message-ID: <20200514162643.11880-1-johannes.thumshirn@wdc.com> (raw)

If a user submits a zone management ioctl from user-space, like a zone
reset and a file-system (like zonefs or f2fs) is mounted on the zoned
block device, the zone will get reset and the file-system's cached value
of the zone's write-pointer becomes invalid.

Subsequent writes to this zone from the file-system will result in
unaligned writes and the drive will error out.

Deny zone management ioctls when a super_block is found on the block
device.

Reported-by: Coly Li <colyli@suse.de>
Signed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
---

Is there a better way to check for a mounted FS than get_super()/drop_super()?

 block/blk-zoned.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/block/blk-zoned.c b/block/blk-zoned.c
index 23831fa8701d..6923695ec414 100644
--- a/block/blk-zoned.c
+++ b/block/blk-zoned.c
@@ -325,6 +325,7 @@ int blkdev_zone_mgmt_ioctl(struct block_device *bdev, fmode_t mode,
 			   unsigned int cmd, unsigned long arg)
 {
 	void __user *argp = (void __user *)arg;
+	struct super_block *sb;
 	struct request_queue *q;
 	struct blk_zone_range zrange;
 	enum req_opf op;
@@ -345,6 +346,12 @@ int blkdev_zone_mgmt_ioctl(struct block_device *bdev, fmode_t mode,
 	if (!(mode & FMODE_WRITE))
 		return -EBADF;
 
+	sb = get_super(bdev);
+	if (sb) {
+		drop_super(sb);
+		return -EINVAL;
+	}
+
 	if (copy_from_user(&zrange, argp, sizeof(struct blk_zone_range)))
 		return -EFAULT;
 
-- 
2.24.1


             reply	other threads:[~2020-05-14 16:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-14 16:26 Johannes Thumshirn [this message]
2020-05-15  4:52 ` [PATCH] block: deny zone management ioctl on mounted fs Damien Le Moal
2020-05-15  5:09   ` Coly Li
2020-05-15  5:25     ` Damien Le Moal
2020-05-15  5:34       ` Coly Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200514162643.11880-1-johannes.thumshirn@wdc.com \
    --to=johannes.thumshirn@wdc.com \
    --cc=axboe@kernel.dk \
    --cc=colyli@suse.de \
    --cc=damien.lemoal@wdc.com \
    --cc=hch@lst.de \
    --cc=linux-block@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.