From: Christoph Hellwig <hch@lst.de>
To: axboe@kernel.dk
Cc: linux-block@vger.kernel.org
Subject: [PATCH 3/4] blk-mq: remove a pointless queue enter pair in blk_mq_alloc_request_hctx
Date: Sat, 16 May 2020 20:28:00 +0200 [thread overview]
Message-ID: <20200516182801.482930-4-hch@lst.de> (raw)
In-Reply-To: <20200516182801.482930-1-hch@lst.de>
No need for two queue references.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
block/blk-mq.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/block/blk-mq.c b/block/blk-mq.c
index 4e62b97dceb48..b1c12de8926e3 100644
--- a/block/blk-mq.c
+++ b/block/blk-mq.c
@@ -455,10 +455,7 @@ struct request *blk_mq_alloc_request_hctx(struct request_queue *q,
alloc_data.ctx = __blk_mq_get_ctx(q, cpu);
ret = -EWOULDBLOCK;
- blk_queue_enter_live(q);
rq = blk_mq_get_request(q, NULL, &alloc_data);
- blk_queue_exit(q);
-
if (!rq)
goto out_queue_exit;
return rq;
--
2.26.2
next prev parent reply other threads:[~2020-05-16 18:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-16 18:27 avoid a few q_usage_counter roundtrips v3 Christoph Hellwig
2020-05-16 18:27 ` [PATCH 1/4] blk-mq: move the call to blk_queue_enter_live out of blk_mq_get_request Christoph Hellwig
2020-05-16 18:27 ` [PATCH 2/4] blk-mq: remove a pointless queue enter pair in blk_mq_alloc_request Christoph Hellwig
2020-05-16 18:28 ` Christoph Hellwig [this message]
2020-05-16 18:44 ` [PATCH 3/4] blk-mq: remove a pointless queue enter pair in blk_mq_alloc_request_hctx Bart Van Assche
2020-05-16 18:28 ` [PATCH 4/4] blk-mq: allow blk_mq_make_request to consume the q_usage_counter reference Christoph Hellwig
2020-05-19 15:43 ` avoid a few q_usage_counter roundtrips v3 Jens Axboe
-- strict thread matches above, loose matches on Subject: below --
2020-05-16 15:34 avoid a few q_usage_counter roundtrips v2 Christoph Hellwig
2020-05-16 15:34 ` [PATCH 3/4] blk-mq: remove a pointless queue enter pair in blk_mq_alloc_request_hctx Christoph Hellwig
2020-05-16 16:28 ` Bart Van Assche
2020-05-16 17:31 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200516182801.482930-4-hch@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.