From: Dinghao Liu <dinghao.liu@zju.edu.cn> To: dinghao.liu@zju.edu.cn, kjlu@umn.edu Cc: Corentin Labbe <clabbe.montjoie@gmail.com>, Herbert Xu <herbert@gondor.apana.org.au>, "David S. Miller" <davem@davemloft.net>, Maxime Ripard <mripard@kernel.org>, Chen-Yu Tsai <wens@csie.org>, kbuild test robot Remove unneeded semicolon <lkp@intel.com>, Julia Lawall <julia.lawall@lip6.fr>, Colin Ian King <colin.king@canonical.com>, linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] crypto: sun8i-ss - fix runtime pm imbalance on error Date: Wed, 20 May 2020 16:11:50 +0800 [thread overview] Message-ID: <20200520081157.24922-1-dinghao.liu@zju.edu.cn> (raw) pm_runtime_get_sync() increments the runtime PM usage counter even it returns an error code. Thus a pairing decrement is needed on the error handling path to keep the counter balanced. Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn> --- drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c b/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c index 6b301afffd11..41841415ead6 100644 --- a/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c +++ b/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c @@ -571,8 +571,10 @@ static int sun8i_ss_probe(struct platform_device *pdev) goto error_alg; err = pm_runtime_get_sync(ss->dev); - if (err < 0) + if (err < 0) { + pm_runtime_put_sync(ss->dev); goto error_alg; + } v = readl(ss->base + SS_CTL_REG); v >>= SS_DIE_ID_SHIFT; -- 2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: Dinghao Liu <dinghao.liu@zju.edu.cn> To: dinghao.liu@zju.edu.cn, kjlu@umn.edu Cc: kbuild test robot Remove unneeded semicolon <lkp@intel.com>, linux-kernel@vger.kernel.org, Maxime Ripard <mripard@kernel.org>, Julia Lawall <julia.lawall@lip6.fr>, Chen-Yu Tsai <wens@csie.org>, Corentin Labbe <clabbe.montjoie@gmail.com>, linux-crypto@vger.kernel.org, Colin Ian King <colin.king@canonical.com>, "David S. Miller" <davem@davemloft.net>, linux-arm-kernel@lists.infradead.org, Herbert Xu <herbert@gondor.apana.org.au> Subject: [PATCH] crypto: sun8i-ss - fix runtime pm imbalance on error Date: Wed, 20 May 2020 16:11:50 +0800 [thread overview] Message-ID: <20200520081157.24922-1-dinghao.liu@zju.edu.cn> (raw) pm_runtime_get_sync() increments the runtime PM usage counter even it returns an error code. Thus a pairing decrement is needed on the error handling path to keep the counter balanced. Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn> --- drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c b/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c index 6b301afffd11..41841415ead6 100644 --- a/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c +++ b/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c @@ -571,8 +571,10 @@ static int sun8i_ss_probe(struct platform_device *pdev) goto error_alg; err = pm_runtime_get_sync(ss->dev); - if (err < 0) + if (err < 0) { + pm_runtime_put_sync(ss->dev); goto error_alg; + } v = readl(ss->base + SS_CTL_REG); v >>= SS_DIE_ID_SHIFT; -- 2.17.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2020-05-20 8:12 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-05-20 8:11 Dinghao Liu [this message] 2020-05-20 8:11 ` [PATCH] crypto: sun8i-ss - fix runtime pm imbalance on error Dinghao Liu -- strict thread matches above, loose matches on Subject: below -- 2020-05-20 8:06 Dinghao Liu 2020-05-20 8:06 ` Dinghao Liu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200520081157.24922-1-dinghao.liu@zju.edu.cn \ --to=dinghao.liu@zju.edu.cn \ --cc=clabbe.montjoie@gmail.com \ --cc=colin.king@canonical.com \ --cc=davem@davemloft.net \ --cc=herbert@gondor.apana.org.au \ --cc=julia.lawall@lip6.fr \ --cc=kjlu@umn.edu \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-crypto@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=lkp@intel.com \ --cc=mripard@kernel.org \ --cc=wens@csie.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.