All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vivek Kasireddy <vivek.kasireddy@intel.com>
To: <intel-gfx@lists.freedesktop.org>
Cc: Jani Nikula <jani.nikula@intel.com>
Subject: [Intel-gfx] [PATCH] drm/i915/dsi: Dont forget to clean up the connector on error (v2)
Date: Fri, 22 May 2020 13:26:30 -0700	[thread overview]
Message-ID: <20200522202630.7604-1-vivek.kasireddy@intel.com> (raw)
In-Reply-To: <20200507010103.16040-1-vivek.kasireddy@intel.com>

If an error is encountered during the DSI initialization setup, the
drm connector object also needs to be cleaned up along with the encoder.
The error can happen due to a missing mode in the VBT or for other
reasons.

v2: Rephrase the commit message to make it more clear.

Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Vandita Kulkarni <vandita.kulkarni@intel.com>
Signed-off-by: Vivek Kasireddy <vivek.kasireddy@intel.com>
---
 drivers/gpu/drm/i915/display/icl_dsi.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/i915/display/icl_dsi.c b/drivers/gpu/drm/i915/display/icl_dsi.c
index 4fec5bd64920..f93f72463df5 100644
--- a/drivers/gpu/drm/i915/display/icl_dsi.c
+++ b/drivers/gpu/drm/i915/display/icl_dsi.c
@@ -1954,6 +1954,7 @@ void icl_dsi_init(struct drm_i915_private *dev_priv)
 	return;
 
 err:
+	drm_connector_cleanup(connector);
 	drm_encoder_cleanup(&encoder->base);
 	kfree(intel_dsi);
 	kfree(intel_connector);
-- 
2.21.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2020-05-22 20:33 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-07  1:01 [Intel-gfx] [PATCH] drm/i915/dsi: Dont forget to clean up the connector on error Vivek Kasireddy
2020-05-07  1:50 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2020-05-07  4:30 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2020-05-22 20:26 ` Vivek Kasireddy [this message]
2020-06-02 15:33   ` [Intel-gfx] [PATCH] drm/i915/dsi: Dont forget to clean up the connector on error (v2) Souza, Jose
2020-05-22 21:15 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dsi: Dont forget to clean up the connector on error (rev2) Patchwork
2020-05-23  8:42 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2020-06-02  3:19 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dsi: Dont forget to clean up the connector on error (rev3) Patchwork
2020-06-02 11:22 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2020-06-02 15:35   ` Souza, Jose

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200522202630.7604-1-vivek.kasireddy@intel.com \
    --to=vivek.kasireddy@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.