From: wu000273@umn.edu
To: lgirdwood@gmail.com
Cc: broonie@kernel.org, perex@perex.cz, tiwai@suse.com,
p.zabel@pengutronix.de, tglx@linutronix.de,
lsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
kjlu@umn.edu, wu000273@umn.edu
Subject: [PATCH] treewide: fix incomplete error-handling in img_i2s_in_probe.
Date: Mon, 25 May 2020 00:50:11 -0500 [thread overview]
Message-ID: <20200525055011.31925-1-wu000273@umn.edu> (raw)
From: Qiushi Wu <wu000273@umn.edu>
Function "pm_runtime_get_sync()" is not handled by "pm_runtime_put()"
if "PTR_ERR(rst) == -EPROBE_DEFER". Fix this issue by adding
"pm_runtime_put()" into this error path.
Fixes: f65bb92ca12e ("ASoC: img-i2s-in: Add runtime PM")
Signed-off-by: Qiushi Wu <wu000273@umn.edu>
---
sound/soc/img/img-i2s-in.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/soc/img/img-i2s-in.c b/sound/soc/img/img-i2s-in.c
index a495d1050d49..e30b66b94bf6 100644
--- a/sound/soc/img/img-i2s-in.c
+++ b/sound/soc/img/img-i2s-in.c
@@ -482,6 +482,7 @@ static int img_i2s_in_probe(struct platform_device *pdev)
if (IS_ERR(rst)) {
if (PTR_ERR(rst) == -EPROBE_DEFER) {
ret = -EPROBE_DEFER;
+ pm_runtime_put(&pdev->dev);
goto err_suspend;
}
--
2.17.1
next reply other threads:[~2020-05-25 5:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-25 5:50 wu000273 [this message]
2020-05-26 9:43 ` [PATCH] treewide: fix incomplete error-handling in img_i2s_in_probe Mark Brown
2020-05-26 16:45 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200525055011.31925-1-wu000273@umn.edu \
--to=wu000273@umn.edu \
--cc=broonie@kernel.org \
--cc=kjlu@umn.edu \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lsa-devel@alsa-project.org \
--cc=p.zabel@pengutronix.de \
--cc=perex@perex.cz \
--cc=tglx@linutronix.de \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.