All of lore.kernel.org
 help / color / mirror / Atom feed
From: Frank Wang <frank.wang-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
To: heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org,
	marex-ynQEQJNshbs@public.gmane.org,
	bmeng.cn-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	philipp.tomsich-SN7IsUiht6C/RdPyistoZJqQE7yCjDx5@public.gmane.org,
	klaus.goger-SN7IsUiht6C/RdPyistoZJqQE7yCjDx5@public.gmane.org,
	jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org,
	sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org,
	kever.yang-TNX95d0MmH7DzftRWevZcw@public.gmane.org
Cc: jianing.ren-TNX95d0MmH7DzftRWevZcw@public.gmane.org,
	marek.belisko-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	wmc-TNX95d0MmH7DzftRWevZcw@public.gmane.org,
	u-boot-0aAXYlwwYIKGBzrmiIFOJg@public.gmane.org,
	william.wu-TNX95d0MmH7DzftRWevZcw@public.gmane.org,
	linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-amarula-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org,
	chenjh-TNX95d0MmH7DzftRWevZcw@public.gmane.org
Subject: [PATCH v6 10/16] usb: dwc3: Enable AutoRetry feature in the controller
Date: Tue, 26 May 2020 11:34:29 +0800	[thread overview]
Message-ID: <20200526033435.20235-1-frank.wang@rock-chips.com> (raw)
In-Reply-To: <20200526033220.20047-1-frank.wang-TNX95d0MmH7DzftRWevZcw@public.gmane.org>

From: Jagan Teki <jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>

By default when core sees any transaction error (CRC or overflow) it
replies with terminating retry ACK (Retry=1 and Nump == 0).

Enabling this Auto Retry feature in controller will make the core send
a non-terminanting ACK upon such transaction errors. That is, ACK TP
with Retry=1 and Nump != 0.

Doing so will give controller a chance to recover from transient error
conditions.

Reference from below Linux commit,

commit <b138e23d3dff> ("usb: dwc3: core: Enable AutoRetry feature
in the controller")

Cc: Marek Vasut <marex-ynQEQJNshbs@public.gmane.org>
Signed-off-by: Jagan Teki <jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>
Reviewed-by: Kever Yang <kever.yang-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
---
 drivers/usb/dwc3/core.c | 9 +++++++++
 drivers/usb/dwc3/core.h | 3 +++
 2 files changed, 12 insertions(+)

diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
index dc92f471c1..aab6c34c2d 100644
--- a/drivers/usb/dwc3/core.c
+++ b/drivers/usb/dwc3/core.c
@@ -995,6 +995,15 @@ int dwc3_init(struct dwc3 *dwc)
 		dwc3_writel(dwc->regs, DWC3_GUCTL1, reg);
 	}
 
+	if (dwc->dr_mode == USB_DR_MODE_HOST ||
+	    dwc->dr_mode == USB_DR_MODE_OTG) {
+		reg = dwc3_readl(dwc->regs, DWC3_GUCTL);
+
+		reg |= DWC3_GUCTL_HSTINAUTORETRY;
+
+		dwc3_writel(dwc->regs, DWC3_GUCTL, reg);
+	}
+
 	ret = dwc3_core_init_mode(dwc);
 	if (ret)
 		goto mode_fail;
diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
index b510d8a983..2adcaf0029 100644
--- a/drivers/usb/dwc3/core.h
+++ b/drivers/usb/dwc3/core.h
@@ -160,6 +160,9 @@
 #define DWC3_GCTL_GBLHIBERNATIONEN	(1 << 1)
 #define DWC3_GCTL_DSBLCLKGTNG		(1 << 0)
 
+/* Global User Control Register */
+#define DWC3_GUCTL_HSTINAUTORETRY	BIT(14)
+
 /* Global User Control 1 Register */
 #define DWC3_GUCTL1_TX_IPGAP_LINECHECK_DIS	BIT(28)
 #define DWC3_GUCTL1_DEV_L1_EXIT_BY_HW	BIT(24)
-- 
2.17.1

WARNING: multiple messages have this Message-ID (diff)
From: Frank Wang <frank.wang@rock-chips.com>
To: u-boot@lists.denx.de
Subject: [PATCH v6 10/16] usb: dwc3: Enable AutoRetry feature in the controller
Date: Tue, 26 May 2020 11:34:29 +0800	[thread overview]
Message-ID: <20200526033435.20235-1-frank.wang@rock-chips.com> (raw)
In-Reply-To: <20200526033220.20047-1-frank.wang@rock-chips.com>

From: Jagan Teki <jagan@amarulasolutions.com>

By default when core sees any transaction error (CRC or overflow) it
replies with terminating retry ACK (Retry=1 and Nump == 0).

Enabling this Auto Retry feature in controller will make the core send
a non-terminanting ACK upon such transaction errors. That is, ACK TP
with Retry=1 and Nump != 0.

Doing so will give controller a chance to recover from transient error
conditions.

Reference from below Linux commit,

commit <b138e23d3dff> ("usb: dwc3: core: Enable AutoRetry feature
in the controller")

Cc: Marek Vasut <marex@denx.de>
Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>
---
 drivers/usb/dwc3/core.c | 9 +++++++++
 drivers/usb/dwc3/core.h | 3 +++
 2 files changed, 12 insertions(+)

diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
index dc92f471c1..aab6c34c2d 100644
--- a/drivers/usb/dwc3/core.c
+++ b/drivers/usb/dwc3/core.c
@@ -995,6 +995,15 @@ int dwc3_init(struct dwc3 *dwc)
 		dwc3_writel(dwc->regs, DWC3_GUCTL1, reg);
 	}
 
+	if (dwc->dr_mode == USB_DR_MODE_HOST ||
+	    dwc->dr_mode == USB_DR_MODE_OTG) {
+		reg = dwc3_readl(dwc->regs, DWC3_GUCTL);
+
+		reg |= DWC3_GUCTL_HSTINAUTORETRY;
+
+		dwc3_writel(dwc->regs, DWC3_GUCTL, reg);
+	}
+
 	ret = dwc3_core_init_mode(dwc);
 	if (ret)
 		goto mode_fail;
diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
index b510d8a983..2adcaf0029 100644
--- a/drivers/usb/dwc3/core.h
+++ b/drivers/usb/dwc3/core.h
@@ -160,6 +160,9 @@
 #define DWC3_GCTL_GBLHIBERNATIONEN	(1 << 1)
 #define DWC3_GCTL_DSBLCLKGTNG		(1 << 0)
 
+/* Global User Control Register */
+#define DWC3_GUCTL_HSTINAUTORETRY	BIT(14)
+
 /* Global User Control 1 Register */
 #define DWC3_GUCTL1_TX_IPGAP_LINECHECK_DIS	BIT(28)
 #define DWC3_GUCTL1_DEV_L1_EXIT_BY_HW	BIT(24)
-- 
2.17.1

  parent reply	other threads:[~2020-05-26  3:34 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-26  3:32 [PATCH v6 00/16] Add Rockchip RK3399 USB3.0 Host support Frank Wang
2020-05-26  3:32 ` Frank Wang
2020-05-26  3:32 ` [PATCH v6 01/16] clk: rk3399: Enable/Disable the USB2PHY clk Frank Wang
2020-05-26  3:32   ` Frank Wang
     [not found] ` <20200526033220.20047-1-frank.wang-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2020-05-26  3:32   ` [PATCH v6 02/16] clk: rk3399: Set empty for TCPHY assigned-clocks Frank Wang
2020-05-26  3:32     ` Frank Wang
2020-05-26  3:32   ` [PATCH v6 03/16] clk: rk3399: Enable/Disable TCPHY clocks Frank Wang
2020-05-26  3:32     ` Frank Wang
2020-05-26  3:32   ` [PATCH v6 04/16] arm: mach-rockchip: bind sub-nodes for rk3399_syscon Frank Wang
2020-05-26  3:32     ` Frank Wang
2020-05-26  4:12     ` Jagan Teki
2020-05-26  4:12       ` Jagan Teki
2020-05-29 10:12     ` Kever Yang
2020-05-29 10:12       ` Kever Yang
2020-05-26  3:33   ` [PATCH v6 05/16] phy: rockchip: Add Rockchip USB2PHY driver Frank Wang
2020-05-26  3:33     ` Frank Wang
     [not found]     ` <20200526033355.20147-1-frank.wang-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2020-05-26  3:33       ` [PATCH v6 06/16] phy: rockchip: Add Rockchip USB TypeC PHY driver Frank Wang
2020-05-26  3:33         ` Frank Wang
2020-05-26  3:33       ` [PATCH v6 07/16] usb: dwc3: add dis_enblslpm_quirk Frank Wang
2020-05-26  3:33         ` Frank Wang
2020-05-26  3:33       ` [PATCH v6 08/16] usb: dwc3: add dis_u2_freeclk_exists_quirk Frank Wang
2020-05-26  3:33         ` Frank Wang
2020-05-26  3:33       ` [PATCH v6 09/16] usb: dwc3: Add disable u2mac linestate check quirk Frank Wang
2020-05-26  3:33         ` Frank Wang
2020-05-26  3:34   ` Frank Wang [this message]
2020-05-26  3:34     ` [PATCH v6 10/16] usb: dwc3: Enable AutoRetry feature in the controller Frank Wang
     [not found]     ` <20200526033435.20235-1-frank.wang-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2020-05-26  3:34       ` [PATCH v6 11/16] usb: dwc3: amend UTMI/UTMIW phy interface setup Frank Wang
2020-05-26  3:34         ` Frank Wang
2020-05-26  3:34       ` [PATCH v6 12/16] usb: dwc3: add make compatible for rockchip platform Frank Wang
2020-05-26  3:34         ` Frank Wang
2020-05-26  4:11         ` Jagan Teki
2020-05-26  4:11           ` Jagan Teki
2020-05-26  3:34       ` [PATCH v6 13/16] driver: usb: drop legacy rockchip xhci driver Frank Wang
2020-05-26  3:34         ` Frank Wang
2020-05-28 14:29         ` Heiko Stuebner
2020-05-28 14:29           ` Heiko Stuebner
2020-05-26  3:34       ` [PATCH v6 14/16] ARM: dts: rk3399-evb: usb3.0 host support Frank Wang
2020-05-26  3:34         ` Frank Wang
2020-05-26  3:35   ` [PATCH v6 15/16] configs: evb-rk3399: update support usb3.0 host Frank Wang
2020-05-26  3:35     ` Frank Wang
     [not found]     ` <20200526033516.20325-1-frank.wang-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2020-05-26  3:35       ` [PATCH v6 16/16] roc-rk3399-pc: Enable USB3.0 Host Frank Wang
2020-05-26  3:35         ` Frank Wang
2020-06-01  0:54   ` [PATCH v6 00/16] Add Rockchip RK3399 USB3.0 Host support Kever Yang
2020-06-01  0:54     ` Kever Yang
2020-05-26  4:16 ` Jagan Teki
2020-05-26  4:16   ` Jagan Teki
2020-05-26  8:55 ` Marcin Juszkiewicz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200526033435.20235-1-frank.wang@rock-chips.com \
    --to=frank.wang-tnx95d0mmh7dzftrwevzcw@public.gmane.org \
    --cc=bmeng.cn-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=chenjh-TNX95d0MmH7DzftRWevZcw@public.gmane.org \
    --cc=heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org \
    --cc=jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org \
    --cc=jianing.ren-TNX95d0MmH7DzftRWevZcw@public.gmane.org \
    --cc=kever.yang-TNX95d0MmH7DzftRWevZcw@public.gmane.org \
    --cc=klaus.goger-SN7IsUiht6C/RdPyistoZJqQE7yCjDx5@public.gmane.org \
    --cc=linux-amarula-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org \
    --cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=marek.belisko-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=marex-ynQEQJNshbs@public.gmane.org \
    --cc=philipp.tomsich-SN7IsUiht6C/RdPyistoZJqQE7yCjDx5@public.gmane.org \
    --cc=sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
    --cc=u-boot-0aAXYlwwYIKGBzrmiIFOJg@public.gmane.org \
    --cc=william.wu-TNX95d0MmH7DzftRWevZcw@public.gmane.org \
    --cc=wmc-TNX95d0MmH7DzftRWevZcw@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.