From: Ian Jackson <ian.jackson@eu.citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
Subject: [OSSTEST PATCH 1/4] cs-bisection-step: Change some url. references to job.
Date: Mon, 1 Jun 2020 13:44:27 +0100 [thread overview]
Message-ID: <20200601124430.29761-1-ian.jackson@eu.citrix.com> (raw)
This query is going to turn into two variants, one of which doesn't
have the url join.
In the output, prefer to refer to fields from job. They are
constrained to be equal (and they are not null) so this has no
functional change.
Also swap the conditions over for clarity.
No functional change.
Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
---
cs-bisection-step | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/cs-bisection-step b/cs-bisection-step
index 16227234..f9ef1558 100755
--- a/cs-bisection-step
+++ b/cs-bisection-step
@@ -231,8 +231,8 @@ END
SELECT url.val AS uval,
rev.val AS rval,
- url.job AS job,
- ${\ other_revision_job_suffix('url.job','url.use',' ') } AS othrev,
+ rev.job AS job,
+ ${\ other_revision_job_suffix('rev.job','rev.use',' ') } AS othrev,
url.name AS longname
FROM tmp_build_info AS rev
@@ -241,8 +241,8 @@ END
WHERE (rev.name LIKE E'built\\_revision\\_%' OR
rev.name LIKE E'revision\\_%')
AND url.name LIKE E'tree\\_%'
- AND rev.use = url.use
- AND rev.job = url.job
+ AND url.use = rev.use
+ AND url.job = rev.job
AND (rev.name = 'built_revision_' || substr(url.name,6) OR
rev.name = 'revision_' || substr(url.name,6))
--
2.20.1
next reply other threads:[~2020-06-01 12:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-01 12:44 Ian Jackson [this message]
2020-06-01 12:44 ` [OSSTEST PATCH 2/4] cs-bisection-step: flight_rmap Disassemble the revisions query Ian Jackson
2020-06-01 12:44 ` [OSSTEST PATCH 3/4] cs-bisection-step: Provide no-urls variant of the main query Ian Jackson
2020-06-01 12:44 ` [OSSTEST PATCH 4/4] cs-bisection-step: Do not insist on urls in main history search Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200601124430.29761-1-ian.jackson@eu.citrix.com \
--to=ian.jackson@eu.citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.