All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel.vetter@ffwll.ch>
To: DRI Development <dri-devel@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
	Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
	Liviu Dudau <liviu.dudau@arm.com>,
	Daniel Vetter <daniel.vetter@intel.com>
Subject: [PATCH 3/3] drm/hdlcd: Don't call drm_crtc_vblank_off on unbind
Date: Tue,  2 Jun 2020 11:51:40 +0200	[thread overview]
Message-ID: <20200602095140.36678-3-daniel.vetter@ffwll.ch> (raw)
In-Reply-To: <20200602095140.36678-1-daniel.vetter@ffwll.ch>

This is already taken care of by drm_atomic_helper_shutdown(), and
in that case only for the CRTC which are actually on.

Only tricky bit here is that we kill the interrupt handling before we
shut down crtc, so need to reorder that.

Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Cc: Liviu Dudau <liviu.dudau@arm.com>
Cc: Brian Starkey <brian.starkey@arm.com>
Cc:
---
 drivers/gpu/drm/arm/hdlcd_drv.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/arm/hdlcd_drv.c b/drivers/gpu/drm/arm/hdlcd_drv.c
index 194419f47c5e..26bc5d7766f5 100644
--- a/drivers/gpu/drm/arm/hdlcd_drv.c
+++ b/drivers/gpu/drm/arm/hdlcd_drv.c
@@ -347,9 +347,8 @@ static void hdlcd_drm_unbind(struct device *dev)
 	of_node_put(hdlcd->crtc.port);
 	hdlcd->crtc.port = NULL;
 	pm_runtime_get_sync(dev);
-	drm_crtc_vblank_off(&hdlcd->crtc);
-	drm_irq_uninstall(drm);
 	drm_atomic_helper_shutdown(drm);
+	drm_irq_uninstall(drm);
 	pm_runtime_put(dev);
 	if (pm_runtime_enabled(dev))
 		pm_runtime_disable(dev);
-- 
2.26.2

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Daniel Vetter <daniel.vetter@ffwll.ch>
To: DRI Development <dri-devel@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
	Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
	Daniel Vetter <daniel.vetter@intel.com>
Subject: [Intel-gfx] [PATCH 3/3] drm/hdlcd: Don't call drm_crtc_vblank_off on unbind
Date: Tue,  2 Jun 2020 11:51:40 +0200	[thread overview]
Message-ID: <20200602095140.36678-3-daniel.vetter@ffwll.ch> (raw)
In-Reply-To: <20200602095140.36678-1-daniel.vetter@ffwll.ch>

This is already taken care of by drm_atomic_helper_shutdown(), and
in that case only for the CRTC which are actually on.

Only tricky bit here is that we kill the interrupt handling before we
shut down crtc, so need to reorder that.

Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Cc: Liviu Dudau <liviu.dudau@arm.com>
Cc: Brian Starkey <brian.starkey@arm.com>
Cc:
---
 drivers/gpu/drm/arm/hdlcd_drv.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/arm/hdlcd_drv.c b/drivers/gpu/drm/arm/hdlcd_drv.c
index 194419f47c5e..26bc5d7766f5 100644
--- a/drivers/gpu/drm/arm/hdlcd_drv.c
+++ b/drivers/gpu/drm/arm/hdlcd_drv.c
@@ -347,9 +347,8 @@ static void hdlcd_drm_unbind(struct device *dev)
 	of_node_put(hdlcd->crtc.port);
 	hdlcd->crtc.port = NULL;
 	pm_runtime_get_sync(dev);
-	drm_crtc_vblank_off(&hdlcd->crtc);
-	drm_irq_uninstall(drm);
 	drm_atomic_helper_shutdown(drm);
+	drm_irq_uninstall(drm);
 	pm_runtime_put(dev);
 	if (pm_runtime_enabled(dev))
 		pm_runtime_disable(dev);
-- 
2.26.2

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2020-06-02  9:52 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-02  9:51 [PATCH 1/3] drm/atomic-helper: reset vblank on crtc reset Daniel Vetter
2020-06-02  9:51 ` [Intel-gfx] " Daniel Vetter
2020-06-02  9:51 ` Daniel Vetter
2020-06-02  9:51 ` [PATCH 2/3] drm/malidp: Don't call drm_crtc_vblank_off on unbind Daniel Vetter
2020-06-02  9:51   ` [Intel-gfx] " Daniel Vetter
2020-06-02  9:55   ` [PATCH] " Daniel Vetter
2020-06-02  9:55     ` [Intel-gfx] " Daniel Vetter
2020-06-02 13:02     ` Liviu Dudau
2020-06-02 13:02       ` [Intel-gfx] " Liviu Dudau
2020-06-02 12:59   ` [PATCH 2/3] " Liviu Dudau
2020-06-02 12:59     ` [Intel-gfx] " Liviu Dudau
2020-06-02  9:51 ` Daniel Vetter [this message]
2020-06-02  9:51   ` [Intel-gfx] [PATCH 3/3] drm/hdlcd: " Daniel Vetter
2020-06-02 13:00   ` Liviu Dudau
2020-06-02 13:00     ` [Intel-gfx] " Liviu Dudau
2020-06-03 13:46     ` Daniel Vetter
2020-06-03 13:46       ` [Intel-gfx] " Daniel Vetter
2020-06-02 12:11 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/atomic-helper: reset vblank on crtc reset (rev2) Patchwork
2020-06-02 12:33 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-06-02 19:44 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
     [not found] ` <20200602095140.36678-1-daniel.vetter-/w4YWyX8dFk@public.gmane.org>
2020-06-03  0:19   ` [PATCH 1/3] drm/atomic-helper: reset vblank on crtc reset Laurent Pinchart
2020-06-03  0:19     ` [Intel-gfx] " Laurent Pinchart
2020-06-03  0:19     ` Laurent Pinchart
     [not found]     ` <20200603001900.GV6547-N3hz7ZxfLydczECFQUw77jytWr6r+dGw0E9HWUfgJXw@public.gmane.org>
2020-06-03  7:55       ` Daniel Vetter
2020-06-03  7:55         ` [Intel-gfx] " Daniel Vetter
2020-06-03  7:55         ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200602095140.36678-3-daniel.vetter@ffwll.ch \
    --to=daniel.vetter@ffwll.ch \
    --cc=daniel.vetter@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=liviu.dudau@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.