All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Daniel Vetter <daniel.vetter@ffwll.ch>,
	Jani Nikula <jani.nikula@linux.intel.com>,
	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	Intel Graphics <intel-gfx@lists.freedesktop.org>,
	DRI <dri-devel@lists.freedesktop.org>
Cc: Linux Next Mailing List <linux-next@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Chris Wilson <chris@chris-wilson.co.uk>
Subject: linux-next: manual merge of the drm-intel-fixes tree with Linus' tree
Date: Wed, 3 Jun 2020 09:08:16 +1000	[thread overview]
Message-ID: <20200603090816.6437acec@canb.auug.org.au> (raw)

[-- Attachment #1: Type: text/plain, Size: 2308 bytes --]

Hi all,

Today's linux-next merge of the drm-intel-fixes tree got a conflict in:

  drivers/gpu/drm/i915/gt/intel_lrc.c

between commit:

  f53ae29c0ea1 ("drm/i915/gt: Include a few tracek for timeslicing")

from Linus' tree and commit:

  00febf644648 ("drm/i915/gt: Incorporate the virtual engine into timeslicing")

from the drm-intel-fixes tree.

I fixed it up (see below) and can carry the fix as necessary. This
is now fixed as far as linux-next is concerned, but any non trivial
conflicts should be mentioned to your upstream maintainer when your tree
is submitted for merging.  You may also want to consider cooperating
with the maintainer of the conflicting tree to minimise any particularly
complex conflicts.

-- 
Cheers,
Stephen Rothwell

diff --cc drivers/gpu/drm/i915/gt/intel_lrc.c
index 87e6c5bdd2dc,e77f89b43e5f..000000000000
--- a/drivers/gpu/drm/i915/gt/intel_lrc.c
+++ b/drivers/gpu/drm/i915/gt/intel_lrc.c
@@@ -1971,20 -1853,12 +1990,19 @@@ static void set_timeslice(struct intel_
  	if (!intel_engine_has_timeslices(engine))
  		return;
  
 -	set_timer_ms(&engine->execlists.timer, active_timeslice(engine));
 +	duration = active_timeslice(engine);
 +	ENGINE_TRACE(engine, "bump timeslicing, interval:%lu", duration);
 +
 +	set_timer_ms(&engine->execlists.timer, duration);
  }
  
- static void start_timeslice(struct intel_engine_cs *engine)
+ static void start_timeslice(struct intel_engine_cs *engine, int prio)
  {
  	struct intel_engine_execlists *execlists = &engine->execlists;
- 	const int prio = queue_prio(execlists);
 +	unsigned long duration;
 +
 +	if (!intel_engine_has_timeslices(engine))
 +		return;
  
  	WRITE_ONCE(execlists->switch_priority_hint, prio);
  	if (prio == INT_MIN)
@@@ -2140,13 -1994,8 +2158,13 @@@ static void execlists_dequeue(struct in
  			__unwind_incomplete_requests(engine);
  
  			last = NULL;
- 		} else if (need_timeslice(engine, last) &&
+ 		} else if (need_timeslice(engine, last, rb) &&
  			   timeslice_expired(execlists, last)) {
 +			if (i915_request_completed(last)) {
 +				tasklet_hi_schedule(&execlists->tasklet);
 +				return;
 +			}
 +
  			ENGINE_TRACE(engine,
  				     "expired last=%llx:%lld, prio=%d, hint=%d, yield?=%s\n",
  				     last->fence.context,

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Daniel Vetter <daniel.vetter@ffwll.ch>,
	Jani Nikula <jani.nikula@linux.intel.com>,
	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	Intel Graphics <intel-gfx@lists.freedesktop.org>,
	DRI <dri-devel@lists.freedesktop.org>
Cc: Linux Next Mailing List <linux-next@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Chris Wilson <chris@chris-wilson.co.uk>
Subject: linux-next: manual merge of the drm-intel-fixes tree with Linus' tree
Date: Wed, 3 Jun 2020 09:08:16 +1000	[thread overview]
Message-ID: <20200603090816.6437acec@canb.auug.org.au> (raw)


[-- Attachment #1.1: Type: text/plain, Size: 2308 bytes --]

Hi all,

Today's linux-next merge of the drm-intel-fixes tree got a conflict in:

  drivers/gpu/drm/i915/gt/intel_lrc.c

between commit:

  f53ae29c0ea1 ("drm/i915/gt: Include a few tracek for timeslicing")

from Linus' tree and commit:

  00febf644648 ("drm/i915/gt: Incorporate the virtual engine into timeslicing")

from the drm-intel-fixes tree.

I fixed it up (see below) and can carry the fix as necessary. This
is now fixed as far as linux-next is concerned, but any non trivial
conflicts should be mentioned to your upstream maintainer when your tree
is submitted for merging.  You may also want to consider cooperating
with the maintainer of the conflicting tree to minimise any particularly
complex conflicts.

-- 
Cheers,
Stephen Rothwell

diff --cc drivers/gpu/drm/i915/gt/intel_lrc.c
index 87e6c5bdd2dc,e77f89b43e5f..000000000000
--- a/drivers/gpu/drm/i915/gt/intel_lrc.c
+++ b/drivers/gpu/drm/i915/gt/intel_lrc.c
@@@ -1971,20 -1853,12 +1990,19 @@@ static void set_timeslice(struct intel_
  	if (!intel_engine_has_timeslices(engine))
  		return;
  
 -	set_timer_ms(&engine->execlists.timer, active_timeslice(engine));
 +	duration = active_timeslice(engine);
 +	ENGINE_TRACE(engine, "bump timeslicing, interval:%lu", duration);
 +
 +	set_timer_ms(&engine->execlists.timer, duration);
  }
  
- static void start_timeslice(struct intel_engine_cs *engine)
+ static void start_timeslice(struct intel_engine_cs *engine, int prio)
  {
  	struct intel_engine_execlists *execlists = &engine->execlists;
- 	const int prio = queue_prio(execlists);
 +	unsigned long duration;
 +
 +	if (!intel_engine_has_timeslices(engine))
 +		return;
  
  	WRITE_ONCE(execlists->switch_priority_hint, prio);
  	if (prio == INT_MIN)
@@@ -2140,13 -1994,8 +2158,13 @@@ static void execlists_dequeue(struct in
  			__unwind_incomplete_requests(engine);
  
  			last = NULL;
- 		} else if (need_timeslice(engine, last) &&
+ 		} else if (need_timeslice(engine, last, rb) &&
  			   timeslice_expired(execlists, last)) {
 +			if (i915_request_completed(last)) {
 +				tasklet_hi_schedule(&execlists->tasklet);
 +				return;
 +			}
 +
  			ENGINE_TRACE(engine,
  				     "expired last=%llx:%lld, prio=%d, hint=%d, yield?=%s\n",
  				     last->fence.context,

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Daniel Vetter <daniel.vetter@ffwll.ch>,
	Jani Nikula <jani.nikula@linux.intel.com>,
	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	Intel Graphics <intel-gfx@lists.freedesktop.org>,
	DRI <dri-devel@lists.freedesktop.org>
Cc: Linux Next Mailing List <linux-next@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Chris Wilson <chris@chris-wilson.co.uk>
Subject: [Intel-gfx] linux-next: manual merge of the drm-intel-fixes tree with Linus' tree
Date: Wed, 3 Jun 2020 09:08:16 +1000	[thread overview]
Message-ID: <20200603090816.6437acec@canb.auug.org.au> (raw)


[-- Attachment #1.1: Type: text/plain, Size: 2308 bytes --]

Hi all,

Today's linux-next merge of the drm-intel-fixes tree got a conflict in:

  drivers/gpu/drm/i915/gt/intel_lrc.c

between commit:

  f53ae29c0ea1 ("drm/i915/gt: Include a few tracek for timeslicing")

from Linus' tree and commit:

  00febf644648 ("drm/i915/gt: Incorporate the virtual engine into timeslicing")

from the drm-intel-fixes tree.

I fixed it up (see below) and can carry the fix as necessary. This
is now fixed as far as linux-next is concerned, but any non trivial
conflicts should be mentioned to your upstream maintainer when your tree
is submitted for merging.  You may also want to consider cooperating
with the maintainer of the conflicting tree to minimise any particularly
complex conflicts.

-- 
Cheers,
Stephen Rothwell

diff --cc drivers/gpu/drm/i915/gt/intel_lrc.c
index 87e6c5bdd2dc,e77f89b43e5f..000000000000
--- a/drivers/gpu/drm/i915/gt/intel_lrc.c
+++ b/drivers/gpu/drm/i915/gt/intel_lrc.c
@@@ -1971,20 -1853,12 +1990,19 @@@ static void set_timeslice(struct intel_
  	if (!intel_engine_has_timeslices(engine))
  		return;
  
 -	set_timer_ms(&engine->execlists.timer, active_timeslice(engine));
 +	duration = active_timeslice(engine);
 +	ENGINE_TRACE(engine, "bump timeslicing, interval:%lu", duration);
 +
 +	set_timer_ms(&engine->execlists.timer, duration);
  }
  
- static void start_timeslice(struct intel_engine_cs *engine)
+ static void start_timeslice(struct intel_engine_cs *engine, int prio)
  {
  	struct intel_engine_execlists *execlists = &engine->execlists;
- 	const int prio = queue_prio(execlists);
 +	unsigned long duration;
 +
 +	if (!intel_engine_has_timeslices(engine))
 +		return;
  
  	WRITE_ONCE(execlists->switch_priority_hint, prio);
  	if (prio == INT_MIN)
@@@ -2140,13 -1994,8 +2158,13 @@@ static void execlists_dequeue(struct in
  			__unwind_incomplete_requests(engine);
  
  			last = NULL;
- 		} else if (need_timeslice(engine, last) &&
+ 		} else if (need_timeslice(engine, last, rb) &&
  			   timeslice_expired(execlists, last)) {
 +			if (i915_request_completed(last)) {
 +				tasklet_hi_schedule(&execlists->tasklet);
 +				return;
 +			}
 +
  			ENGINE_TRACE(engine,
  				     "expired last=%llx:%lld, prio=%d, hint=%d, yield?=%s\n",
  				     last->fence.context,

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

             reply	other threads:[~2020-06-02 23:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-02 23:08 Stephen Rothwell [this message]
2020-06-02 23:08 ` [Intel-gfx] linux-next: manual merge of the drm-intel-fixes tree with Linus' tree Stephen Rothwell
2020-06-02 23:08 ` Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200603090816.6437acec@canb.auug.org.au \
    --to=sfr@canb.auug.org.au \
    --cc=chris@chris-wilson.co.uk \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=joonas.lahtinen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=rodrigo.vivi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.