All of lore.kernel.org
 help / color / mirror / Atom feed
From: Xia Jiang <xia.jiang@mediatek.com>
To: Hans Verkuil <hverkuil-cisco@xs4all.nl>,
	Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Rick Chang <rick.chang@mediatek.com>
Cc: <linux-media@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-mediatek@lists.infradead.org>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Tomasz Figa <tfiga@chromium.org>, <srv_heupstream@mediatek.com>,
	<senozhatsky@chromium.org>, <mojahsu@chromium.org>,
	<drinkcat@chromium.org>, <maoguang.meng@mediatek.com>,
	<sj.huang@mediatek.com>, Xia Jiang <xia.jiang@mediatek.com>
Subject: [PATCH v9 03/18] media: platform: Improve getting and requesting irq flow for bug fixing
Date: Thu, 4 Jun 2020 15:26:53 +0800	[thread overview]
Message-ID: <20200604072708.9468-4-xia.jiang@mediatek.com> (raw)
In-Reply-To: <20200604072708.9468-1-xia.jiang@mediatek.com>

Delete platform_get_resource operation for irq.
Return actual value rather than EINVAL when fail to get and request
irq.

Reviewed-by: Tomasz Figa <tfiga@chromium.org>
Signed-off-by: Xia Jiang <xia.jiang@mediatek.com>
---
v9: no changes
---
 drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
index 67a022d04df7..2677580941b0 100644
--- a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
+++ b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
@@ -1103,12 +1103,10 @@ static int mtk_jpeg_probe(struct platform_device *pdev)
 		return ret;
 	}
 
-	res = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
 	dec_irq = platform_get_irq(pdev, 0);
-	if (!res || dec_irq < 0) {
+	if (dec_irq < 0) {
 		dev_err(&pdev->dev, "Failed to get dec_irq %d.\n", dec_irq);
-		ret = -EINVAL;
-		return ret;
+		return dec_irq;
 	}
 
 	ret = devm_request_irq(&pdev->dev, dec_irq, mtk_jpeg_dec_irq, 0,
@@ -1116,7 +1114,6 @@ static int mtk_jpeg_probe(struct platform_device *pdev)
 	if (ret) {
 		dev_err(&pdev->dev, "Failed to request dec_irq %d (%d)\n",
 			dec_irq, ret);
-		ret = -EINVAL;
 		goto err_req_irq;
 	}
 
-- 
2.18.0

WARNING: multiple messages have this Message-ID (diff)
From: Xia Jiang <xia.jiang@mediatek.com>
To: Hans Verkuil <hverkuil-cisco@xs4all.nl>,
	Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	"Matthias Brugger" <matthias.bgg@gmail.com>,
	Rick Chang <rick.chang@mediatek.com>
Cc: maoguang.meng@mediatek.com, devicetree@vger.kernel.org,
	mojahsu@chromium.org, srv_heupstream@mediatek.com,
	linux-kernel@vger.kernel.org, Tomasz Figa <tfiga@chromium.org>,
	senozhatsky@chromium.org, sj.huang@mediatek.com,
	drinkcat@chromium.org, linux-mediatek@lists.infradead.org,
	Xia Jiang <xia.jiang@mediatek.com>,
	linux-media@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Marek Szyprowski <m.szyprowski@samsung.com>
Subject: [PATCH v9 03/18] media: platform: Improve getting and requesting irq flow for bug fixing
Date: Thu, 4 Jun 2020 15:26:53 +0800	[thread overview]
Message-ID: <20200604072708.9468-4-xia.jiang@mediatek.com> (raw)
In-Reply-To: <20200604072708.9468-1-xia.jiang@mediatek.com>

Delete platform_get_resource operation for irq.
Return actual value rather than EINVAL when fail to get and request
irq.

Reviewed-by: Tomasz Figa <tfiga@chromium.org>
Signed-off-by: Xia Jiang <xia.jiang@mediatek.com>
---
v9: no changes
---
 drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
index 67a022d04df7..2677580941b0 100644
--- a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
+++ b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
@@ -1103,12 +1103,10 @@ static int mtk_jpeg_probe(struct platform_device *pdev)
 		return ret;
 	}
 
-	res = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
 	dec_irq = platform_get_irq(pdev, 0);
-	if (!res || dec_irq < 0) {
+	if (dec_irq < 0) {
 		dev_err(&pdev->dev, "Failed to get dec_irq %d.\n", dec_irq);
-		ret = -EINVAL;
-		return ret;
+		return dec_irq;
 	}
 
 	ret = devm_request_irq(&pdev->dev, dec_irq, mtk_jpeg_dec_irq, 0,
@@ -1116,7 +1114,6 @@ static int mtk_jpeg_probe(struct platform_device *pdev)
 	if (ret) {
 		dev_err(&pdev->dev, "Failed to request dec_irq %d (%d)\n",
 			dec_irq, ret);
-		ret = -EINVAL;
 		goto err_req_irq;
 	}
 
-- 
2.18.0
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

WARNING: multiple messages have this Message-ID (diff)
From: Xia Jiang <xia.jiang@mediatek.com>
To: Hans Verkuil <hverkuil-cisco@xs4all.nl>,
	Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	"Matthias Brugger" <matthias.bgg@gmail.com>,
	Rick Chang <rick.chang@mediatek.com>
Cc: maoguang.meng@mediatek.com, devicetree@vger.kernel.org,
	mojahsu@chromium.org, srv_heupstream@mediatek.com,
	linux-kernel@vger.kernel.org, Tomasz Figa <tfiga@chromium.org>,
	senozhatsky@chromium.org, sj.huang@mediatek.com,
	drinkcat@chromium.org, linux-mediatek@lists.infradead.org,
	Xia Jiang <xia.jiang@mediatek.com>,
	linux-media@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Marek Szyprowski <m.szyprowski@samsung.com>
Subject: [PATCH v9 03/18] media: platform: Improve getting and requesting irq flow for bug fixing
Date: Thu, 4 Jun 2020 15:26:53 +0800	[thread overview]
Message-ID: <20200604072708.9468-4-xia.jiang@mediatek.com> (raw)
In-Reply-To: <20200604072708.9468-1-xia.jiang@mediatek.com>

Delete platform_get_resource operation for irq.
Return actual value rather than EINVAL when fail to get and request
irq.

Reviewed-by: Tomasz Figa <tfiga@chromium.org>
Signed-off-by: Xia Jiang <xia.jiang@mediatek.com>
---
v9: no changes
---
 drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
index 67a022d04df7..2677580941b0 100644
--- a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
+++ b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
@@ -1103,12 +1103,10 @@ static int mtk_jpeg_probe(struct platform_device *pdev)
 		return ret;
 	}
 
-	res = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
 	dec_irq = platform_get_irq(pdev, 0);
-	if (!res || dec_irq < 0) {
+	if (dec_irq < 0) {
 		dev_err(&pdev->dev, "Failed to get dec_irq %d.\n", dec_irq);
-		ret = -EINVAL;
-		return ret;
+		return dec_irq;
 	}
 
 	ret = devm_request_irq(&pdev->dev, dec_irq, mtk_jpeg_dec_irq, 0,
@@ -1116,7 +1114,6 @@ static int mtk_jpeg_probe(struct platform_device *pdev)
 	if (ret) {
 		dev_err(&pdev->dev, "Failed to request dec_irq %d (%d)\n",
 			dec_irq, ret);
-		ret = -EINVAL;
 		goto err_req_irq;
 	}
 
-- 
2.18.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2020-06-04  7:29 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-04  7:26 [PATCH v9 00/18] Add support for mt2701 JPEG ENC support Xia Jiang
2020-06-04  7:26 ` Xia Jiang
2020-06-04  7:26 ` Xia Jiang
2020-06-04  7:26 ` [PATCH v9 01/18] media: platform: Improve subscribe event flow for bug fixing Xia Jiang
2020-06-04  7:26   ` Xia Jiang
2020-06-04  7:26   ` Xia Jiang
2020-06-04  7:26 ` [PATCH v9 02/18] media: platform: Improve queue set up " Xia Jiang
2020-06-04  7:26   ` Xia Jiang
2020-06-04  7:26   ` Xia Jiang
2020-06-04  7:26 ` Xia Jiang [this message]
2020-06-04  7:26   ` [PATCH v9 03/18] media: platform: Improve getting and requesting irq " Xia Jiang
2020-06-04  7:26   ` Xia Jiang
2020-06-04  7:26 ` [PATCH v9 04/18] media: platform: Change the fixed device node number to unfixed value Xia Jiang
2020-06-04  7:26   ` Xia Jiang
2020-06-04  7:26   ` Xia Jiang
2020-06-04  7:26 ` [PATCH v9 05/18] media: platform: Improve power on and power off flow Xia Jiang
2020-06-04  7:26   ` Xia Jiang
2020-06-04  7:26   ` Xia Jiang
2020-06-04  7:26 ` [PATCH v9 06/18] media: platform: Delete the resetting hardware flow in the system PM ops Xia Jiang
2020-06-04  7:26   ` Xia Jiang
2020-06-04  7:26   ` Xia Jiang
2020-06-04  7:26 ` [PATCH v9 07/18] media: platform: Improve the implementation of " Xia Jiang
2020-06-04  7:26   ` Xia Jiang
2020-06-04  7:26   ` Xia Jiang
2020-06-04  7:26 ` [PATCH v9 08/18] media: platform: Cancel the last frame handling flow Xia Jiang
2020-06-04  7:26   ` Xia Jiang
2020-06-04  7:26   ` Xia Jiang
2020-06-04  7:26 ` [PATCH v9 09/18] media: platform: Delete zeroing the reserved fields Xia Jiang
2020-06-04  7:26   ` Xia Jiang
2020-06-04  7:26   ` Xia Jiang
2020-06-04  7:27 ` [PATCH v9 10/18] media: platform: Stylistic changes for improving code quality Xia Jiang
2020-06-04  7:27   ` Xia Jiang
2020-06-04  7:27   ` Xia Jiang
2020-06-04  7:27 ` [PATCH v9 11/18] media: platform: Use generic rounding helpers Xia Jiang
2020-06-04  7:27   ` Xia Jiang
2020-06-04  7:27   ` Xia Jiang
2020-06-04  7:27 ` [PATCH v9 12/18] media: platform: Change MTK_JPEG_COMP_MAX macro definition location Xia Jiang
2020-06-04  7:27   ` Xia Jiang
2020-06-04  7:27   ` Xia Jiang
2020-06-04  7:27 ` [PATCH v9 13/18] media: platform: Delete redundant code and add annotation for an enum Xia Jiang
2020-06-04  7:27   ` Xia Jiang
2020-06-04  7:27   ` Xia Jiang
2020-06-04  7:27 ` [PATCH v9 14/18] media: dt-bindings: Add jpeg enc device tree node document Xia Jiang
2020-06-04  7:27   ` Xia Jiang
2020-06-04  7:27   ` Xia Jiang
2020-06-04  7:27 ` [PATCH v9 15/18] arm: dts: mt2701: Add jpeg enc device tree node Xia Jiang
2020-06-04  7:27   ` Xia Jiang
2020-06-04  7:27   ` Xia Jiang
2020-06-04  7:27 ` [PATCH v9 16/18] media: platform: Rename jpeg dec file name Xia Jiang
2020-06-04  7:27   ` Xia Jiang
2020-06-04  7:27   ` Xia Jiang
2020-06-04  7:27 ` [PATCH v9 17/18] media: platform: Rename existing functions/defines/variables Xia Jiang
2020-06-04  7:27   ` Xia Jiang
2020-06-04  7:27   ` Xia Jiang
2020-06-04  7:27 ` [PATCH v9 18/18] media: platform: Add jpeg enc feature Xia Jiang
2020-06-04  7:27   ` Xia Jiang
2020-06-04  7:27   ` Xia Jiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200604072708.9468-4-xia.jiang@mediatek.com \
    --to=xia.jiang@mediatek.com \
    --cc=devicetree@vger.kernel.org \
    --cc=drinkcat@chromium.org \
    --cc=hverkuil-cisco@xs4all.nl \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=m.szyprowski@samsung.com \
    --cc=maoguang.meng@mediatek.com \
    --cc=matthias.bgg@gmail.com \
    --cc=mchehab+samsung@kernel.org \
    --cc=mojahsu@chromium.org \
    --cc=rick.chang@mediatek.com \
    --cc=robh+dt@kernel.org \
    --cc=senozhatsky@chromium.org \
    --cc=sj.huang@mediatek.com \
    --cc=srv_heupstream@mediatek.com \
    --cc=tfiga@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.