All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kenneth D'souza <kdsouza@redhat.com>
To: linux-cifs@vger.kernel.org
Cc: smfrench@gmail.com, kdsouza@redhat.com, rbergant@redhat.com
Subject: [PATCH v3] cifs: dump Security Type info in DebugData
Date: Fri,  5 Jun 2020 20:47:46 +0530	[thread overview]
Message-ID: <20200605151746.18743-1-kdsouza@redhat.com> (raw)

Currently the end user is unaware with what sec type the
cifs share is mounted if no sec=<type> option is parsed.
With this patch one can easily check from DebugData.

Example:
1) Name: x.x.x.x Uses: 1 Capability: 0x8001f3fc Session Status: 1 Security type: RawNTLMSSP

Signed-off-by: Kenneth D'souza <kdsouza@redhat.com>
Signed-off-by: Roberto Bergantinos Corpas <rbergant@redhat.com>
---
 fs/cifs/cifs_debug.c |  4 ++++
 fs/cifs/cifsglob.h   | 18 ++++++++++++++++++
 2 files changed, 22 insertions(+)

diff --git a/fs/cifs/cifs_debug.c b/fs/cifs/cifs_debug.c
index 916567d770f5..9caca784376b 100644
--- a/fs/cifs/cifs_debug.c
+++ b/fs/cifs/cifs_debug.c
@@ -375,6 +375,10 @@ static int cifs_debug_data_proc_show(struct seq_file *m, void *v)
 				ses->ses_count, ses->serverOS, ses->serverNOS,
 				ses->capabilities, ses->status);
 			}
+
+			seq_printf(m,"Security type: %s\n",
+					get_security_type_str(server->ops->select_sectype(server, ses->sectype)));
+
 			if (server->rdma)
 				seq_printf(m, "RDMA\n\t");
 			seq_printf(m, "TCP status: %d Instance: %d\n\tLocal Users To "
diff --git a/fs/cifs/cifsglob.h b/fs/cifs/cifsglob.h
index 39b708d9d86d..d8ef01039e71 100644
--- a/fs/cifs/cifsglob.h
+++ b/fs/cifs/cifsglob.h
@@ -1994,6 +1994,24 @@ extern struct smb_version_values smb302_values;
 extern struct smb_version_operations smb311_operations;
 extern struct smb_version_values smb311_values;
 
+static inline char *get_security_type_str(enum securityEnum sectype)
+{
+       switch (sectype) {
+       case RawNTLMSSP:
+               return "RawNTLMSSP";
+       case Kerberos:
+               return "Kerberos";
+       case NTLMv2:
+               return "NTLMv2";
+       case NTLM:
+               return "NTLM";
+       case LANMAN:
+               return "LANMAN";
+       default:
+               return "Unknown";
+       }
+}
+
 static inline bool is_smb1_server(struct TCP_Server_Info *server)
 {
 	return strcmp(server->vals->version_string, SMB1_VERSION_STRING) == 0;
-- 
2.21.1


             reply	other threads:[~2020-06-05 15:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-05 15:17 Kenneth D'souza [this message]
2020-06-09  5:01 ` [PATCH v3] cifs: dump Security Type info in DebugData Steve French
2020-06-09  5:02   ` Kenneth Dsouza

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200605151746.18743-1-kdsouza@redhat.com \
    --to=kdsouza@redhat.com \
    --cc=linux-cifs@vger.kernel.org \
    --cc=rbergant@redhat.com \
    --cc=smfrench@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.