All of lore.kernel.org
 help / color / mirror / Atom feed
From: Klaus Jensen <its@irrelevant.dk>
To: qemu-block@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>,
	"Klaus Jensen" <k.jensen@samsung.com>,
	qemu-devel@nongnu.org, "Max Reitz" <mreitz@redhat.com>,
	"Klaus Jensen" <its@irrelevant.dk>,
	"Keith Busch" <kbusch@kernel.org>,
	"Javier Gonzalez" <javier.gonz@samsung.com>,
	"Maxim Levitsky" <mlevitsk@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: [PATCH 0/1] hw/block/nvme: fix assert on invalid irq vector
Date: Tue,  9 Jun 2020 11:45:06 +0200	[thread overview]
Message-ID: <20200609094508.32412-1-its@irrelevant.dk> (raw)

From: Klaus Jensen <k.jensen@samsung.com>

I goofed up with commit c09794fe40e3 ("hw/block/nvme: allow use of any
valid msix vector").

This fixes the goof by adding a new msix_qsize parameter. As a nice
side-effect this allows a device with less interrupt vectors available
than supported queues. Also, improve the error handling in
nvme_init_pci().

Kevin, please consider picking this up for the block branch when
reviewed.

Cc: qemu-devel@nongnu.org
Cc: Keith Busch <kbusch@kernel.org>
Cc: Max Reitz <mreitz@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>
Cc: Klaus Jensen <its@irrelevant.dk>
Cc: Javier Gonzalez <javier.gonz@samsung.com>
Cc: Maxim Levitsky <mlevitsk@redhat.com>
Cc: Philippe Mathieu-Daudé <philmd@redhat.com>

Klaus Jensen (2):
  hw/block/nvme: add msix_qsize parameter
  hw/block/nvme: verify msix_init_exclusive_bar() return value

 hw/block/nvme.c | 28 ++++++++++++++++++++++------
 hw/block/nvme.h |  1 +
 2 files changed, 23 insertions(+), 6 deletions(-)

-- 
2.27.0



             reply	other threads:[~2020-06-09  9:46 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-09  9:45 Klaus Jensen [this message]
2020-06-09  9:45 ` [PATCH 1/2] hw/block/nvme: add msix_qsize parameter Klaus Jensen
2020-06-09  9:45 ` [PATCH 2/2] hw/block/nvme: verify msix_init_exclusive_bar() return value Klaus Jensen
2020-06-09 11:17 ` [PATCH 0/1] hw/block/nvme: fix assert on invalid irq vector Philippe Mathieu-Daudé
2020-06-09 11:46   ` Klaus Jensen
2020-06-09 14:14     ` Kevin Wolf
2020-06-09 14:18       ` Philippe Mathieu-Daudé
2020-06-09 15:32         ` Kevin Wolf
2020-06-09 18:38           ` Klaus Jensen
2020-07-07  9:10           ` Maxim Levitsky
2020-07-07  9:29             ` Klaus Jensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200609094508.32412-1-its@irrelevant.dk \
    --to=its@irrelevant.dk \
    --cc=javier.gonz@samsung.com \
    --cc=k.jensen@samsung.com \
    --cc=kbusch@kernel.org \
    --cc=kwolf@redhat.com \
    --cc=mlevitsk@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=philmd@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.