All of lore.kernel.org
 help / color / mirror / Atom feed
From: Klaus Jensen <its@irrelevant.dk>
To: qemu-block@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>,
	"Klaus Jensen" <k.jensen@samsung.com>,
	qemu-devel@nongnu.org, "Max Reitz" <mreitz@redhat.com>,
	"Klaus Jensen" <its@irrelevant.dk>,
	"Keith Busch" <kbusch@kernel.org>,
	"Javier Gonzalez" <javier.gonz@samsung.com>,
	"Maxim Levitsky" <mlevitsk@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: [PATCH v7 13/22] hw/block/nvme: add namespace helpers
Date: Tue,  9 Jun 2020 21:03:24 +0200	[thread overview]
Message-ID: <20200609190333.59390-14-its@irrelevant.dk> (raw)
In-Reply-To: <20200609190333.59390-1-its@irrelevant.dk>

From: Klaus Jensen <k.jensen@samsung.com>

Introduce some small helpers to make the next patches easier on the eye.

Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Maxim Levitsky <mlevitsk@redhat.com>
Reviewed-by: Keith Busch <kbusch@kernel.org>
Message-Id: <20200514044611.734782-15-its@irrelevant.dk>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
 hw/block/nvme.c |  3 +--
 hw/block/nvme.h | 17 +++++++++++++++++
 2 files changed, 18 insertions(+), 2 deletions(-)

diff --git a/hw/block/nvme.c b/hw/block/nvme.c
index 87f1f0d0d1a1..3f3db17231b3 100644
--- a/hw/block/nvme.c
+++ b/hw/block/nvme.c
@@ -1573,8 +1573,7 @@ static void nvme_realize(PCIDevice *pci_dev, Error **errp)
         id_ns->dps = 0;
         id_ns->lbaf[0].ds = BDRV_SECTOR_BITS;
         id_ns->ncap  = id_ns->nuse = id_ns->nsze =
-            cpu_to_le64(n->ns_size >>
-                id_ns->lbaf[NVME_ID_NS_FLBAS_INDEX(ns->id_ns.flbas)].ds);
+            cpu_to_le64(nvme_ns_nlbas(n, ns));
     }
 }
 
diff --git a/hw/block/nvme.h b/hw/block/nvme.h
index cedc8022dbb3..61dd9b23b81d 100644
--- a/hw/block/nvme.h
+++ b/hw/block/nvme.h
@@ -61,6 +61,17 @@ typedef struct NvmeNamespace {
     NvmeIdNs        id_ns;
 } NvmeNamespace;
 
+static inline NvmeLBAF *nvme_ns_lbaf(NvmeNamespace *ns)
+{
+    NvmeIdNs *id_ns = &ns->id_ns;
+    return &id_ns->lbaf[NVME_ID_NS_FLBAS_INDEX(id_ns->flbas)];
+}
+
+static inline uint8_t nvme_ns_lbads(NvmeNamespace *ns)
+{
+    return nvme_ns_lbaf(ns)->ds;
+}
+
 #define TYPE_NVME "nvme"
 #define NVME(obj) \
         OBJECT_CHECK(NvmeCtrl, (obj), TYPE_NVME)
@@ -97,4 +108,10 @@ typedef struct NvmeCtrl {
     NvmeIdCtrl      id_ctrl;
 } NvmeCtrl;
 
+/* calculate the number of LBAs that the namespace can accomodate */
+static inline uint64_t nvme_ns_nlbas(NvmeCtrl *n, NvmeNamespace *ns)
+{
+    return n->ns_size >> nvme_ns_lbads(ns);
+}
+
 #endif /* HW_NVME_H */
-- 
2.27.0



  parent reply	other threads:[~2020-06-09 19:08 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-09 19:03 [PATCH v7 00/22] nvme: small fixes, refactoring and cleanups Klaus Jensen
2020-06-09 19:03 ` [PATCH v7 01/22] hw/block/nvme: fix pci doorbell size calculation Klaus Jensen
2020-06-09 19:03 ` [PATCH v7 02/22] hw/block/nvme: rename trace events to pci_nvme Klaus Jensen
2020-06-09 19:03 ` [PATCH v7 03/22] hw/block/nvme: remove superfluous breaks Klaus Jensen
2020-06-09 19:03 ` [PATCH v7 04/22] hw/block/nvme: move device parameters to separate struct Klaus Jensen
2020-06-09 19:03 ` [PATCH v7 05/22] hw/block/nvme: use constants in identify Klaus Jensen
2020-06-09 19:03 ` [PATCH v7 06/22] hw/block/nvme: refactor nvme_addr_read Klaus Jensen
2020-06-09 19:03 ` [PATCH v7 07/22] hw/block/nvme: fix pin-based interrupt behavior Klaus Jensen
2020-06-09 19:03 ` [PATCH v7 08/22] hw/block/nvme: add max_ioqpairs device parameter Klaus Jensen
2020-06-09 19:03 ` [PATCH v7 09/22] hw/block/nvme: remove redundant cmbloc/cmbsz members Klaus Jensen
2020-06-09 19:03 ` [PATCH v7 10/22] hw/block/nvme: factor out property/constraint checks Klaus Jensen
2020-06-09 19:03 ` [PATCH v7 11/22] hw/block/nvme: factor out device state setup Klaus Jensen
2020-06-09 19:03 ` [PATCH v7 12/22] hw/block/nvme: factor out block backend setup Klaus Jensen
2020-06-09 19:03 ` Klaus Jensen [this message]
2020-06-09 19:03 ` [PATCH v7 14/22] hw/block/nvme: factor out namespace setup Klaus Jensen
2020-06-09 19:03 ` [PATCH v7 15/22] hw/block/nvme: factor out pci setup Klaus Jensen
2020-06-09 19:03 ` [PATCH v7 16/22] hw/block/nvme: factor out cmb setup Klaus Jensen
2020-06-09 19:03 ` [PATCH v7 17/22] hw/block/nvme: factor out pmr setup Klaus Jensen
2020-06-09 19:03 ` [PATCH v7 18/22] hw/block/nvme: do cmb/pmr init as part of pci init Klaus Jensen
2020-06-09 19:03 ` [PATCH v7 19/22] hw/block/nvme: factor out controller identify setup Klaus Jensen
2020-06-09 19:03 ` [PATCH v7 20/22] hw/block/nvme: Verify msix_vector_use() returned value Klaus Jensen
2020-06-09 19:03 ` [PATCH v7 21/22] hw/block/nvme: add msix_qsize parameter Klaus Jensen
2020-06-09 19:03 ` [PATCH v7 22/22] hw/block/nvme: verify msix_init_exclusive_bar() return value Klaus Jensen
2020-06-15 16:21 ` [PATCH v7 00/22] nvme: small fixes, refactoring and cleanups Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200609190333.59390-14-its@irrelevant.dk \
    --to=its@irrelevant.dk \
    --cc=javier.gonz@samsung.com \
    --cc=k.jensen@samsung.com \
    --cc=kbusch@kernel.org \
    --cc=kwolf@redhat.com \
    --cc=mlevitsk@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=philmd@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.