From: Daniel Vetter <daniel.vetter@ffwll.ch> To: DRI Development <dri-devel@lists.freedesktop.org> Cc: Stylon Wang <stylon.wang@amd.com>, Daniel Vetter <daniel.vetter@ffwll.ch>, Intel Graphics Development <intel-gfx@lists.freedesktop.org>, Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>, Roman Li <roman.li@amd.com>, Bhawanpreet Lakha <Bhawanpreet.Lakha@amd.com>, Alex Deucher <alexander.deucher@amd.com>, Daniel Vetter <daniel.vetter@intel.com>, Mikita Lipski <mikita.lipski@amd.com>, Nicholas Kazlauskas <nicholas.kazlauskas@amd.com> Subject: [PATCH 2/8] drm/amdgpu: Use __drm_atomic_helper_crtc_reset Date: Fri, 12 Jun 2020 18:00:50 +0200 [thread overview] Message-ID: <20200612160056.2082681-2-daniel.vetter@ffwll.ch> (raw) In-Reply-To: <20200612160056.2082681-1-daniel.vetter@ffwll.ch> Now also comes with the added benefit of doing a drm_crtc_vblank_off(), which means vblank state isn't ill-defined and fail-y at driver load before the first modeset on each crtc. Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> Cc: Alex Deucher <alexander.deucher@amd.com> Cc: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com> Cc: Harry Wentland <harry.wentland@amd.com> Cc: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com> Cc: Bhawanpreet Lakha <Bhawanpreet.Lakha@amd.com> Cc: Roman Li <roman.li@amd.com> Cc: Mikita Lipski <mikita.lipski@amd.com> Cc: Stylon Wang <stylon.wang@amd.com> --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c index 68a73065b516..36d605a6eb16 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c @@ -4594,9 +4594,7 @@ static void dm_crtc_reset_state(struct drm_crtc *crtc) if (WARN_ON(!state)) return; - crtc->state = &state->base; - crtc->state->crtc = crtc; - + __drm_atomic_helper_crtc_reset(crtc, &state->base); } static struct drm_crtc_state * -- 2.26.2 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Vetter <daniel.vetter@ffwll.ch> To: DRI Development <dri-devel@lists.freedesktop.org> Cc: Stylon Wang <stylon.wang@amd.com>, Daniel Vetter <daniel.vetter@ffwll.ch>, Intel Graphics Development <intel-gfx@lists.freedesktop.org>, Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>, Roman Li <roman.li@amd.com>, Bhawanpreet Lakha <Bhawanpreet.Lakha@amd.com>, Alex Deucher <alexander.deucher@amd.com>, Daniel Vetter <daniel.vetter@intel.com>, Mikita Lipski <mikita.lipski@amd.com>, Harry Wentland <harry.wentland@amd.com>, Nicholas Kazlauskas <nicholas.kazlauskas@amd.com> Subject: [Intel-gfx] [PATCH 2/8] drm/amdgpu: Use __drm_atomic_helper_crtc_reset Date: Fri, 12 Jun 2020 18:00:50 +0200 [thread overview] Message-ID: <20200612160056.2082681-2-daniel.vetter@ffwll.ch> (raw) In-Reply-To: <20200612160056.2082681-1-daniel.vetter@ffwll.ch> Now also comes with the added benefit of doing a drm_crtc_vblank_off(), which means vblank state isn't ill-defined and fail-y at driver load before the first modeset on each crtc. Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> Cc: Alex Deucher <alexander.deucher@amd.com> Cc: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com> Cc: Harry Wentland <harry.wentland@amd.com> Cc: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com> Cc: Bhawanpreet Lakha <Bhawanpreet.Lakha@amd.com> Cc: Roman Li <roman.li@amd.com> Cc: Mikita Lipski <mikita.lipski@amd.com> Cc: Stylon Wang <stylon.wang@amd.com> --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c index 68a73065b516..36d605a6eb16 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c @@ -4594,9 +4594,7 @@ static void dm_crtc_reset_state(struct drm_crtc *crtc) if (WARN_ON(!state)) return; - crtc->state = &state->base; - crtc->state->crtc = crtc; - + __drm_atomic_helper_crtc_reset(crtc, &state->base); } static struct drm_crtc_state * -- 2.26.2 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-06-12 16:01 UTC|newest] Thread overview: 101+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-06-12 16:00 [PATCH 1/8] drm/atomic-helper: reset vblank on crtc reset Daniel Vetter 2020-06-12 16:00 ` [Intel-gfx] " Daniel Vetter 2020-06-12 16:00 ` Daniel Vetter 2020-06-12 16:00 ` Daniel Vetter 2020-06-12 16:00 ` Daniel Vetter 2020-06-12 16:00 ` Daniel Vetter [this message] 2020-06-12 16:00 ` [Intel-gfx] [PATCH 2/8] drm/amdgpu: Use __drm_atomic_helper_crtc_reset Daniel Vetter 2020-06-12 17:24 ` Harry Wentland 2020-06-12 17:24 ` [Intel-gfx] " Harry Wentland 2020-06-12 17:41 ` Alex Deucher 2020-06-12 17:41 ` [Intel-gfx] " Alex Deucher 2020-07-02 18:21 ` Daniel Vetter 2020-07-02 18:21 ` [Intel-gfx] " Daniel Vetter 2020-06-12 16:00 ` [PATCH 3/8] drm/imx: " Daniel Vetter 2020-06-12 16:00 ` [Intel-gfx] " Daniel Vetter 2020-06-12 16:00 ` Daniel Vetter 2020-06-24 7:25 ` Daniel Vetter 2020-06-24 7:25 ` [Intel-gfx] " Daniel Vetter 2020-06-24 7:25 ` Daniel Vetter 2020-07-02 9:41 ` Daniel Vetter 2020-07-02 9:41 ` [Intel-gfx] " Daniel Vetter 2020-07-02 9:41 ` Daniel Vetter 2020-07-02 10:12 ` Philipp Zabel 2020-07-02 10:12 ` [Intel-gfx] " Philipp Zabel 2020-07-02 10:12 ` Philipp Zabel 2020-06-12 16:00 ` [PATCH 4/8] drm/mtk: " Daniel Vetter 2020-06-12 16:00 ` [Intel-gfx] " Daniel Vetter 2020-06-12 16:00 ` Daniel Vetter 2020-06-12 16:00 ` Daniel Vetter 2020-06-23 16:01 ` Chun-Kuang Hu 2020-06-23 16:01 ` [Intel-gfx] " Chun-Kuang Hu 2020-06-23 16:01 ` Chun-Kuang Hu 2020-06-23 16:01 ` Chun-Kuang Hu 2020-06-12 16:00 ` [PATCH 5/8] drm/vc4: " Daniel Vetter 2020-06-12 16:00 ` [Intel-gfx] " Daniel Vetter 2020-06-24 8:49 ` Maxime Ripard 2020-06-24 8:49 ` [Intel-gfx] " Maxime Ripard 2020-06-12 16:00 ` [PATCH 6/8] drm/vmwgfx: " Daniel Vetter 2020-06-12 16:00 ` [Intel-gfx] " Daniel Vetter 2020-06-12 20:32 ` kernel test robot 2020-06-12 20:32 ` kernel test robot 2020-06-12 20:32 ` [Intel-gfx] " kernel test robot 2020-06-12 20:49 ` [PATCH] " Daniel Vetter 2020-06-12 20:49 ` [Intel-gfx] " Daniel Vetter 2020-06-22 14:31 ` Roland Scheidegger 2020-06-12 23:21 ` [PATCH 6/8] " kernel test robot 2020-06-12 23:21 ` kernel test robot 2020-06-12 23:21 ` [Intel-gfx] " kernel test robot 2020-06-12 16:00 ` [PATCH 7/8] drm/mipi-dbi: Remove ->enabled Daniel Vetter 2020-06-12 16:00 ` [Intel-gfx] " Daniel Vetter 2020-06-13 13:42 ` Noralf Trønnes 2020-06-13 13:42 ` [Intel-gfx] " Noralf Trønnes 2020-06-13 18:47 ` David Lechner 2020-06-13 18:47 ` [Intel-gfx] " David Lechner 2020-06-15 21:31 ` Emil Velikov 2020-06-15 21:31 ` Emil Velikov 2020-06-16 6:50 ` Daniel Vetter 2020-06-16 6:50 ` Daniel Vetter 2020-06-16 13:54 ` Emil Velikov 2020-06-16 13:54 ` Emil Velikov 2020-06-16 17:16 ` Daniel Vetter 2020-06-16 17:16 ` Daniel Vetter 2020-06-24 7:18 ` Daniel Vetter 2020-06-24 7:18 ` Daniel Vetter 2020-06-12 16:00 ` [PATCH 8/8] drm/tiny/repaper: Drop edp->enabled Daniel Vetter 2020-06-12 16:00 ` [Intel-gfx] " Daniel Vetter 2020-06-13 13:43 ` Noralf Trønnes 2020-06-13 13:43 ` [Intel-gfx] " Noralf Trønnes 2020-06-24 7:15 ` Daniel Vetter 2020-06-24 7:15 ` [Intel-gfx] " Daniel Vetter 2020-06-12 16:27 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/8] drm/atomic-helper: reset vblank on crtc reset Patchwork 2020-06-12 16:27 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork 2020-06-12 16:48 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork 2020-06-12 18:04 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork 2020-06-12 22:02 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/8] drm/atomic-helper: reset vblank on crtc reset (rev2) Patchwork 2020-06-12 22:02 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork 2020-06-12 22:25 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork 2020-06-13 0:24 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork [not found] ` <20200612160056.2082681-1-daniel.vetter-/w4YWyX8dFk@public.gmane.org> 2020-06-24 9:42 ` [PATCH 1/8] drm/atomic-helper: reset vblank on crtc reset Maxime Ripard 2020-06-24 9:42 ` [Intel-gfx] " Maxime Ripard 2020-06-24 9:42 ` Maxime Ripard 2020-06-24 9:42 ` Maxime Ripard 2020-06-24 9:42 ` Maxime Ripard 2020-07-02 11:27 ` Laurent Pinchart 2020-07-02 11:27 ` [Intel-gfx] " Laurent Pinchart 2020-07-02 11:27 ` Laurent Pinchart 2020-07-02 11:27 ` Laurent Pinchart 2020-07-02 11:27 ` Laurent Pinchart [not found] ` <20200702112722.GA18036-N3hz7ZxfLydczECFQUw77jytWr6r+dGw0E9HWUfgJXw@public.gmane.org> 2020-07-02 11:40 ` Daniel Vetter 2020-07-02 11:40 ` [Intel-gfx] " Daniel Vetter 2020-07-02 11:40 ` Daniel Vetter 2020-07-02 11:40 ` Daniel Vetter 2020-07-02 11:40 ` Daniel Vetter 2020-08-06 6:43 ` Tetsuo Handa 2020-08-06 6:43 ` [Intel-gfx] " Tetsuo Handa 2020-08-06 6:43 ` Tetsuo Handa 2020-08-06 6:43 ` Tetsuo Handa 2020-08-06 6:57 ` daniel 2020-08-06 6:57 ` [Intel-gfx] " daniel 2020-08-06 6:57 ` daniel 2020-08-06 6:57 ` daniel
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200612160056.2082681-2-daniel.vetter@ffwll.ch \ --to=daniel.vetter@ffwll.ch \ --cc=Bhawanpreet.Lakha@amd.com \ --cc=Rodrigo.Siqueira@amd.com \ --cc=alexander.deucher@amd.com \ --cc=daniel.vetter@intel.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=intel-gfx@lists.freedesktop.org \ --cc=mikita.lipski@amd.com \ --cc=nicholas.kazlauskas@amd.com \ --cc=roman.li@amd.com \ --cc=stylon.wang@amd.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.