From: Ulrich Hecht <uli+renesas@fpond.eu>
To: linux-renesas-soc@vger.kernel.org
Cc: linux-clk@vger.kernel.org, wsa@the-dreams.de,
geert@linux-m68k.org, magnus.damm@gmail.com,
Ulrich Hecht <uli+renesas@fpond.eu>
Subject: [PATCH v4 1/3] clk: renesas: cpg-mssr: mark clocks as critical only if on at boot
Date: Tue, 16 Jun 2020 18:26:24 +0200 [thread overview]
Message-ID: <20200616162626.27944-2-uli+renesas@fpond.eu> (raw)
In-Reply-To: <20200616162626.27944-1-uli+renesas@fpond.eu>
This allows us to add the RWDT clock to the list of critical clocks without
keeping it enabled needlessly if not used.
Changing the semantics of crit_mod_clks in this way is safe for the current
user (INTC-AP) because it is never off at boot time.
Signed-off-by: Ulrich Hecht <uli+renesas@fpond.eu>
---
drivers/clk/renesas/renesas-cpg-mssr.c | 17 +++++++++--------
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/drivers/clk/renesas/renesas-cpg-mssr.c b/drivers/clk/renesas/renesas-cpg-mssr.c
index dcb6e2706d37..4648a829db66 100644
--- a/drivers/clk/renesas/renesas-cpg-mssr.c
+++ b/drivers/clk/renesas/renesas-cpg-mssr.c
@@ -416,14 +416,6 @@ static void __init cpg_mssr_register_mod_clk(const struct mssr_mod_clk *mod,
init.name = mod->name;
init.ops = &cpg_mstp_clock_ops;
init.flags = CLK_SET_RATE_PARENT;
- for (i = 0; i < info->num_crit_mod_clks; i++)
- if (id == info->crit_mod_clks[i]) {
- dev_dbg(dev, "MSTP %s setting CLK_IS_CRITICAL\n",
- mod->name);
- init.flags |= CLK_IS_CRITICAL;
- break;
- }
-
parent_name = __clk_get_name(parent);
init.parent_names = &parent_name;
init.num_parents = 1;
@@ -432,6 +424,15 @@ static void __init cpg_mssr_register_mod_clk(const struct mssr_mod_clk *mod,
clock->priv = priv;
clock->hw.init = &init;
+ for (i = 0; i < info->num_crit_mod_clks; i++)
+ if (id == info->crit_mod_clks[i] &&
+ cpg_mstp_clock_is_enabled(&clock->hw)) {
+ dev_dbg(dev, "MSTP %s setting CLK_IS_CRITICAL\n",
+ mod->name);
+ init.flags |= CLK_IS_CRITICAL;
+ break;
+ }
+
clk = clk_register(NULL, &clock->hw);
if (IS_ERR(clk))
goto fail;
--
2.20.1
next prev parent reply other threads:[~2020-06-16 16:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-16 16:26 [PATCH v4 0/3] clk: renesas: cpg-mssr: add RWDT to critical clocks Ulrich Hecht
2020-06-16 16:26 ` Ulrich Hecht [this message]
2020-06-18 11:46 ` [PATCH v4 1/3] clk: renesas: cpg-mssr: mark clocks as critical only if on at boot Geert Uytterhoeven
2020-06-16 16:26 ` [PATCH v4 2/3] clk: renesas: rcar-gen3: mark RWDT clocks as critical Ulrich Hecht
2020-06-18 11:49 ` Geert Uytterhoeven
2020-06-16 16:26 ` [PATCH v4 3/3] clk: renesas: rzg2: mark RWDT clock " Ulrich Hecht
2020-06-18 11:50 ` Geert Uytterhoeven
2020-06-18 11:45 ` [PATCH v4 0/3] clk: renesas: cpg-mssr: add RWDT to critical clocks Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200616162626.27944-2-uli+renesas@fpond.eu \
--to=uli+renesas@fpond.eu \
--cc=geert@linux-m68k.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.