All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: alsa-devel@alsa-project.org
Cc: tiwai@suse.de, broonie@kernel.org,
	Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
	Kai Vehmanen <kai.vehmanen@linux.intel.com>
Subject: [PATCH 3/4] ASoC: Intel: sof_sdw: add missing .owner field
Date: Thu, 25 Jun 2020 13:06:34 -0500	[thread overview]
Message-ID: <20200625180635.3563-4-pierre-louis.bossart@linux.intel.com> (raw)
In-Reply-To: <20200625180635.3563-1-pierre-louis.bossart@linux.intel.com>

This field is required for ASoC cards. Not setting it will result in a
module->name pointer being NULL and generate problems such as

cat /proc/asound/modules
 0 (efault)

Reported-by: Jaroslav Kysela <perex@perex.cz>
Suggested-by: Takashi Iwai <tiwai@suse.de>
Fixes: 52db12d193d4 ('ASoC: Intel: boards: add sof_sdw machine driver')
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
---
 sound/soc/intel/boards/sof_sdw.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/intel/boards/sof_sdw.c b/sound/soc/intel/boards/sof_sdw.c
index e1c1a8ba78e6..d26b82526163 100644
--- a/sound/soc/intel/boards/sof_sdw.c
+++ b/sound/soc/intel/boards/sof_sdw.c
@@ -893,7 +893,7 @@ static const char sdw_card_long_name[] = "Intel Soundwire SOF";
 
 static struct snd_soc_card card_sof_sdw = {
 	.name = "soundwire",
-	.late_probe = sof_sdw_hdmi_card_late_probe,
+	.owner = THIS_MODULE,
 	.codec_conf = codec_conf,
 	.num_configs = ARRAY_SIZE(codec_conf),
 };
-- 
2.20.1


  parent reply	other threads:[~2020-06-25 18:09 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-25 18:06 [PATCH 0/4] ASoC: Intel: fix missing .owner fields Pierre-Louis Bossart
2020-06-25 18:06 ` [PATCH 1/4] ASoC: SOF: nocodec: add missing .owner field Pierre-Louis Bossart
2020-06-25 18:06 ` [PATCH 2/4] ASoC: Intel: cml_rt1011_rt5682: " Pierre-Louis Bossart
2020-06-25 18:06 ` Pierre-Louis Bossart [this message]
2020-06-25 18:24   ` [PATCH 3/4] ASoC: Intel: sof_sdw: " Cezary Rojewski
2020-06-25 18:34     ` Pierre-Louis Bossart
2020-06-25 18:06 ` [PATCH 4/4] ASoC: Intel: bxt_rt298: " Pierre-Louis Bossart
2020-06-25 18:26 ` [PATCH 0/4] ASoC: Intel: fix missing .owner fields Cezary Rojewski
2020-06-25 18:47 ` Pierre-Louis Bossart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200625180635.3563-4-pierre-louis.bossart@linux.intel.com \
    --to=pierre-louis.bossart@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=kai.vehmanen@linux.intel.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.