All of lore.kernel.org
 help / color / mirror / Atom feed
From: Klaus Jensen <its@irrelevant.dk>
To: qemu-block@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
	Klaus Jensen <k.jensen@samsung.com>,
	qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>,
	Klaus Jensen <its@irrelevant.dk>, Keith Busch <kbusch@kernel.org>,
	Maxim Levitsky <mlevitsk@redhat.com>
Subject: [PATCH 10/17] hw/block/nvme: fix missing endian conversion
Date: Mon, 29 Jun 2020 20:26:35 +0200	[thread overview]
Message-ID: <20200629182642.1170387-11-its@irrelevant.dk> (raw)
In-Reply-To: <20200629182642.1170387-1-its@irrelevant.dk>

From: Klaus Jensen <k.jensen@samsung.com>

Fix a missing cpu_to conversion.

Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
---
 hw/block/nvme.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/block/nvme.c b/hw/block/nvme.c
index c2507d8836fd..da13ca1ddb60 100644
--- a/hw/block/nvme.c
+++ b/hw/block/nvme.c
@@ -1081,7 +1081,7 @@ static uint16_t nvme_get_feature(NvmeCtrl *n, NvmeCmd *cmd, NvmeRequest *req)
 
         break;
     case NVME_VOLATILE_WRITE_CACHE:
-        result = blk_enable_write_cache(n->conf.blk);
+        result = cpu_to_le32(blk_enable_write_cache(n->conf.blk));
         trace_pci_nvme_getfeat_vwcache(result ? "enabled" : "disabled");
         break;
     case NVME_NUMBER_OF_QUEUES:
-- 
2.27.0



  parent reply	other threads:[~2020-06-29 18:33 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-29 18:26 [PATCH 00/17] hw/block/nvme: bump to v1.3 Klaus Jensen
2020-06-29 18:26 ` [PATCH 01/17] hw/block/nvme: bump spec data structures " Klaus Jensen
2020-07-03  0:44   ` Dmitry Fomichev
2020-07-03  5:42     ` Klaus Jensen
2020-06-29 18:26 ` [PATCH 02/17] hw/block/nvme: additional tracing Klaus Jensen
2020-07-03  0:44   ` Dmitry Fomichev
2020-06-29 18:26 ` [PATCH 03/17] hw/block/nvme: add support for the abort command Klaus Jensen
2020-07-03  0:44   ` Dmitry Fomichev
2020-06-29 18:26 ` [PATCH 04/17] hw/block/nvme: add temperature threshold feature Klaus Jensen
2020-07-03  0:44   ` Dmitry Fomichev
2020-07-03  5:45     ` Klaus Jensen
2020-06-29 18:26 ` [PATCH 05/17] hw/block/nvme: mark fw slot 1 as read-only Klaus Jensen
2020-07-03  0:44   ` Dmitry Fomichev
2020-06-29 18:26 ` [PATCH 06/17] hw/block/nvme: add support for the get log page command Klaus Jensen
2020-07-03  0:45   ` Dmitry Fomichev
2020-07-03  5:51     ` Klaus Jensen
2020-06-29 18:26 ` [PATCH 07/17] hw/block/nvme: add support for the asynchronous event request command Klaus Jensen
2020-07-03  0:45   ` Dmitry Fomichev
2020-06-29 18:26 ` [PATCH 08/17] hw/block/nvme: move NvmeFeatureVal into hw/block/nvme.h Klaus Jensen
2020-07-03  0:45   ` Dmitry Fomichev
2020-06-29 18:26 ` [PATCH 09/17] hw/block/nvme: flush write cache when disabled Klaus Jensen
2020-07-03  0:45   ` Dmitry Fomichev
2020-06-29 18:26 ` Klaus Jensen [this message]
2020-07-03  0:45   ` [PATCH 10/17] hw/block/nvme: fix missing endian conversion Dmitry Fomichev
2020-06-29 18:26 ` [PATCH 11/17] hw/block/nvme: add remaining mandatory controller parameters Klaus Jensen
2020-07-03  0:46   ` Dmitry Fomichev
2020-07-03  5:52     ` Klaus Jensen
2020-06-29 18:26 ` [PATCH 12/17] hw/block/nvme: support the get/set features select and save fields Klaus Jensen
2020-07-03  0:46   ` Dmitry Fomichev
2020-07-03  6:03     ` Klaus Jensen
2020-06-29 18:26 ` [PATCH 13/17] hw/block/nvme: make sure ncqr and nsqr is valid Klaus Jensen
2020-07-03  0:46   ` Dmitry Fomichev
2020-06-29 18:26 ` [PATCH 14/17] hw/block/nvme: support identify namespace descriptor list Klaus Jensen
2020-07-03  0:46   ` Dmitry Fomichev
2020-06-29 18:26 ` [PATCH 15/17] hw/block/nvme: enforce valid queue creation sequence Klaus Jensen
2020-07-03  0:47   ` Dmitry Fomichev
2020-06-29 18:26 ` [PATCH 16/17] hw/block/nvme: provide the mandatory subnqn field Klaus Jensen
2020-07-03  0:47   ` Dmitry Fomichev
2020-06-29 18:26 ` [PATCH 17/17] hw/block/nvme: bump supported version to v1.3 Klaus Jensen
2020-07-03  0:47   ` Dmitry Fomichev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200629182642.1170387-11-its@irrelevant.dk \
    --to=its@irrelevant.dk \
    --cc=k.jensen@samsung.com \
    --cc=kbusch@kernel.org \
    --cc=kwolf@redhat.com \
    --cc=mlevitsk@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.