From: Paul Cercueil <paul@crapouillou.net> To: David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>, Rob Herring <robh+dt@kernel.org> Cc: od@zcrc.me, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, Paul Cercueil <paul@crapouillou.net>, stable@vger.kernel.org Subject: [PATCH v2 05/10] drm/ingenic: Fix incorrect assumption about plane->index Date: Tue, 30 Jun 2020 01:52:05 +0200 [thread overview] Message-ID: <20200629235210.441709-5-paul@crapouillou.net> (raw) In-Reply-To: <20200629235210.441709-1-paul@crapouillou.net> plane->index is NOT the index of the color plane in a YUV frame. Actually, a YUV frame is represented by a single drm_plane, even though it contains three Y, U, V planes. Cc: stable@vger.kernel.org # v5.3 Fixes: 90b86fcc47b4 ("DRM: Add KMS driver for the Ingenic JZ47xx SoCs") Signed-off-by: Paul Cercueil <paul@crapouillou.net> --- Notes: v2: No change drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c index a15f9a1940c6..924c8daf071a 100644 --- a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c +++ b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c @@ -386,7 +386,7 @@ static void ingenic_drm_plane_atomic_update(struct drm_plane *plane, addr = drm_fb_cma_get_gem_addr(state->fb, state, 0); width = state->src_w >> 16; height = state->src_h >> 16; - cpp = state->fb->format->cpp[plane->index]; + cpp = state->fb->format->cpp[0]; priv->dma_hwdesc->addr = addr; priv->dma_hwdesc->cmd = width * height * cpp / 4; -- 2.27.0
WARNING: multiple messages have this Message-ID (diff)
From: Paul Cercueil <paul@crapouillou.net> To: David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>, Rob Herring <robh+dt@kernel.org> Cc: devicetree@vger.kernel.org, linux-mips@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Paul Cercueil <paul@crapouillou.net>, od@zcrc.me, stable@vger.kernel.org Subject: [PATCH v2 05/10] drm/ingenic: Fix incorrect assumption about plane->index Date: Tue, 30 Jun 2020 01:52:05 +0200 [thread overview] Message-ID: <20200629235210.441709-5-paul@crapouillou.net> (raw) In-Reply-To: <20200629235210.441709-1-paul@crapouillou.net> plane->index is NOT the index of the color plane in a YUV frame. Actually, a YUV frame is represented by a single drm_plane, even though it contains three Y, U, V planes. Cc: stable@vger.kernel.org # v5.3 Fixes: 90b86fcc47b4 ("DRM: Add KMS driver for the Ingenic JZ47xx SoCs") Signed-off-by: Paul Cercueil <paul@crapouillou.net> --- Notes: v2: No change drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c index a15f9a1940c6..924c8daf071a 100644 --- a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c +++ b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c @@ -386,7 +386,7 @@ static void ingenic_drm_plane_atomic_update(struct drm_plane *plane, addr = drm_fb_cma_get_gem_addr(state->fb, state, 0); width = state->src_w >> 16; height = state->src_h >> 16; - cpp = state->fb->format->cpp[plane->index]; + cpp = state->fb->format->cpp[0]; priv->dma_hwdesc->addr = addr; priv->dma_hwdesc->cmd = width * height * cpp / 4; -- 2.27.0 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-06-29 23:52 UTC|newest] Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-06-29 23:52 [PATCH v2 01/10] dt-bindings: display: Convert ingenic,lcd.txt to YAML Paul Cercueil 2020-06-29 23:52 ` [PATCH v2 01/10] dt-bindings: display: Convert ingenic, lcd.txt " Paul Cercueil 2020-06-29 23:52 ` [PATCH v2 02/10] dt-bindings: display: Add ingenic,ipu.yaml Paul Cercueil 2020-06-29 23:52 ` Paul Cercueil 2020-06-30 10:08 ` Sam Ravnborg 2020-06-30 10:08 ` Sam Ravnborg 2020-07-14 2:38 ` Rob Herring 2020-07-14 2:38 ` Rob Herring 2020-06-29 23:52 ` [PATCH v2 03/10] drm/ingenic: Rename ingenic-drm.c to ingenic-drm-drv.c Paul Cercueil 2020-06-29 23:52 ` Paul Cercueil 2020-06-30 10:09 ` Sam Ravnborg 2020-06-30 10:09 ` Sam Ravnborg 2020-06-29 23:52 ` [PATCH v2 04/10] drm/ingenic: Add missing CR in debug strings Paul Cercueil 2020-06-29 23:52 ` Paul Cercueil 2020-06-30 10:10 ` Sam Ravnborg 2020-06-30 10:10 ` Sam Ravnborg 2020-06-29 23:52 ` Paul Cercueil [this message] 2020-06-29 23:52 ` [PATCH v2 05/10] drm/ingenic: Fix incorrect assumption about plane->index Paul Cercueil 2020-06-30 11:35 ` Sam Ravnborg 2020-06-30 11:35 ` Sam Ravnborg 2020-06-29 23:52 ` [PATCH v2 06/10] drm/ingenic: Set DMA descriptor chain address in probe Paul Cercueil 2020-06-29 23:52 ` Paul Cercueil 2020-06-30 11:44 ` Sam Ravnborg 2020-06-30 11:44 ` Sam Ravnborg 2020-06-30 11:54 ` Paul Cercueil 2020-06-30 11:54 ` Paul Cercueil 2020-06-29 23:52 ` [PATCH v2 07/10] drm/ingenic: Move register definitions to ingenic-drm.h Paul Cercueil 2020-06-29 23:52 ` Paul Cercueil 2020-06-30 11:46 ` Sam Ravnborg 2020-06-30 11:46 ` Sam Ravnborg 2020-06-29 23:52 ` [PATCH v2 08/10] drm/ingenic: Add support for OSD mode Paul Cercueil 2020-06-29 23:52 ` Paul Cercueil 2020-06-30 12:05 ` Sam Ravnborg 2020-06-30 12:05 ` Sam Ravnborg 2020-06-30 14:39 ` Paul Cercueil 2020-06-30 14:39 ` Paul Cercueil 2020-06-29 23:52 ` [PATCH v2 09/10] drm/ingenic: Add support for the IPU Paul Cercueil 2020-06-29 23:52 ` Paul Cercueil 2020-06-30 12:16 ` Sam Ravnborg 2020-06-30 12:16 ` Sam Ravnborg 2020-06-30 13:33 ` Paul Cercueil 2020-06-30 13:33 ` Paul Cercueil 2020-06-29 23:52 ` [PATCH v2 10/10] drm/ingenic: Support multiple panels/bridges Paul Cercueil 2020-06-29 23:52 ` Paul Cercueil
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200629235210.441709-5-paul@crapouillou.net \ --to=paul@crapouillou.net \ --cc=airlied@linux.ie \ --cc=daniel@ffwll.ch \ --cc=devicetree@vger.kernel.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mips@vger.kernel.org \ --cc=od@zcrc.me \ --cc=robh+dt@kernel.org \ --cc=stable@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.