All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Al Viro <viro@zeniv.linux.org.uk>,
	Linus Torvalds <torvalds@linux-foundation.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>,
	Matthew Wilcox <willy@infradead.org>,
	Kees Cook <keescook@chromium.org>,
	Iurii Zaikin <yzaikin@google.com>,
	linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: [PATCH 03/23] bpfilter: switch to kernel_write
Date: Wed,  1 Jul 2020 22:09:31 +0200	[thread overview]
Message-ID: <20200701200951.3603160-4-hch@lst.de> (raw)
In-Reply-To: <20200701200951.3603160-1-hch@lst.de>

While pipes don't really need sb_writers projection, __kernel_write is an
interface better kept private, and the additional rw_verify_area does not
hurt here.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 net/bpfilter/bpfilter_kern.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/bpfilter/bpfilter_kern.c b/net/bpfilter/bpfilter_kern.c
index c0f0990f30b604..1905e01c3aa9a7 100644
--- a/net/bpfilter/bpfilter_kern.c
+++ b/net/bpfilter/bpfilter_kern.c
@@ -50,7 +50,7 @@ static int __bpfilter_process_sockopt(struct sock *sk, int optname,
 	req.len = optlen;
 	if (!bpfilter_ops.info.pid)
 		goto out;
-	n = __kernel_write(bpfilter_ops.info.pipe_to_umh, &req, sizeof(req),
+	n = kernel_write(bpfilter_ops.info.pipe_to_umh, &req, sizeof(req),
 			   &pos);
 	if (n != sizeof(req)) {
 		pr_err("write fail %zd\n", n);
-- 
2.26.2


  parent reply	other threads:[~2020-07-01 20:18 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-01 20:09 [RFC] stop using ->read and ->write for kernel access v3 Christoph Hellwig
2020-07-01 20:09 ` [PATCH 01/23] cachefiles: switch to kernel_write Christoph Hellwig
2020-07-01 20:09 ` [PATCH 02/23] autofs: " Christoph Hellwig
2020-07-01 20:09 ` Christoph Hellwig [this message]
2020-07-01 20:09 ` [PATCH 04/23] fs: unexport __kernel_write Christoph Hellwig
2020-07-01 20:09 ` [PATCH 05/23] fs: check FMODE_WRITE in __kernel_write Christoph Hellwig
2020-07-01 20:09 ` [PATCH 06/23] fs: implement kernel_write using __kernel_write Christoph Hellwig
2020-07-01 20:09 ` [PATCH 07/23] fs: remove __vfs_write Christoph Hellwig
2020-07-01 20:09 ` [PATCH 08/23] fs: don't change the address limit for ->write_iter in __kernel_write Christoph Hellwig
2020-07-01 20:09 ` [PATCH 09/23] fs: add a __kernel_read helper Christoph Hellwig
2020-07-01 20:09 ` [PATCH 10/23] integrity/ima: switch to using __kernel_read Christoph Hellwig
2020-07-01 20:09 ` [PATCH 11/23] fs: implement kernel_read " Christoph Hellwig
2020-07-01 20:09 ` [PATCH 12/23] fs: remove __vfs_read Christoph Hellwig
2020-07-01 20:09 ` [PATCH 13/23] fs: don't change the address limit for ->read_iter in __kernel_read Christoph Hellwig
2020-07-01 20:09 ` [PATCH 14/23] fs: refactor new_sync_read Christoph Hellwig
2020-07-01 20:09 ` [PATCH 15/23] seq_file: add seq_read_iter Christoph Hellwig
2020-07-01 20:09 ` [PATCH 16/23] seq_file: switch over direct seq_read method calls to seq_read_iter Christoph Hellwig
2020-07-02  9:46   ` Miguel Ojeda
2020-07-02 13:50     ` Christoph Hellwig
2020-07-03  5:56       ` Miguel Ojeda
2020-07-03  7:44         ` Joe Perches
2020-07-03  9:35           ` Miguel Ojeda
2020-07-03  9:43             ` Joe Perches
2020-07-01 20:09 ` [PATCH 17/23] proc: add a read_iter method to proc proc_ops Christoph Hellwig
2020-07-01 21:27   ` Al Viro
2020-07-02  5:18     ` Christoph Hellwig
2020-07-02  7:30       ` Christoph Hellwig
2020-07-01 20:09 ` [PATCH 18/23] proc: switch over direct seq_read method calls to seq_read_iter Christoph Hellwig
2020-07-01 20:09 ` [PATCH 19/23] sysctl: Call sysctl_head_finish on error Christoph Hellwig
2020-07-02  0:32   ` Matthew Wilcox
2020-07-02  5:15     ` Christoph Hellwig
2020-07-03  1:34       ` Al Viro
2020-07-01 20:09 ` [PATCH 20/23] sysctl: Convert to iter interfaces Christoph Hellwig
2020-07-01 20:09 ` [PATCH 21/23] fs: don't allow kernel reads and writes without iter ops Christoph Hellwig
2020-07-01 20:09 ` [PATCH 22/23] fs: default to generic_file_splice_read for files having ->read_iter Christoph Hellwig
2020-07-01 20:09 ` [PATCH 23/23] fs: don't allow splice read/write without explicit ops Christoph Hellwig
2020-07-07 17:47 stop using ->read and ->write for kernel access v3 Christoph Hellwig
2020-07-07 17:47 ` [PATCH 03/23] bpfilter: switch to kernel_write Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200701200951.3603160-4-hch@lst.de \
    --to=hch@lst.de \
    --cc=keescook@chromium.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mcgrof@kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=viro@zeniv.linux.org.uk \
    --cc=willy@infradead.org \
    --cc=yzaikin@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.