All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wei Yongjun <weiyongjun1@huawei.com>
To: Hulk Robot <hulkci@huawei.com>, Jakub Kicinski <kuba@kernel.org>,
	"Sumit Semwal" <sumit.semwal@linaro.org>,
	zhong jiang <zhongjiang@huawei.com>,
	Shannon Nelson <snelson@pensando.io>,
	Nikolay Aleksandrov <nikolay@cumulusnetworks.com>,
	Vaibhav Gupta <vaibhavgupta40@gmail.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Julian Wiedmann <jwi@linux.ibm.com>
Cc: Wei Yongjun <weiyongjun1@huawei.com>, <netdev@vger.kernel.org>,
	<linux-media@vger.kernel.org>, <dri-devel@lists.freedesktop.org>,
	<linaro-mm-sig@lists.linaro.org>
Subject: [PATCH net-next] ksz884x: mark pcidev_suspend() as __maybe_unused
Date: Thu, 2 Jul 2020 17:18:10 +0800	[thread overview]
Message-ID: <20200702091810.4999-1-weiyongjun1@huawei.com> (raw)

In certain configurations without power management support, gcc report
the following warning:

drivers/net/ethernet/micrel/ksz884x.c:7182:12: warning:
 'pcidev_suspend' defined but not used [-Wunused-function]
 7182 | static int pcidev_suspend(struct device *dev_d)
      |            ^~~~~~~~~~~~~~

Mark pcidev_suspend() as __maybe_unused to make it clear.

Fixes: 64120615d140 ("ksz884x: use generic power management")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
 drivers/net/ethernet/micrel/ksz884x.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/micrel/ksz884x.c b/drivers/net/ethernet/micrel/ksz884x.c
index 24901342ecc0..2ce7304d3753 100644
--- a/drivers/net/ethernet/micrel/ksz884x.c
+++ b/drivers/net/ethernet/micrel/ksz884x.c
@@ -7179,7 +7179,7 @@ static int __maybe_unused pcidev_resume(struct device *dev_d)
 	return 0;
 }
 
-static int pcidev_suspend(struct device *dev_d)
+static int __maybe_unused pcidev_suspend(struct device *dev_d)
 {
 	int i;
 	struct platform_info *info = dev_get_drvdata(dev_d);


WARNING: multiple messages have this Message-ID (diff)
From: Wei Yongjun <weiyongjun1@huawei.com>
To: Hulk Robot <hulkci@huawei.com>, Jakub Kicinski <kuba@kernel.org>,
	"Sumit Semwal" <sumit.semwal@linaro.org>,
	zhong jiang <zhongjiang@huawei.com>,
	Shannon Nelson <snelson@pensando.io>,
	Nikolay Aleksandrov <nikolay@cumulusnetworks.com>,
	Vaibhav Gupta <vaibhavgupta40@gmail.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Julian Wiedmann <jwi@linux.ibm.com>
Cc: linaro-mm-sig@lists.linaro.org, netdev@vger.kernel.org,
	Wei Yongjun <weiyongjun1@huawei.com>,
	dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org
Subject: [PATCH net-next] ksz884x: mark pcidev_suspend() as __maybe_unused
Date: Thu, 2 Jul 2020 17:18:10 +0800	[thread overview]
Message-ID: <20200702091810.4999-1-weiyongjun1@huawei.com> (raw)

In certain configurations without power management support, gcc report
the following warning:

drivers/net/ethernet/micrel/ksz884x.c:7182:12: warning:
 'pcidev_suspend' defined but not used [-Wunused-function]
 7182 | static int pcidev_suspend(struct device *dev_d)
      |            ^~~~~~~~~~~~~~

Mark pcidev_suspend() as __maybe_unused to make it clear.

Fixes: 64120615d140 ("ksz884x: use generic power management")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
 drivers/net/ethernet/micrel/ksz884x.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/micrel/ksz884x.c b/drivers/net/ethernet/micrel/ksz884x.c
index 24901342ecc0..2ce7304d3753 100644
--- a/drivers/net/ethernet/micrel/ksz884x.c
+++ b/drivers/net/ethernet/micrel/ksz884x.c
@@ -7179,7 +7179,7 @@ static int __maybe_unused pcidev_resume(struct device *dev_d)
 	return 0;
 }
 
-static int pcidev_suspend(struct device *dev_d)
+static int __maybe_unused pcidev_suspend(struct device *dev_d)
 {
 	int i;
 	struct platform_info *info = dev_get_drvdata(dev_d);

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

             reply	other threads:[~2020-07-02  9:08 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-02  9:18 Wei Yongjun [this message]
2020-07-02  9:18 ` [PATCH net-next] ksz884x: mark pcidev_suspend() as __maybe_unused Wei Yongjun
2020-07-02 10:18 ` Vaibhav Gupta
2020-07-02 10:18   ` Vaibhav Gupta
2020-07-02 21:24 ` David Miller
2020-07-02 21:24   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200702091810.4999-1-weiyongjun1@huawei.com \
    --to=weiyongjun1@huawei.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hulkci@huawei.com \
    --cc=jwi@linux.ibm.com \
    --cc=kuba@kernel.org \
    --cc=linaro-mm-sig@lists.linaro.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=nikolay@cumulusnetworks.com \
    --cc=snelson@pensando.io \
    --cc=sumit.semwal@linaro.org \
    --cc=vaibhavgupta40@gmail.com \
    --cc=zhongjiang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.