From: Ard Biesheuvel <ardb@kernel.org> To: linux-kernel@vger.kernel.org Cc: Ard Biesheuvel <ardb@kernel.org>, Herbert Xu <herbert@gondor.apana.org.au>, "David S. Miller" <davem@davemloft.net>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Trond Myklebust <trond.myklebust@hammerspace.com>, Anna Schumaker <anna.schumaker@netapp.com>, "J. Bruce Fields" <bfields@fieldses.org>, Chuck Lever <chuck.lever@oracle.com>, Eric Biggers <ebiggers@google.com>, linux-crypto@vger.kernel.org, netdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-nfs@vger.kernel.org Subject: [RFC PATCH 0/7] crypto: get rid of ecb(arc4) Date: Thu, 2 Jul 2020 12:19:40 +0200 [thread overview] Message-ID: <20200702101947.682-1-ardb@kernel.org> (raw) The RC4 algorithm does not fit the sckipher model very well: it is a stream cipher that combines the key and IV into a single vector, which implies that using the same key more than once amounts to stream cipher IV reuse, and therefore catastrophic failure. So let's replace the remaining legacy users (WEP and TKIP in the staging tree) to the ARC4 library interface, which does not rely on the crypto API at all. Also, remove the obsolete RC4-HMAC-MD5 algorithm from the SUNRPC driver stack. NOTE: It should not be too difficult to switch the kerberos code over to the ARC4 library interface as well, given that much of it uses a different code path already. But we should only do so if we really need to keep this support around, and it seems that this was only ever intended as a transitional algorithm for Windows NT/2000 clients. That leaves no remaining users of the ecb(arc4) skcipher, so we can remove any implementations as well. Cc: Herbert Xu <herbert@gondor.apana.org.au> Cc: "David S. Miller" <davem@davemloft.net> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Trond Myklebust <trond.myklebust@hammerspace.com> Cc: Anna Schumaker <anna.schumaker@netapp.com> Cc: "J. Bruce Fields" <bfields@fieldses.org> Cc: Chuck Lever <chuck.lever@oracle.com> Cc: Eric Biggers <ebiggers@google.com> Cc: linux-crypto@vger.kernel.org Cc: netdev@vger.kernel.org Cc: devel@driverdev.osuosl.org Cc: linux-nfs@vger.kernel.org Ard Biesheuvel (7): staging/rtl8192e: switch to RC4 library interface staging/rtl8192u: switch to RC4 library interface SUNRPC: remove RC4-HMAC-MD5 support from KerberosV crypto: remove ARC4 support from the skcipher API crypto: n2 - remove ecb(arc4) support crypto: bcm-iproc - remove ecb(arc4) support crypto: tcrypt - remove ecb(arc4) testing/benchmarking support crypto/Kconfig | 12 - crypto/Makefile | 1 - crypto/arc4.c | 76 ----- crypto/tcrypt.c | 21 +- crypto/testmgr.c | 7 - crypto/testmgr.h | 62 ---- drivers/crypto/bcm/cipher.c | 96 +----- drivers/crypto/bcm/cipher.h | 1 - drivers/crypto/bcm/spu.c | 23 +- drivers/crypto/bcm/spu.h | 1 - drivers/crypto/bcm/spu2.c | 12 +- drivers/crypto/bcm/spu2.h | 1 - drivers/crypto/n2_core.c | 46 --- drivers/net/wireless/intel/ipw2x00/Kconfig | 1 - drivers/net/wireless/intersil/hostap/Kconfig | 1 - drivers/staging/rtl8192e/Kconfig | 4 +- drivers/staging/rtl8192e/rtllib_crypt_tkip.c | 70 +---- drivers/staging/rtl8192e/rtllib_crypt_wep.c | 72 +---- drivers/staging/rtl8192u/Kconfig | 1 + .../rtl8192u/ieee80211/ieee80211_crypt_tkip.c | 82 +----- .../rtl8192u/ieee80211/ieee80211_crypt_wep.c | 64 +--- include/linux/sunrpc/gss_krb5.h | 11 - include/linux/sunrpc/gss_krb5_enctypes.h | 9 +- net/sunrpc/Kconfig | 1 - net/sunrpc/auth_gss/gss_krb5_crypto.c | 276 ------------------ net/sunrpc/auth_gss/gss_krb5_mech.c | 95 ------ net/sunrpc/auth_gss/gss_krb5_seal.c | 1 - net/sunrpc/auth_gss/gss_krb5_seqnum.c | 87 ------ net/sunrpc/auth_gss/gss_krb5_unseal.c | 1 - net/sunrpc/auth_gss/gss_krb5_wrap.c | 65 +---- 30 files changed, 78 insertions(+), 1122 deletions(-) delete mode 100644 crypto/arc4.c -- 2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: Ard Biesheuvel <ardb@kernel.org> To: linux-kernel@vger.kernel.org Cc: devel@driverdev.osuosl.org, linux-nfs@vger.kernel.org, Herbert Xu <herbert@gondor.apana.org.au>, Eric Biggers <ebiggers@google.com>, Ard Biesheuvel <ardb@kernel.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, "David S. Miller" <davem@davemloft.net>, "J. Bruce Fields" <bfields@fieldses.org>, Chuck Lever <chuck.lever@oracle.com>, linux-crypto@vger.kernel.org, netdev@vger.kernel.org, Anna Schumaker <anna.schumaker@netapp.com>, Trond Myklebust <trond.myklebust@hammerspace.com> Subject: [RFC PATCH 0/7] crypto: get rid of ecb(arc4) Date: Thu, 2 Jul 2020 12:19:40 +0200 [thread overview] Message-ID: <20200702101947.682-1-ardb@kernel.org> (raw) The RC4 algorithm does not fit the sckipher model very well: it is a stream cipher that combines the key and IV into a single vector, which implies that using the same key more than once amounts to stream cipher IV reuse, and therefore catastrophic failure. So let's replace the remaining legacy users (WEP and TKIP in the staging tree) to the ARC4 library interface, which does not rely on the crypto API at all. Also, remove the obsolete RC4-HMAC-MD5 algorithm from the SUNRPC driver stack. NOTE: It should not be too difficult to switch the kerberos code over to the ARC4 library interface as well, given that much of it uses a different code path already. But we should only do so if we really need to keep this support around, and it seems that this was only ever intended as a transitional algorithm for Windows NT/2000 clients. That leaves no remaining users of the ecb(arc4) skcipher, so we can remove any implementations as well. Cc: Herbert Xu <herbert@gondor.apana.org.au> Cc: "David S. Miller" <davem@davemloft.net> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Trond Myklebust <trond.myklebust@hammerspace.com> Cc: Anna Schumaker <anna.schumaker@netapp.com> Cc: "J. Bruce Fields" <bfields@fieldses.org> Cc: Chuck Lever <chuck.lever@oracle.com> Cc: Eric Biggers <ebiggers@google.com> Cc: linux-crypto@vger.kernel.org Cc: netdev@vger.kernel.org Cc: devel@driverdev.osuosl.org Cc: linux-nfs@vger.kernel.org Ard Biesheuvel (7): staging/rtl8192e: switch to RC4 library interface staging/rtl8192u: switch to RC4 library interface SUNRPC: remove RC4-HMAC-MD5 support from KerberosV crypto: remove ARC4 support from the skcipher API crypto: n2 - remove ecb(arc4) support crypto: bcm-iproc - remove ecb(arc4) support crypto: tcrypt - remove ecb(arc4) testing/benchmarking support crypto/Kconfig | 12 - crypto/Makefile | 1 - crypto/arc4.c | 76 ----- crypto/tcrypt.c | 21 +- crypto/testmgr.c | 7 - crypto/testmgr.h | 62 ---- drivers/crypto/bcm/cipher.c | 96 +----- drivers/crypto/bcm/cipher.h | 1 - drivers/crypto/bcm/spu.c | 23 +- drivers/crypto/bcm/spu.h | 1 - drivers/crypto/bcm/spu2.c | 12 +- drivers/crypto/bcm/spu2.h | 1 - drivers/crypto/n2_core.c | 46 --- drivers/net/wireless/intel/ipw2x00/Kconfig | 1 - drivers/net/wireless/intersil/hostap/Kconfig | 1 - drivers/staging/rtl8192e/Kconfig | 4 +- drivers/staging/rtl8192e/rtllib_crypt_tkip.c | 70 +---- drivers/staging/rtl8192e/rtllib_crypt_wep.c | 72 +---- drivers/staging/rtl8192u/Kconfig | 1 + .../rtl8192u/ieee80211/ieee80211_crypt_tkip.c | 82 +----- .../rtl8192u/ieee80211/ieee80211_crypt_wep.c | 64 +--- include/linux/sunrpc/gss_krb5.h | 11 - include/linux/sunrpc/gss_krb5_enctypes.h | 9 +- net/sunrpc/Kconfig | 1 - net/sunrpc/auth_gss/gss_krb5_crypto.c | 276 ------------------ net/sunrpc/auth_gss/gss_krb5_mech.c | 95 ------ net/sunrpc/auth_gss/gss_krb5_seal.c | 1 - net/sunrpc/auth_gss/gss_krb5_seqnum.c | 87 ------ net/sunrpc/auth_gss/gss_krb5_unseal.c | 1 - net/sunrpc/auth_gss/gss_krb5_wrap.c | 65 +---- 30 files changed, 78 insertions(+), 1122 deletions(-) delete mode 100644 crypto/arc4.c -- 2.17.1 _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next reply other threads:[~2020-07-02 10:23 UTC|newest] Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-02 10:19 Ard Biesheuvel [this message] 2020-07-02 10:19 ` [RFC PATCH 0/7] crypto: get rid of ecb(arc4) Ard Biesheuvel 2020-07-02 10:19 ` [RFC PATCH 1/7] staging/rtl8192e: switch to RC4 library interface Ard Biesheuvel 2020-07-02 10:19 ` Ard Biesheuvel 2020-07-02 10:32 ` Greg Kroah-Hartman 2020-07-02 10:32 ` Greg Kroah-Hartman 2020-07-02 10:19 ` [RFC PATCH 2/7] staging/rtl8192u: " Ard Biesheuvel 2020-07-02 10:19 ` Ard Biesheuvel 2020-07-02 10:32 ` Greg Kroah-Hartman 2020-07-02 10:32 ` Greg Kroah-Hartman 2020-07-02 10:19 ` [RFC PATCH 3/7] SUNRPC: remove RC4-HMAC-MD5 support from KerberosV Ard Biesheuvel 2020-07-02 10:19 ` Ard Biesheuvel 2020-07-02 15:49 ` J. Bruce Fields 2020-07-02 15:49 ` J. Bruce Fields 2020-07-02 10:19 ` [RFC PATCH 4/7] crypto: remove ARC4 support from the skcipher API Ard Biesheuvel 2020-07-02 10:19 ` Ard Biesheuvel 2020-07-02 17:50 ` Eric Biggers 2020-07-02 17:50 ` Eric Biggers 2020-07-02 18:21 ` Ard Biesheuvel 2020-07-02 18:21 ` Ard Biesheuvel 2020-07-02 23:04 ` Ard Biesheuvel 2020-07-02 23:04 ` Ard Biesheuvel 2020-07-18 8:18 ` Ard Biesheuvel 2020-07-18 8:18 ` Ard Biesheuvel 2020-07-25 7:06 ` Ard Biesheuvel 2020-07-25 7:06 ` Ard Biesheuvel 2020-08-04 13:59 ` Ard Biesheuvel 2020-08-04 13:59 ` Ard Biesheuvel 2020-07-02 10:19 ` [RFC PATCH 5/7] crypto: n2 - remove ecb(arc4) support Ard Biesheuvel 2020-07-02 10:19 ` Ard Biesheuvel 2020-07-02 10:19 ` [RFC PATCH 6/7] crypto: bcm-iproc " Ard Biesheuvel 2020-07-02 10:19 ` Ard Biesheuvel 2020-07-02 10:19 ` [RFC PATCH 7/7] crypto: tcrypt - remove ecb(arc4) testing/benchmarking support Ard Biesheuvel 2020-07-02 10:19 ` Ard Biesheuvel
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200702101947.682-1-ardb@kernel.org \ --to=ardb@kernel.org \ --cc=anna.schumaker@netapp.com \ --cc=bfields@fieldses.org \ --cc=chuck.lever@oracle.com \ --cc=davem@davemloft.net \ --cc=devel@driverdev.osuosl.org \ --cc=ebiggers@google.com \ --cc=gregkh@linuxfoundation.org \ --cc=herbert@gondor.apana.org.au \ --cc=linux-crypto@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-nfs@vger.kernel.org \ --cc=netdev@vger.kernel.org \ --cc=trond.myklebust@hammerspace.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.