All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Gerd Hoffmann" <kraxel@redhat.com>,
	"Daniel P. Berrangé" <berrange@redhat.com>,
	"Eduardo Habkost" <ehabkost@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>
Subject: [PULL 10/10] chardev: enable modules, use for braille
Date: Thu,  2 Jul 2020 14:20:48 +0200	[thread overview]
Message-ID: <20200702122048.27798-11-kraxel@redhat.com> (raw)
In-Reply-To: <20200702122048.27798-1-kraxel@redhat.com>

Removes brlapi library dependency from core qemu.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Message-id: 20200624131045.14512-11-kraxel@redhat.com
---
 Makefile.objs         | 1 +
 chardev/char.c        | 2 +-
 util/module.c         | 1 +
 chardev/Makefile.objs | 5 ++++-
 4 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/Makefile.objs b/Makefile.objs
index 3d45492d8b46..d22b3b45d7b6 100644
--- a/Makefile.objs
+++ b/Makefile.objs
@@ -71,6 +71,7 @@ common-obj-$(CONFIG_TPM) += tpm.o
 
 common-obj-y += backends/
 common-obj-y += chardev/
+common-obj-m += chardev/
 
 common-obj-$(CONFIG_SECCOMP) += qemu-seccomp.o
 qemu-seccomp.o-cflags := $(SECCOMP_CFLAGS)
diff --git a/chardev/char.c b/chardev/char.c
index e3051295ac37..df697f3ce9e0 100644
--- a/chardev/char.c
+++ b/chardev/char.c
@@ -527,7 +527,7 @@ static const ChardevClass *char_get_class(const char *driver, Error **errp)
     const ChardevClass *cc;
     char *typename = g_strdup_printf("chardev-%s", driver);
 
-    oc = object_class_by_name(typename);
+    oc = module_object_class_by_name(typename);
     g_free(typename);
 
     if (!object_class_dynamic_cast(oc, TYPE_CHARDEV)) {
diff --git a/util/module.c b/util/module.c
index a74214eac052..32b0547b8266 100644
--- a/util/module.c
+++ b/util/module.c
@@ -272,6 +272,7 @@ static struct {
     { "vhost-user-gpu-device", "hw-", "display-virtio-gpu"    },
     { "vhost-user-gpu-pci",    "hw-", "display-virtio-gpu"    },
     { "vhost-user-vga",        "hw-", "display-virtio-gpu"    },
+    { "chardev-braille",       "chardev-", "baum"             },
 };
 
 static bool module_loaded_qom_all;
diff --git a/chardev/Makefile.objs b/chardev/Makefile.objs
index d68e1347f9af..3a58c9d329d6 100644
--- a/chardev/Makefile.objs
+++ b/chardev/Makefile.objs
@@ -18,8 +18,11 @@ chardev-obj-$(CONFIG_WIN32) += char-win.o
 chardev-obj-$(CONFIG_WIN32) += char-win-stdio.o
 
 common-obj-y += msmouse.o wctablet.o testdev.o
-common-obj-$(CONFIG_BRLAPI) += baum.o
+
+ifeq ($(CONFIG_BRLAPI),y)
+common-obj-m += baum.o
 baum.o-cflags := $(SDL_CFLAGS)
 baum.o-libs := $(BRLAPI_LIBS)
+endif
 
 common-obj-$(CONFIG_SPICE) += spice.o
-- 
2.18.4



  parent reply	other threads:[~2020-07-02 12:26 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-02 12:20 [PULL 00/10] Modules 20200702 patches Gerd Hoffmann
2020-07-02 12:20 ` [PULL 01/10] module: qom module support Gerd Hoffmann
2020-07-02 12:20 ` [PULL 02/10] object: " Gerd Hoffmann
2020-07-02 12:20 ` [PULL 03/10] qdev: device " Gerd Hoffmann
2020-07-02 12:20 ` [PULL 04/10] build: fix device module builds Gerd Hoffmann
2020-07-03  9:01   ` Claudio Fontana
2020-07-03 10:25     ` Gerd Hoffmann
2020-07-03 13:00       ` Claudio Fontana
2020-07-06 13:14         ` Gerd Hoffmann
2020-07-02 12:20 ` [PULL 05/10] ccid: build smartcard as module Gerd Hoffmann
2020-07-02 12:20 ` [PULL 06/10] usb: build usb-redir " Gerd Hoffmann
2020-07-02 12:20 ` [PULL 07/10] vga: build qxl " Gerd Hoffmann
2020-07-02 12:20 ` [PULL 08/10] vga: build virtio-gpu only once Gerd Hoffmann
2020-07-02 12:20 ` [PULL 09/10] vga: build virtio-gpu as module Gerd Hoffmann
2020-07-02 12:20 ` Gerd Hoffmann [this message]
2020-07-03  8:54 ` [PULL 00/10] Modules 20200702 patches Peter Maydell
2020-07-03 10:39   ` Gerd Hoffmann
2020-07-03 12:05     ` Paolo Bonzini
2020-07-06 13:20       ` Gerd Hoffmann
2020-07-06 14:30       ` Claudio Fontana
2020-07-03  9:14 ` Claudio Fontana
2020-07-03 10:29   ` Gerd Hoffmann
2020-07-07 13:42 [PULL 00/10] Modules 20200707 patches Gerd Hoffmann
2020-07-07 13:42 ` [PULL 10/10] chardev: enable modules, use for braille Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200702122048.27798-11-kraxel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=berrange@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.