All of lore.kernel.org
 help / color / mirror / Atom feed
From: Helen Koike <helen.koike@collabora.com>
To: devicetree@vger.kernel.org, linux-media@vger.kernel.org,
	linux-rockchip@lists.infradead.org
Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
	robh+dt@kernel.org, heiko@sntech.de, hverkuil-cisco@xs4all.nl,
	kernel@collabora.com, dafna.hirschfeld@collabora.com,
	ezequiel@collabora.com, mark.rutland@arm.com,
	karthik.poduval@gmail.com, jbx6244@gmail.com, kishon@ti.com,
	tfiga@chromium.org, eddie.cai.linux@gmail.com,
	zhengsq@rock-chips.com
Subject: [PATCH v3 8/9] arm64: dts: rockchip: add isp0 node for rk3399
Date: Thu,  2 Jul 2020 13:54:09 -0300	[thread overview]
Message-ID: <20200702165410.2583375-9-helen.koike@collabora.com> (raw)
In-Reply-To: <20200702165410.2583375-1-helen.koike@collabora.com>

From: Shunqian Zheng <zhengsq@rock-chips.com>

RK3399 has two ISPs, but only isp0 was tested.
Add isp0 node in rk3399 dtsi

Verified with:
make ARCH=arm64 dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/media/rockchip-isp1.yaml

Signed-off-by: Shunqian Zheng <zhengsq@rock-chips.com>
Signed-off-by: Jacob Chen <jacob2.chen@rock-chips.com>
Signed-off-by: Helen Koike <helen.koike@collabora.com>

---

V3:
- clean up clocks

V2:
- re-order power-domains property

V1:
This patch was originally part of this patchset:

    https://patchwork.kernel.org/patch/10267431/

The only difference is:
- add phy properties
- add ports
---
 arch/arm64/boot/dts/rockchip/rk3399.dtsi | 27 ++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
index 2581e9cc7a1de..a27c3ccf4bd08 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
@@ -1710,6 +1710,33 @@ vopb_mmu: iommu@ff903f00 {
 		status = "disabled";
 	};
 
+	isp0: isp0@ff910000 {
+		compatible = "rockchip,rk3399-cif-isp";
+		reg = <0x0 0xff910000 0x0 0x4000>;
+		interrupts = <GIC_SPI 43 IRQ_TYPE_LEVEL_HIGH 0>;
+		clocks = <&cru SCLK_ISP0>,
+			 <&cru ACLK_ISP0_WRAPPER>,
+			 <&cru HCLK_ISP0_WRAPPER>;
+		clock-names = "clk_isp",
+			      "aclk_isp_wrap",
+			      "hclk_isp_wrap";
+		iommus = <&isp0_mmu>;
+		phys = <&mipi_dphy_rx0>;
+		phy-names = "dphy";
+		power-domains = <&power RK3399_PD_ISP0>;
+
+		ports {
+			#address-cells = <1>;
+			#size-cells = <0>;
+
+			port@0 {
+				reg = <0>;
+				#address-cells = <1>;
+				#size-cells = <0>;
+			};
+		};
+	};
+
 	isp0_mmu: iommu@ff914000 {
 		compatible = "rockchip,iommu";
 		reg = <0x0 0xff914000 0x0 0x100>, <0x0 0xff915000 0x0 0x100>;
-- 
2.26.0


WARNING: multiple messages have this Message-ID (diff)
From: Helen Koike <helen.koike@collabora.com>
To: devicetree@vger.kernel.org, linux-media@vger.kernel.org,
	linux-rockchip@lists.infradead.org
Cc: devel@driverdev.osuosl.org, mark.rutland@arm.com,
	eddie.cai.linux@gmail.com, tfiga@chromium.org,
	dafna.hirschfeld@collabora.com, heiko@sntech.de, kishon@ti.com,
	zhengsq@rock-chips.com, linux-kernel@vger.kernel.org,
	karthik.poduval@gmail.com, robh+dt@kernel.org,
	hverkuil-cisco@xs4all.nl, jbx6244@gmail.com,
	kernel@collabora.com, ezequiel@collabora.com
Subject: [PATCH v3 8/9] arm64: dts: rockchip: add isp0 node for rk3399
Date: Thu,  2 Jul 2020 13:54:09 -0300	[thread overview]
Message-ID: <20200702165410.2583375-9-helen.koike@collabora.com> (raw)
In-Reply-To: <20200702165410.2583375-1-helen.koike@collabora.com>

From: Shunqian Zheng <zhengsq@rock-chips.com>

RK3399 has two ISPs, but only isp0 was tested.
Add isp0 node in rk3399 dtsi

Verified with:
make ARCH=arm64 dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/media/rockchip-isp1.yaml

Signed-off-by: Shunqian Zheng <zhengsq@rock-chips.com>
Signed-off-by: Jacob Chen <jacob2.chen@rock-chips.com>
Signed-off-by: Helen Koike <helen.koike@collabora.com>

---

V3:
- clean up clocks

V2:
- re-order power-domains property

V1:
This patch was originally part of this patchset:

    https://patchwork.kernel.org/patch/10267431/

The only difference is:
- add phy properties
- add ports
---
 arch/arm64/boot/dts/rockchip/rk3399.dtsi | 27 ++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
index 2581e9cc7a1de..a27c3ccf4bd08 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
@@ -1710,6 +1710,33 @@ vopb_mmu: iommu@ff903f00 {
 		status = "disabled";
 	};
 
+	isp0: isp0@ff910000 {
+		compatible = "rockchip,rk3399-cif-isp";
+		reg = <0x0 0xff910000 0x0 0x4000>;
+		interrupts = <GIC_SPI 43 IRQ_TYPE_LEVEL_HIGH 0>;
+		clocks = <&cru SCLK_ISP0>,
+			 <&cru ACLK_ISP0_WRAPPER>,
+			 <&cru HCLK_ISP0_WRAPPER>;
+		clock-names = "clk_isp",
+			      "aclk_isp_wrap",
+			      "hclk_isp_wrap";
+		iommus = <&isp0_mmu>;
+		phys = <&mipi_dphy_rx0>;
+		phy-names = "dphy";
+		power-domains = <&power RK3399_PD_ISP0>;
+
+		ports {
+			#address-cells = <1>;
+			#size-cells = <0>;
+
+			port@0 {
+				reg = <0>;
+				#address-cells = <1>;
+				#size-cells = <0>;
+			};
+		};
+	};
+
 	isp0_mmu: iommu@ff914000 {
 		compatible = "rockchip,iommu";
 		reg = <0x0 0xff914000 0x0 0x100>, <0x0 0xff915000 0x0 0x100>;
-- 
2.26.0

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

  parent reply	other threads:[~2020-07-02 16:55 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-02 16:54 [PATCH v3 0/9] move Rockchip ISP bindings out of staging / add Helen Koike
2020-07-02 16:54 ` Helen Koike
2020-07-02 16:54 ` Helen Koike
2020-07-02 16:54 ` [PATCH v3 1/9] media: staging: dt-bindings: rkisp1: add missing required nodes Helen Koike
2020-07-02 16:54   ` Helen Koike
2020-07-02 16:54   ` Helen Koike
2020-07-02 16:54 ` [PATCH v3 2/9] media: staging: dt-bindings: rkisp1: add required items in i2c example Helen Koike
2020-07-02 16:54   ` Helen Koike
2020-07-02 16:54 ` [PATCH v3 3/9] media: staging: dt-bindings: rkisp1: re-order properties Helen Koike
2020-07-02 16:54   ` Helen Koike
2020-07-02 16:54   ` Helen Koike
2020-07-02 16:54 ` [PATCH v3 4/9] media: staging: dt-bindings: rkisp1: fix "no reg" error in parent node Helen Koike
2020-07-02 16:54   ` Helen Koike
2020-07-02 16:54   ` Helen Koike
2020-07-02 16:54 ` [PATCH v3 5/9] media: staging: rkisp1: remove unecessary clocks Helen Koike
2020-07-02 16:54   ` Helen Koike
2020-07-02 16:54   ` Helen Koike
2020-07-02 17:01   ` Helen Koike
2020-07-02 17:01     ` Helen Koike
2020-07-02 17:01     ` Helen Koike
2020-07-02 16:54 ` [PATCH v3 6/9] dt-bindings: media: rkisp1: move rockchip-isp1 bindings out of staging Helen Koike
2020-07-02 16:54   ` Helen Koike
2020-07-02 16:54 ` [PATCH v3 7/9] media: MAINTAINERS: rkisp1: add path to dt-bindings Helen Koike
2020-07-02 16:54   ` Helen Koike
2020-07-02 16:54   ` Helen Koike
2020-07-02 16:54 ` Helen Koike [this message]
2020-07-02 16:54   ` [PATCH v3 8/9] arm64: dts: rockchip: add isp0 node for rk3399 Helen Koike
2020-07-02 16:54 ` [PATCH v3 9/9] arm64: dts: rockchip: add isp and sensors for Scarlet Helen Koike
2020-07-02 16:54   ` Helen Koike

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200702165410.2583375-9-helen.koike@collabora.com \
    --to=helen.koike@collabora.com \
    --cc=dafna.hirschfeld@collabora.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=devicetree@vger.kernel.org \
    --cc=eddie.cai.linux@gmail.com \
    --cc=ezequiel@collabora.com \
    --cc=heiko@sntech.de \
    --cc=hverkuil-cisco@xs4all.nl \
    --cc=jbx6244@gmail.com \
    --cc=karthik.poduval@gmail.com \
    --cc=kernel@collabora.com \
    --cc=kishon@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=tfiga@chromium.org \
    --cc=zhengsq@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.