From: Nicholas Piggin <npiggin@gmail.com>
To: linuxppc-dev@lists.ozlabs.org
Cc: Nicholas Piggin <npiggin@gmail.com>,
kvm-ppc@vger.kernel.org, linux-mm@kvack.org,
linux-api@vger.kernel.org
Subject: [PATCH v2 1/3] powerpc: remove stale calc_vm_prot_bits comment
Date: Fri, 3 Jul 2020 11:19:56 +1000 [thread overview]
Message-ID: <20200703011958.1166620-2-npiggin@gmail.com> (raw)
In-Reply-To: <20200703011958.1166620-1-npiggin@gmail.com>
This comment is wrong, we wouldn't use calc_vm_prot_bits here because
we are being called by calc_vm_prot_bits to modify its behaviour.
Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
---
arch/powerpc/include/asm/mman.h | 4 ----
1 file changed, 4 deletions(-)
diff --git a/arch/powerpc/include/asm/mman.h b/arch/powerpc/include/asm/mman.h
index d610c2e07b28..4ba303ea27f5 100644
--- a/arch/powerpc/include/asm/mman.h
+++ b/arch/powerpc/include/asm/mman.h
@@ -13,10 +13,6 @@
#include <linux/pkeys.h>
#include <asm/cpu_has_feature.h>
-/*
- * This file is included by linux/mman.h, so we can't use cacl_vm_prot_bits()
- * here. How important is the optimization?
- */
static inline unsigned long arch_calc_vm_prot_bits(unsigned long prot,
unsigned long pkey)
{
--
2.23.0
WARNING: multiple messages have this Message-ID (diff)
From: Nicholas Piggin <npiggin@gmail.com>
To: linuxppc-dev@lists.ozlabs.org
Cc: linux-mm@kvack.org, kvm-ppc@vger.kernel.org,
Nicholas Piggin <npiggin@gmail.com>,
linux-api@vger.kernel.org
Subject: [PATCH v2 1/3] powerpc: remove stale calc_vm_prot_bits comment
Date: Fri, 3 Jul 2020 11:19:56 +1000 [thread overview]
Message-ID: <20200703011958.1166620-2-npiggin@gmail.com> (raw)
In-Reply-To: <20200703011958.1166620-1-npiggin@gmail.com>
This comment is wrong, we wouldn't use calc_vm_prot_bits here because
we are being called by calc_vm_prot_bits to modify its behaviour.
Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
---
arch/powerpc/include/asm/mman.h | 4 ----
1 file changed, 4 deletions(-)
diff --git a/arch/powerpc/include/asm/mman.h b/arch/powerpc/include/asm/mman.h
index d610c2e07b28..4ba303ea27f5 100644
--- a/arch/powerpc/include/asm/mman.h
+++ b/arch/powerpc/include/asm/mman.h
@@ -13,10 +13,6 @@
#include <linux/pkeys.h>
#include <asm/cpu_has_feature.h>
-/*
- * This file is included by linux/mman.h, so we can't use cacl_vm_prot_bits()
- * here. How important is the optimization?
- */
static inline unsigned long arch_calc_vm_prot_bits(unsigned long prot,
unsigned long pkey)
{
--
2.23.0
WARNING: multiple messages have this Message-ID (diff)
From: Nicholas Piggin <npiggin@gmail.com>
To: linuxppc-dev@lists.ozlabs.org
Cc: Nicholas Piggin <npiggin@gmail.com>,
kvm-ppc@vger.kernel.org, linux-mm@kvack.org,
linux-api@vger.kernel.org
Subject: [PATCH v2 1/3] powerpc: remove stale calc_vm_prot_bits comment
Date: Fri, 03 Jul 2020 01:19:56 +0000 [thread overview]
Message-ID: <20200703011958.1166620-2-npiggin@gmail.com> (raw)
In-Reply-To: <20200703011958.1166620-1-npiggin@gmail.com>
This comment is wrong, we wouldn't use calc_vm_prot_bits here because
we are being called by calc_vm_prot_bits to modify its behaviour.
Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
---
arch/powerpc/include/asm/mman.h | 4 ----
1 file changed, 4 deletions(-)
diff --git a/arch/powerpc/include/asm/mman.h b/arch/powerpc/include/asm/mman.h
index d610c2e07b28..4ba303ea27f5 100644
--- a/arch/powerpc/include/asm/mman.h
+++ b/arch/powerpc/include/asm/mman.h
@@ -13,10 +13,6 @@
#include <linux/pkeys.h>
#include <asm/cpu_has_feature.h>
-/*
- * This file is included by linux/mman.h, so we can't use cacl_vm_prot_bits()
- * here. How important is the optimization?
- */
static inline unsigned long arch_calc_vm_prot_bits(unsigned long prot,
unsigned long pkey)
{
--
2.23.0
next prev parent reply other threads:[~2020-07-03 1:20 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-03 1:19 [PATCH v2 0/3] remove PROT_SAO support and disable Nicholas Piggin
2020-07-03 1:19 ` Nicholas Piggin
2020-07-03 1:19 ` Nicholas Piggin
2020-07-03 1:19 ` Nicholas Piggin [this message]
2020-07-03 1:19 ` [PATCH v2 1/3] powerpc: remove stale calc_vm_prot_bits comment Nicholas Piggin
2020-07-03 1:19 ` Nicholas Piggin
2020-07-03 1:19 ` [PATCH v2 2/3] powerpc/64s: remove PROT_SAO support Nicholas Piggin
2020-07-03 1:19 ` Nicholas Piggin
2020-07-03 1:19 ` Nicholas Piggin
2020-07-09 4:34 ` Paul Mackerras
2020-07-09 4:34 ` Paul Mackerras
2020-07-09 4:34 ` Paul Mackerras
2020-07-09 10:20 ` Nicholas Piggin
2020-07-09 10:20 ` Nicholas Piggin
2020-07-09 10:20 ` Nicholas Piggin
2020-07-09 15:16 ` Cameron Kaiser
2020-07-09 22:46 ` Paul Mackerras
2020-07-03 1:19 ` [PATCH v2 3/3] powerpc/64s/hash: disable subpage_prot syscall by default Nicholas Piggin
2020-07-03 1:19 ` Nicholas Piggin
2020-07-03 1:19 ` Nicholas Piggin
2020-07-24 13:25 ` [PATCH v2 0/3] remove PROT_SAO support and disable Michael Ellerman
2020-07-24 13:25 ` Michael Ellerman
2020-07-24 13:25 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200703011958.1166620-2-npiggin@gmail.com \
--to=npiggin@gmail.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.