From: Lee Jones <lee.jones@linaro.org> To: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lee Jones <lee.jones@linaro.org>, Peter Chen <Peter.Chen@nxp.com> Subject: [PATCH 17/30] usb: chipidea: udc: Fix a few kerneldoc issues Date: Fri, 3 Jul 2020 18:41:35 +0100 [thread overview] Message-ID: <20200703174148.2749969-18-lee.jones@linaro.org> (raw) In-Reply-To: <20200703174148.2749969-1-lee.jones@linaro.org> Descriptions were missing for 'ci' almost throughout. There was one instance of over-documenting. Finally one function argument was incorrectly documented (probably down to bitrot). Fixes the following W=1 kernel build warning(s): drivers/usb/chipidea/udc.c:245: warning: Function parameter or member 'ci' not described in 'hw_port_is_high_speed' drivers/usb/chipidea/udc.c:271: warning: Function parameter or member 'ci' not described in 'hw_test_and_clear_intr_active' drivers/usb/chipidea/udc.c:285: warning: Function parameter or member 'ci' not described in 'hw_test_and_clear_setup_guard' drivers/usb/chipidea/udc.c:296: warning: Function parameter or member 'ci' not described in 'hw_test_and_set_setup_guard' drivers/usb/chipidea/udc.c:321: warning: Function parameter or member 'ci' not described in 'hw_usb_reset' drivers/usb/chipidea/udc.c:628: warning: Excess function parameter 'ci' description in 'free_pending_td' drivers/usb/chipidea/udc.c:655: warning: Function parameter or member 'hwep' not described in '_hardware_dequeue' drivers/usb/chipidea/udc.c:655: warning: Excess function parameter 'gadget' description in '_hardware_dequeue' Cc: Peter Chen <Peter.Chen@nxp.com> Signed-off-by: Lee Jones <lee.jones@linaro.org> --- drivers/usb/chipidea/udc.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c index 0dfbc31843fc8..6a20ef396543b 100644 --- a/drivers/usb/chipidea/udc.c +++ b/drivers/usb/chipidea/udc.c @@ -238,6 +238,7 @@ static int hw_ep_set_halt(struct ci_hdrc *ci, int num, int dir, int value) /** * hw_is_port_high_speed: test if port is high speed + * @ci: the controller * * This function returns true if high speed port */ @@ -264,6 +265,7 @@ static int hw_test_and_clear_complete(struct ci_hdrc *ci, int n) /** * hw_test_and_clear_intr_active: test & clear active interrupts (execute * without interruption) + * @ci: the controller * * This function returns active interrutps */ @@ -278,6 +280,7 @@ static u32 hw_test_and_clear_intr_active(struct ci_hdrc *ci) /** * hw_test_and_clear_setup_guard: test & clear setup guard (execute without * interruption) + * @ci: the controller * * This function returns guard value */ @@ -289,6 +292,7 @@ static int hw_test_and_clear_setup_guard(struct ci_hdrc *ci) /** * hw_test_and_set_setup_guard: test & set setup guard (execute without * interruption) + * @ci: the controller * * This function returns guard value */ @@ -314,6 +318,7 @@ static void hw_usb_set_address(struct ci_hdrc *ci, u8 value) /** * hw_usb_reset: restart device after a bus reset (execute without * interruption) + * @ci: the controller * * This function returns an error code */ @@ -621,7 +626,6 @@ static int _hardware_enqueue(struct ci_hw_ep *hwep, struct ci_hw_req *hwreq) /** * free_pending_td: remove a pending request for the endpoint - * @ci: the controller * @hwep: endpoint */ static void free_pending_td(struct ci_hw_ep *hwep) @@ -646,7 +650,7 @@ static int reprime_dtd(struct ci_hdrc *ci, struct ci_hw_ep *hwep, /** * _hardware_dequeue: handles a request at hardware level - * @gadget: gadget + * @hwep: endpoint * @hwreq: request * * This function returns an error code -- 2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org> To: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org Cc: Peter Chen <Peter.Chen@nxp.com>, Lee Jones <lee.jones@linaro.org>, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 17/30] usb: chipidea: udc: Fix a few kerneldoc issues Date: Fri, 3 Jul 2020 18:41:35 +0100 [thread overview] Message-ID: <20200703174148.2749969-18-lee.jones@linaro.org> (raw) In-Reply-To: <20200703174148.2749969-1-lee.jones@linaro.org> Descriptions were missing for 'ci' almost throughout. There was one instance of over-documenting. Finally one function argument was incorrectly documented (probably down to bitrot). Fixes the following W=1 kernel build warning(s): drivers/usb/chipidea/udc.c:245: warning: Function parameter or member 'ci' not described in 'hw_port_is_high_speed' drivers/usb/chipidea/udc.c:271: warning: Function parameter or member 'ci' not described in 'hw_test_and_clear_intr_active' drivers/usb/chipidea/udc.c:285: warning: Function parameter or member 'ci' not described in 'hw_test_and_clear_setup_guard' drivers/usb/chipidea/udc.c:296: warning: Function parameter or member 'ci' not described in 'hw_test_and_set_setup_guard' drivers/usb/chipidea/udc.c:321: warning: Function parameter or member 'ci' not described in 'hw_usb_reset' drivers/usb/chipidea/udc.c:628: warning: Excess function parameter 'ci' description in 'free_pending_td' drivers/usb/chipidea/udc.c:655: warning: Function parameter or member 'hwep' not described in '_hardware_dequeue' drivers/usb/chipidea/udc.c:655: warning: Excess function parameter 'gadget' description in '_hardware_dequeue' Cc: Peter Chen <Peter.Chen@nxp.com> Signed-off-by: Lee Jones <lee.jones@linaro.org> --- drivers/usb/chipidea/udc.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c index 0dfbc31843fc8..6a20ef396543b 100644 --- a/drivers/usb/chipidea/udc.c +++ b/drivers/usb/chipidea/udc.c @@ -238,6 +238,7 @@ static int hw_ep_set_halt(struct ci_hdrc *ci, int num, int dir, int value) /** * hw_is_port_high_speed: test if port is high speed + * @ci: the controller * * This function returns true if high speed port */ @@ -264,6 +265,7 @@ static int hw_test_and_clear_complete(struct ci_hdrc *ci, int n) /** * hw_test_and_clear_intr_active: test & clear active interrupts (execute * without interruption) + * @ci: the controller * * This function returns active interrutps */ @@ -278,6 +280,7 @@ static u32 hw_test_and_clear_intr_active(struct ci_hdrc *ci) /** * hw_test_and_clear_setup_guard: test & clear setup guard (execute without * interruption) + * @ci: the controller * * This function returns guard value */ @@ -289,6 +292,7 @@ static int hw_test_and_clear_setup_guard(struct ci_hdrc *ci) /** * hw_test_and_set_setup_guard: test & set setup guard (execute without * interruption) + * @ci: the controller * * This function returns guard value */ @@ -314,6 +318,7 @@ static void hw_usb_set_address(struct ci_hdrc *ci, u8 value) /** * hw_usb_reset: restart device after a bus reset (execute without * interruption) + * @ci: the controller * * This function returns an error code */ @@ -621,7 +626,6 @@ static int _hardware_enqueue(struct ci_hw_ep *hwep, struct ci_hw_req *hwreq) /** * free_pending_td: remove a pending request for the endpoint - * @ci: the controller * @hwep: endpoint */ static void free_pending_td(struct ci_hw_ep *hwep) @@ -646,7 +650,7 @@ static int reprime_dtd(struct ci_hdrc *ci, struct ci_hw_ep *hwep, /** * _hardware_dequeue: handles a request at hardware level - * @gadget: gadget + * @hwep: endpoint * @hwreq: request * * This function returns an error code -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-07-03 17:42 UTC|newest] Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-03 17:41 [PATCH 00/30] Fix a bunch more W=1 issues in USB Lee Jones 2020-07-03 17:41 ` Lee Jones 2020-07-03 17:41 ` [PATCH 01/30] usb: mtu3: mtu3_debug: Add forward declaration of 'struct ssusb_mtk' Lee Jones 2020-07-03 17:41 ` Lee Jones 2020-07-03 17:41 ` Lee Jones 2020-07-03 17:41 ` [PATCH 02/30] usb: host: ohci-s3c2410: Demote obvious misuse of kerneldoc to standard comment block Lee Jones 2020-07-03 17:41 ` Lee Jones 2020-07-03 17:41 ` [PATCH 03/30] usb: core: ledtrig-usbport: Demote obvious misuse of kerneldoc to standard comment blocks Lee Jones 2020-07-03 17:41 ` Lee Jones 2020-07-03 17:41 ` [PATCH 04/30] usb: misc: sisusbvga: sisusb_init: Mark all 'static const' arrays as __maybe_unused Lee Jones 2020-07-03 17:41 ` Lee Jones 2020-07-03 18:29 ` Joe Perches 2020-07-03 18:29 ` Joe Perches 2020-07-03 19:44 ` Lee Jones 2020-07-03 19:44 ` Lee Jones 2020-07-07 8:03 ` Lee Jones 2020-07-07 8:03 ` Lee Jones 2020-07-07 20:50 ` Joe Perches 2020-07-07 20:50 ` Joe Perches 2020-07-08 6:34 ` Lee Jones 2020-07-08 6:34 ` Lee Jones 2020-07-07 7:49 ` Lee Jones 2020-07-07 7:49 ` Lee Jones 2020-07-03 17:41 ` [PATCH 05/30] usb: atm: ueagle-atm: Demote obvious misuse of kerneldoc to standard comment blocks Lee Jones 2020-07-03 17:41 ` Lee Jones 2020-07-03 17:41 ` [PATCH 06/30] usb: misc: adutux: " Lee Jones 2020-07-03 17:41 ` Lee Jones 2020-07-03 17:41 ` [PATCH 07/30] usb: chipidea: core: Document hw_port_test_set()'s missing 'ci' argument Lee Jones 2020-07-03 17:41 ` Lee Jones 2020-07-03 17:41 ` [PATCH 08/30] usb: gadget: udc: core: Fix a bunch of kerneldoc misdemeanours Lee Jones 2020-07-03 17:41 ` Lee Jones 2020-07-03 17:41 ` [PATCH 09/30] usb: chipidea: otg: Fix kerneldoc issues relating to description of 'ci' Lee Jones 2020-07-03 17:41 ` Lee Jones 2020-07-03 17:41 ` [PATCH 10/30] usb: chipidea: debug: Demote obvious misuse of kerneldoc to standard comment blocks Lee Jones 2020-07-03 17:41 ` Lee Jones 2020-07-03 17:41 ` [PATCH 11/30] usb: chipidea: udc: Add missing descriptions for function arg 'ci' Lee Jones 2020-07-03 17:41 ` Lee Jones 2020-07-03 17:41 ` [PATCH 12/30] usb: chipidea: udc: Help out kerneldoc headers that have tried, demote the others Lee Jones 2020-07-03 17:41 ` Lee Jones 2020-07-03 17:41 ` [PATCH 13/30] usb: host: xhci: Demote obvious misuse of kerneldoc to standard comment block Lee Jones 2020-07-03 17:41 ` Lee Jones 2020-07-03 17:41 ` [PATCH 14/30] usb: host: xhci-mem: " Lee Jones 2020-07-03 17:41 ` Lee Jones 2020-07-03 17:41 ` [PATCH 15/30] usb: host: xhci-dbgcap: File headers are not good candidates for kerneldoc Lee Jones 2020-07-03 17:41 ` Lee Jones 2020-07-03 17:41 ` [PATCH 16/30] usb: host: xhci-dbgtty: " Lee Jones 2020-07-03 17:41 ` Lee Jones 2020-07-03 17:41 ` Lee Jones [this message] 2020-07-03 17:41 ` [PATCH 17/30] usb: chipidea: udc: Fix a few kerneldoc issues Lee Jones 2020-07-03 17:41 ` [PATCH 18/30] usb: host: xhci-debugfs: Use 'gnu_printf' format notation Lee Jones 2020-07-03 17:41 ` Lee Jones 2020-07-03 17:41 ` [PATCH 19/30] usb: storage: alauda: Remove set but unchecked variable Lee Jones 2020-07-03 17:41 ` Lee Jones 2020-07-03 17:41 ` [PATCH 20/30] usb: typec: altmodes: displayport: File headers are not good candidates for kerneldoc Lee Jones 2020-07-03 17:41 ` Lee Jones 2020-07-03 17:41 ` [PATCH 21/30] usb: typec: altmodes: displayport: Supply missing displayport.h include file Lee Jones 2020-07-03 17:41 ` Lee Jones 2020-07-03 17:41 ` [PATCH 22/30] usb: typec: tcpm: fusb302: Use 'gnu_printf' format notation Lee Jones 2020-07-03 17:41 ` Lee Jones 2020-07-03 19:01 ` Guenter Roeck 2020-07-03 19:01 ` Guenter Roeck 2020-07-03 17:41 ` [PATCH 23/30] usb: chipidea: usbmisc_imx: Demote obvious misuse of kerneldoc to standard comment block Lee Jones 2020-07-03 17:41 ` Lee Jones 2020-07-03 17:41 ` [PATCH 24/30] usb: misc: iowarrior: Fix odd corruption issue in the file header Lee Jones 2020-07-03 17:41 ` Lee Jones 2020-07-03 17:41 ` [PATCH 25/30] usb: misc: iowarrior: Demote obvious misuse of kerneldoc to standard comment blocks Lee Jones 2020-07-03 17:41 ` Lee Jones 2020-07-03 17:41 ` [PATCH 26/30] usb: gadget: function: u_serial: Repair misdocumented function argument Lee Jones 2020-07-03 17:41 ` Lee Jones 2020-07-03 17:41 ` [PATCH 27/30] usb: misc: ldusb: Demote obvious misuse of kerneldoc to standard comment blocks Lee Jones 2020-07-03 17:41 ` Lee Jones 2020-07-03 17:41 ` [PATCH 28/30] usb: musb: musb_dsps: " Lee Jones 2020-07-03 17:41 ` Lee Jones 2020-07-03 17:41 ` [PATCH 29/30] usb: gadget: usbstring: Repair misspelled function argument 'langid' Lee Jones 2020-07-03 17:41 ` Lee Jones 2020-07-03 17:41 ` [PATCH 30/30] usb: gadget: udc: dummy_hcd: Repair misspelled function argument 'dummy_hcd' Lee Jones 2020-07-03 17:41 ` Lee Jones
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200703174148.2749969-18-lee.jones@linaro.org \ --to=lee.jones@linaro.org \ --cc=Peter.Chen@nxp.com \ --cc=gregkh@linuxfoundation.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-usb@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.