All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, "Lee Jones" <lee.jones@linaro.org>,
	"Rafał Miłecki" <rafal@milecki.pl>
Subject: [PATCH 03/30] usb: core: ledtrig-usbport: Demote obvious misuse of kerneldoc to standard comment blocks
Date: Fri,  3 Jul 2020 18:41:21 +0100	[thread overview]
Message-ID: <20200703174148.2749969-4-lee.jones@linaro.org> (raw)
In-Reply-To: <20200703174148.2749969-1-lee.jones@linaro.org>

No attempt has been made to document any of the functions here.

Fixes the following W=1 kernel build warning(s):

 drivers/usb/core/ledtrig-usbport.c:42: warning: Function parameter or member 'usbport_data' not described in 'usbport_trig_usb_dev_observed'
 drivers/usb/core/ledtrig-usbport.c:42: warning: Function parameter or member 'usb_dev' not described in 'usbport_trig_usb_dev_observed'
 drivers/usb/core/ledtrig-usbport.c:71: warning: Function parameter or member 'usbport_data' not described in 'usbport_trig_update_count'
 drivers/usb/core/ledtrig-usbport.c:131: warning: Function parameter or member 'usbport_data' not described in 'usbport_trig_port_observed'
 drivers/usb/core/ledtrig-usbport.c:131: warning: Function parameter or member 'usb_dev' not described in 'usbport_trig_port_observed'
 drivers/usb/core/ledtrig-usbport.c:131: warning: Function parameter or member 'port1' not described in 'usbport_trig_port_observed'

Cc: Rafał Miłecki <rafal@milecki.pl>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/usb/core/ledtrig-usbport.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/usb/core/ledtrig-usbport.c b/drivers/usb/core/ledtrig-usbport.c
index c12ac56606c3f..ba371a24ff781 100644
--- a/drivers/usb/core/ledtrig-usbport.c
+++ b/drivers/usb/core/ledtrig-usbport.c
@@ -34,7 +34,7 @@ struct usbport_trig_port {
  * Helpers
  ***************************************/
 
-/**
+/*
  * usbport_trig_usb_dev_observed - Check if dev is connected to observed port
  */
 static bool usbport_trig_usb_dev_observed(struct usbport_trig_data *usbport_data,
@@ -64,7 +64,7 @@ static int usbport_trig_usb_dev_check(struct usb_device *usb_dev, void *data)
 	return 0;
 }
 
-/**
+/*
  * usbport_trig_update_count - Recalculate amount of connected matching devices
  */
 static void usbport_trig_update_count(struct usbport_trig_data *usbport_data)
@@ -123,7 +123,7 @@ static const struct attribute_group ports_group = {
  * Adding & removing ports
  ***************************************/
 
-/**
+/*
  * usbport_trig_port_observed - Check if port should be observed
  */
 static bool usbport_trig_port_observed(struct usbport_trig_data *usbport_data,
-- 
2.25.1


WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org
Cc: "Rafał Miłecki" <rafal@milecki.pl>,
	"Lee Jones" <lee.jones@linaro.org>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: [PATCH 03/30] usb: core: ledtrig-usbport: Demote obvious misuse of kerneldoc to standard comment blocks
Date: Fri,  3 Jul 2020 18:41:21 +0100	[thread overview]
Message-ID: <20200703174148.2749969-4-lee.jones@linaro.org> (raw)
In-Reply-To: <20200703174148.2749969-1-lee.jones@linaro.org>

No attempt has been made to document any of the functions here.

Fixes the following W=1 kernel build warning(s):

 drivers/usb/core/ledtrig-usbport.c:42: warning: Function parameter or member 'usbport_data' not described in 'usbport_trig_usb_dev_observed'
 drivers/usb/core/ledtrig-usbport.c:42: warning: Function parameter or member 'usb_dev' not described in 'usbport_trig_usb_dev_observed'
 drivers/usb/core/ledtrig-usbport.c:71: warning: Function parameter or member 'usbport_data' not described in 'usbport_trig_update_count'
 drivers/usb/core/ledtrig-usbport.c:131: warning: Function parameter or member 'usbport_data' not described in 'usbport_trig_port_observed'
 drivers/usb/core/ledtrig-usbport.c:131: warning: Function parameter or member 'usb_dev' not described in 'usbport_trig_port_observed'
 drivers/usb/core/ledtrig-usbport.c:131: warning: Function parameter or member 'port1' not described in 'usbport_trig_port_observed'

Cc: Rafał Miłecki <rafal@milecki.pl>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/usb/core/ledtrig-usbport.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/usb/core/ledtrig-usbport.c b/drivers/usb/core/ledtrig-usbport.c
index c12ac56606c3f..ba371a24ff781 100644
--- a/drivers/usb/core/ledtrig-usbport.c
+++ b/drivers/usb/core/ledtrig-usbport.c
@@ -34,7 +34,7 @@ struct usbport_trig_port {
  * Helpers
  ***************************************/
 
-/**
+/*
  * usbport_trig_usb_dev_observed - Check if dev is connected to observed port
  */
 static bool usbport_trig_usb_dev_observed(struct usbport_trig_data *usbport_data,
@@ -64,7 +64,7 @@ static int usbport_trig_usb_dev_check(struct usb_device *usb_dev, void *data)
 	return 0;
 }
 
-/**
+/*
  * usbport_trig_update_count - Recalculate amount of connected matching devices
  */
 static void usbport_trig_update_count(struct usbport_trig_data *usbport_data)
@@ -123,7 +123,7 @@ static const struct attribute_group ports_group = {
  * Adding & removing ports
  ***************************************/
 
-/**
+/*
  * usbport_trig_port_observed - Check if port should be observed
  */
 static bool usbport_trig_port_observed(struct usbport_trig_data *usbport_data,
-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2020-07-03 17:44 UTC|newest]

Thread overview: 77+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-03 17:41 [PATCH 00/30] Fix a bunch more W=1 issues in USB Lee Jones
2020-07-03 17:41 ` Lee Jones
2020-07-03 17:41 ` [PATCH 01/30] usb: mtu3: mtu3_debug: Add forward declaration of 'struct ssusb_mtk' Lee Jones
2020-07-03 17:41   ` Lee Jones
2020-07-03 17:41   ` Lee Jones
2020-07-03 17:41 ` [PATCH 02/30] usb: host: ohci-s3c2410: Demote obvious misuse of kerneldoc to standard comment block Lee Jones
2020-07-03 17:41   ` Lee Jones
2020-07-03 17:41 ` Lee Jones [this message]
2020-07-03 17:41   ` [PATCH 03/30] usb: core: ledtrig-usbport: Demote obvious misuse of kerneldoc to standard comment blocks Lee Jones
2020-07-03 17:41 ` [PATCH 04/30] usb: misc: sisusbvga: sisusb_init: Mark all 'static const' arrays as __maybe_unused Lee Jones
2020-07-03 17:41   ` Lee Jones
2020-07-03 18:29   ` Joe Perches
2020-07-03 18:29     ` Joe Perches
2020-07-03 19:44     ` Lee Jones
2020-07-03 19:44       ` Lee Jones
2020-07-07  8:03     ` Lee Jones
2020-07-07  8:03       ` Lee Jones
2020-07-07 20:50       ` Joe Perches
2020-07-07 20:50         ` Joe Perches
2020-07-08  6:34         ` Lee Jones
2020-07-08  6:34           ` Lee Jones
2020-07-07  7:49   ` Lee Jones
2020-07-07  7:49     ` Lee Jones
2020-07-03 17:41 ` [PATCH 05/30] usb: atm: ueagle-atm: Demote obvious misuse of kerneldoc to standard comment blocks Lee Jones
2020-07-03 17:41   ` Lee Jones
2020-07-03 17:41 ` [PATCH 06/30] usb: misc: adutux: " Lee Jones
2020-07-03 17:41   ` Lee Jones
2020-07-03 17:41 ` [PATCH 07/30] usb: chipidea: core: Document hw_port_test_set()'s missing 'ci' argument Lee Jones
2020-07-03 17:41   ` Lee Jones
2020-07-03 17:41 ` [PATCH 08/30] usb: gadget: udc: core: Fix a bunch of kerneldoc misdemeanours Lee Jones
2020-07-03 17:41   ` Lee Jones
2020-07-03 17:41 ` [PATCH 09/30] usb: chipidea: otg: Fix kerneldoc issues relating to description of 'ci' Lee Jones
2020-07-03 17:41   ` Lee Jones
2020-07-03 17:41 ` [PATCH 10/30] usb: chipidea: debug: Demote obvious misuse of kerneldoc to standard comment blocks Lee Jones
2020-07-03 17:41   ` Lee Jones
2020-07-03 17:41 ` [PATCH 11/30] usb: chipidea: udc: Add missing descriptions for function arg 'ci' Lee Jones
2020-07-03 17:41   ` Lee Jones
2020-07-03 17:41 ` [PATCH 12/30] usb: chipidea: udc: Help out kerneldoc headers that have tried, demote the others Lee Jones
2020-07-03 17:41   ` Lee Jones
2020-07-03 17:41 ` [PATCH 13/30] usb: host: xhci: Demote obvious misuse of kerneldoc to standard comment block Lee Jones
2020-07-03 17:41   ` Lee Jones
2020-07-03 17:41 ` [PATCH 14/30] usb: host: xhci-mem: " Lee Jones
2020-07-03 17:41   ` Lee Jones
2020-07-03 17:41 ` [PATCH 15/30] usb: host: xhci-dbgcap: File headers are not good candidates for kerneldoc Lee Jones
2020-07-03 17:41   ` Lee Jones
2020-07-03 17:41 ` [PATCH 16/30] usb: host: xhci-dbgtty: " Lee Jones
2020-07-03 17:41   ` Lee Jones
2020-07-03 17:41 ` [PATCH 17/30] usb: chipidea: udc: Fix a few kerneldoc issues Lee Jones
2020-07-03 17:41   ` Lee Jones
2020-07-03 17:41 ` [PATCH 18/30] usb: host: xhci-debugfs: Use 'gnu_printf' format notation Lee Jones
2020-07-03 17:41   ` Lee Jones
2020-07-03 17:41 ` [PATCH 19/30] usb: storage: alauda: Remove set but unchecked variable Lee Jones
2020-07-03 17:41   ` Lee Jones
2020-07-03 17:41 ` [PATCH 20/30] usb: typec: altmodes: displayport: File headers are not good candidates for kerneldoc Lee Jones
2020-07-03 17:41   ` Lee Jones
2020-07-03 17:41 ` [PATCH 21/30] usb: typec: altmodes: displayport: Supply missing displayport.h include file Lee Jones
2020-07-03 17:41   ` Lee Jones
2020-07-03 17:41 ` [PATCH 22/30] usb: typec: tcpm: fusb302: Use 'gnu_printf' format notation Lee Jones
2020-07-03 17:41   ` Lee Jones
2020-07-03 19:01   ` Guenter Roeck
2020-07-03 19:01     ` Guenter Roeck
2020-07-03 17:41 ` [PATCH 23/30] usb: chipidea: usbmisc_imx: Demote obvious misuse of kerneldoc to standard comment block Lee Jones
2020-07-03 17:41   ` Lee Jones
2020-07-03 17:41 ` [PATCH 24/30] usb: misc: iowarrior: Fix odd corruption issue in the file header Lee Jones
2020-07-03 17:41   ` Lee Jones
2020-07-03 17:41 ` [PATCH 25/30] usb: misc: iowarrior: Demote obvious misuse of kerneldoc to standard comment blocks Lee Jones
2020-07-03 17:41   ` Lee Jones
2020-07-03 17:41 ` [PATCH 26/30] usb: gadget: function: u_serial: Repair misdocumented function argument Lee Jones
2020-07-03 17:41   ` Lee Jones
2020-07-03 17:41 ` [PATCH 27/30] usb: misc: ldusb: Demote obvious misuse of kerneldoc to standard comment blocks Lee Jones
2020-07-03 17:41   ` Lee Jones
2020-07-03 17:41 ` [PATCH 28/30] usb: musb: musb_dsps: " Lee Jones
2020-07-03 17:41   ` Lee Jones
2020-07-03 17:41 ` [PATCH 29/30] usb: gadget: usbstring: Repair misspelled function argument 'langid' Lee Jones
2020-07-03 17:41   ` Lee Jones
2020-07-03 17:41 ` [PATCH 30/30] usb: gadget: udc: dummy_hcd: Repair misspelled function argument 'dummy_hcd' Lee Jones
2020-07-03 17:41   ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200703174148.2749969-4-lee.jones@linaro.org \
    --to=lee.jones@linaro.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=rafal@milecki.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.