All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
	"Sagar Karandikar" <sagark@eecs.berkeley.edu>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"Max Filippov" <jcmvbkbc@gmail.com>,
	"Alistair Francis" <Alistair.Francis@wdc.com>,
	"Gerd Hoffmann" <kraxel@redhat.com>,
	"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
	"Yoshinori Sato" <ysato@users.sourceforge.jp>,
	"Magnus Damm" <magnus.damm@gmail.com>,
	"Palmer Dabbelt" <palmer@dabbelt.com>,
	"Eduardo Habkost" <ehabkost@redhat.com>,
	"Alistair Francis" <alistair@alistair23.me>,
	qemu-arm@nongnu.org,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Daniel P. Berrangé" <berrange@redhat.com>,
	"Stafford Horne" <shorne@gmail.com>,
	"David Gibson" <david@gibson.dropbear.id.au>,
	qemu-riscv@nongnu.org, "Thomas Huth" <huth@tuxfamily.org>,
	"Bastian Koppelmann" <kbastian@mail.uni-paderborn.de>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	qemu-ppc@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>
Subject: [RFC PATCH v2 22/23] hw/usb/hcd-musb: Emit warning when old code is used
Date: Sat,  4 Jul 2020 17:39:07 +0200	[thread overview]
Message-ID: <20200704153908.12118-23-philmd@redhat.com> (raw)
In-Reply-To: <20200704153908.12118-1-philmd@redhat.com>

This code hasn't been QOM'ified yet. Warn the user.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 hw/usb/hcd-musb.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/hw/usb/hcd-musb.c b/hw/usb/hcd-musb.c
index 85f5ff5bd4..f09464ed5e 100644
--- a/hw/usb/hcd-musb.c
+++ b/hw/usb/hcd-musb.c
@@ -26,6 +26,7 @@
 #include "hw/usb/hcd-musb.h"
 #include "hw/irq.h"
 #include "hw/hw.h"
+#include "hw/qdev-deprecated.h"
 
 /* Common USB registers */
 #define MUSB_HDRC_FADDR		0x00	/* 8-bit */
@@ -378,6 +379,8 @@ struct MUSBState *musb_init(DeviceState *parent_device, int gpio_base)
     MUSBState *s = g_malloc0(sizeof(*s));
     int i;
 
+    qdev_warn_deprecated_function_used();
+
     for (i = 0; i < musb_irq_max; i++) {
         s->irqs[i] = qdev_get_gpio_in(parent_device, gpio_base + i);
     }
-- 
2.21.3



WARNING: multiple messages have this Message-ID (diff)
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Palmer Dabbelt" <palmer@dabbelt.com>,
	"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
	qemu-riscv@nongnu.org, "Peter Maydell" <peter.maydell@linaro.org>,
	"Alistair Francis" <alistair@alistair23.me>,
	"Stafford Horne" <shorne@gmail.com>,
	"Max Filippov" <jcmvbkbc@gmail.com>,
	"Eduardo Habkost" <ehabkost@redhat.com>,
	"Yoshinori Sato" <ysato@users.sourceforge.jp>,
	"David Gibson" <david@gibson.dropbear.id.au>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	qemu-ppc@nongnu.org, "Andrzej Zaborowski" <balrogg@gmail.com>,
	"Gerd Hoffmann" <kraxel@redhat.com>,
	"Daniel P. Berrangé" <berrange@redhat.com>,
	"Alistair Francis" <Alistair.Francis@wdc.com>,
	"Bastian Koppelmann" <kbastian@mail.uni-paderborn.de>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Magnus Damm" <magnus.damm@gmail.com>,
	"Sagar Karandikar" <sagark@eecs.berkeley.edu>,
	"Thomas Huth" <huth@tuxfamily.org>,
	qemu-arm@nongnu.org,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: [RFC PATCH v2 22/23] hw/usb/hcd-musb: Emit warning when old code is used
Date: Sat,  4 Jul 2020 17:39:07 +0200	[thread overview]
Message-ID: <20200704153908.12118-23-philmd@redhat.com> (raw)
In-Reply-To: <20200704153908.12118-1-philmd@redhat.com>

This code hasn't been QOM'ified yet. Warn the user.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 hw/usb/hcd-musb.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/hw/usb/hcd-musb.c b/hw/usb/hcd-musb.c
index 85f5ff5bd4..f09464ed5e 100644
--- a/hw/usb/hcd-musb.c
+++ b/hw/usb/hcd-musb.c
@@ -26,6 +26,7 @@
 #include "hw/usb/hcd-musb.h"
 #include "hw/irq.h"
 #include "hw/hw.h"
+#include "hw/qdev-deprecated.h"
 
 /* Common USB registers */
 #define MUSB_HDRC_FADDR		0x00	/* 8-bit */
@@ -378,6 +379,8 @@ struct MUSBState *musb_init(DeviceState *parent_device, int gpio_base)
     MUSBState *s = g_malloc0(sizeof(*s));
     int i;
 
+    qdev_warn_deprecated_function_used();
+
     for (i = 0; i < musb_irq_max; i++) {
         s->irqs[i] = qdev_get_gpio_in(parent_device, gpio_base + i);
     }
-- 
2.21.3



  parent reply	other threads:[~2020-07-04 15:50 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-04 15:38 [RFC PATCH v2 00/23] hw/qdev: Warn when using pre-qdev/QOM devices Philippe Mathieu-Daudé
2020-07-04 15:38 ` Philippe Mathieu-Daudé
2020-07-04 15:38 ` [PATCH v2 01/23] qom/object: Update documentation Philippe Mathieu-Daudé
2020-07-04 15:38   ` Philippe Mathieu-Daudé
2020-07-04 15:38 ` [RFC PATCH v2 02/23] hw/core/qdev: Add qdev_warn_deprecated_function_used() helper Philippe Mathieu-Daudé
2020-07-04 15:38   ` Philippe Mathieu-Daudé
2020-07-04 16:22   ` BALATON Zoltan
2020-07-04 16:22     ` BALATON Zoltan
2020-07-04 15:38 ` [RFC PATCH v2 03/23] hw/arm/omap: Emit warning when old code is used Philippe Mathieu-Daudé
2020-07-04 15:38   ` Philippe Mathieu-Daudé
2020-07-04 15:38 ` [RFC PATCH v2 04/23] hw/arm/pxa2xx: " Philippe Mathieu-Daudé
2020-07-04 15:38   ` Philippe Mathieu-Daudé
2020-07-04 15:38 ` [RFC PATCH v2 05/23] hw/arm/nseries: " Philippe Mathieu-Daudé
2020-07-04 15:38   ` Philippe Mathieu-Daudé
2020-07-04 15:38 ` [RFC PATCH v2 06/23] hw/char/parallel: " Philippe Mathieu-Daudé
2020-07-04 15:38   ` Philippe Mathieu-Daudé
2020-07-04 15:38 ` [RFC PATCH v2 07/23] hw/display/blizzard: " Philippe Mathieu-Daudé
2020-07-04 15:38   ` Philippe Mathieu-Daudé
2020-07-04 15:38 ` [RFC PATCH v2 08/23] hw/display/ramfb: " Philippe Mathieu-Daudé
2020-07-04 15:38   ` Philippe Mathieu-Daudé
2020-07-06 14:15   ` Gerd Hoffmann
2020-07-06 14:15     ` Gerd Hoffmann
2020-07-06 14:18     ` Philippe Mathieu-Daudé
2020-07-06 14:18       ` Philippe Mathieu-Daudé
2020-07-04 15:38 ` [RFC PATCH v2 09/23] hw/display/tc6393xb: " Philippe Mathieu-Daudé
2020-07-04 15:38   ` Philippe Mathieu-Daudé
2020-07-04 15:38 ` [RFC PATCH v2 10/23] hw/display/vga-isa-mm: " Philippe Mathieu-Daudé
2020-07-04 15:38   ` Philippe Mathieu-Daudé
2020-07-04 15:38 ` [RFC PATCH v2 11/23] hw/dma/etraxfs_dma: " Philippe Mathieu-Daudé
2020-07-04 15:38   ` Philippe Mathieu-Daudé
2020-07-04 15:38 ` [RFC PATCH v2 12/23] hw/dma/soc_dma: " Philippe Mathieu-Daudé
2020-07-04 15:38   ` Philippe Mathieu-Daudé
2020-07-04 15:38 ` [RFC PATCH v2 13/23] hw/input/lasips2: " Philippe Mathieu-Daudé
2020-07-04 15:38   ` Philippe Mathieu-Daudé
2020-07-04 15:38 ` [RFC PATCH v2 14/23] hw/input/tsc2005: " Philippe Mathieu-Daudé
2020-07-04 15:38   ` Philippe Mathieu-Daudé
2020-07-04 15:39 ` [RFC PATCH v2 15/23] hw/m68k/mcf520x: " Philippe Mathieu-Daudé
2020-07-04 15:39   ` Philippe Mathieu-Daudé
2020-07-05  6:31   ` Thomas Huth
2020-07-05  6:31     ` Thomas Huth
2020-07-04 15:39 ` [RFC PATCH v2 16/23] hw/misc/cbus: " Philippe Mathieu-Daudé
2020-07-04 15:39   ` Philippe Mathieu-Daudé
2020-07-04 15:39 ` [RFC PATCH v2 17/23] hw/nvram/eeprom93xx: " Philippe Mathieu-Daudé
2020-07-04 15:39   ` Philippe Mathieu-Daudé
2020-07-04 15:39 ` [RFC PATCH v2 18/23] hw/openrisc/cputimer: " Philippe Mathieu-Daudé
2020-07-04 15:39   ` Philippe Mathieu-Daudé
2020-07-04 15:47   ` Philippe Mathieu-Daudé
2020-07-04 15:47     ` Philippe Mathieu-Daudé
2020-07-04 15:39 ` [RFC PATCH v2 19/23] hw/ppc/ppc4xx: " Philippe Mathieu-Daudé
2020-07-04 15:39   ` Philippe Mathieu-Daudé
2020-07-04 15:39 ` [RFC PATCH v2 20/23] hw/sh4: " Philippe Mathieu-Daudé
2020-07-04 15:39   ` Philippe Mathieu-Daudé
2020-07-04 15:39 ` [RFC PATCH v2 21/23] hw/riscv: " Philippe Mathieu-Daudé
2020-07-04 15:39   ` Philippe Mathieu-Daudé
2020-07-06 16:46   ` Alistair Francis
2020-07-06 16:46     ` Alistair Francis
2020-07-04 15:39 ` Philippe Mathieu-Daudé [this message]
2020-07-04 15:39   ` [RFC PATCH v2 22/23] hw/usb/hcd-musb: " Philippe Mathieu-Daudé
2020-07-04 15:39 ` [RFC PATCH v2 23/23] hw/xtensa/xtfpga: " Philippe Mathieu-Daudé
2020-07-04 15:39   ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200704153908.12118-23-philmd@redhat.com \
    --to=philmd@redhat.com \
    --cc=Alistair.Francis@wdc.com \
    --cc=alistair@alistair23.me \
    --cc=berrange@redhat.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=edgar.iglesias@gmail.com \
    --cc=ehabkost@redhat.com \
    --cc=huth@tuxfamily.org \
    --cc=jcmvbkbc@gmail.com \
    --cc=kbastian@mail.uni-paderborn.de \
    --cc=kraxel@redhat.com \
    --cc=magnus.damm@gmail.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=mst@redhat.com \
    --cc=palmer@dabbelt.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=qemu-riscv@nongnu.org \
    --cc=sagark@eecs.berkeley.edu \
    --cc=shorne@gmail.com \
    --cc=ysato@users.sourceforge.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.