All of lore.kernel.org
 help / color / mirror / Atom feed
From: trix@redhat.com
To: agross@kernel.org, bjorn.andersson@linaro.org
Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
	Tom Rix <trix@redhat.com>
Subject: [PATCH] soc: qcom-geni-se: fix configury of qcom-geni-se.c
Date: Sun,  5 Jul 2020 07:50:55 -0700	[thread overview]
Message-ID: <20200705145055.14629-1-trix@redhat.com> (raw)

From: Tom Rix <trix@redhat.com>

In a randconfig, qcom-geni-se.c breaks with

drivers/soc/qcom/qcom-geni-se.c: In function ‘geni_remove_earlycon_icc_vote’:
drivers/soc/qcom/qcom-geni-se.c:819:11: error: implicit declaration of function ‘of_get_next_parent’; did you mean ‘of_get_parent’? [-Werror=implicit-function-declaration]
  parent = of_get_next_parent(wrapper->dev->of_node);
           ^~~~~~~~~~~~~~~~~~
           of_get_parent

qcom-geni-sec.c correctly includes the linux/of.h header.
But the header depends on CONFIG_OF being set.

So add depends to QCOM_GENI_SE

Signed-off-by: Tom Rix <trix@redhat.com>
---
 drivers/soc/qcom/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig
index 899f8c066797..f699cfa33d7d 100644
--- a/drivers/soc/qcom/Kconfig
+++ b/drivers/soc/qcom/Kconfig
@@ -29,6 +29,7 @@ config QCOM_COMMAND_DB
 config QCOM_GENI_SE
 	tristate "QCOM GENI Serial Engine Driver"
 	depends on ARCH_QCOM || COMPILE_TEST
+	depends on OF
 	help
 	  This driver is used to manage Generic Interface (GENI) firmware based
 	  Qualcomm Technologies, Inc. Universal Peripheral (QUP) Wrapper. This
-- 
2.18.1


                 reply	other threads:[~2020-07-05 14:51 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200705145055.14629-1-trix@redhat.com \
    --to=trix@redhat.com \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.