All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Aleksandar Rikalo" <aleksandar.rikalo@syrmia.com>,
	"Daniel P. Berrangé" <berrange@redhat.com>,
	"Eduardo Habkost" <ehabkost@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	libvir-list@redhat.com,
	"Aleksandar Markovic" <aleksandar.qemu.devel@gmail.com>,
	"Hervé Poussineau" <hpoussin@reactos.org>,
	qemu-ppc@nongnu.org, "Gerd Hoffmann" <kraxel@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Aurelien Jarno" <aurelien@aurel32.net>,
	"Richard Henderson" <rth@twiddle.net>
Subject: [PULL 11/20] pc_basic_device_init: pass PCMachineState
Date: Mon,  6 Jul 2020 21:29:12 +0200	[thread overview]
Message-ID: <20200706192921.1154-12-kraxel@redhat.com> (raw)
In-Reply-To: <20200706192921.1154-1-kraxel@redhat.com>

Need access to pcms for pcspk initialization.
Just preparation, no functional change.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Message-id: 20200702132525.6849-12-kraxel@redhat.com
---
 include/hw/i386/pc.h | 3 ++-
 hw/i386/pc.c         | 3 ++-
 hw/i386/pc_piix.c    | 2 +-
 hw/i386/pc_q35.c     | 2 +-
 4 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h
index dce1273c7dad..3a601dbe71da 100644
--- a/include/hw/i386/pc.h
+++ b/include/hw/i386/pc.h
@@ -160,7 +160,8 @@ void pc_memory_init(PCMachineState *pcms,
                     MemoryRegion **ram_memory);
 uint64_t pc_pci_hole64_start(void);
 DeviceState *pc_vga_init(ISABus *isa_bus, PCIBus *pci_bus);
-void pc_basic_device_init(ISABus *isa_bus, qemu_irq *gsi,
+void pc_basic_device_init(struct PCMachineState *pcms,
+                          ISABus *isa_bus, qemu_irq *gsi,
                           ISADevice **rtc_state,
                           bool create_fdctrl,
                           bool no_vmport,
diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index 4af9679d039b..d89e577f6fa1 100644
--- a/hw/i386/pc.c
+++ b/hw/i386/pc.c
@@ -1155,7 +1155,8 @@ static void pc_superio_init(ISABus *isa_bus, bool create_fdctrl, bool no_vmport)
     g_free(a20_line);
 }
 
-void pc_basic_device_init(ISABus *isa_bus, qemu_irq *gsi,
+void pc_basic_device_init(struct PCMachineState *pcms,
+                          ISABus *isa_bus, qemu_irq *gsi,
                           ISADevice **rtc_state,
                           bool create_fdctrl,
                           bool no_vmport,
diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
index 1d832b2878b1..a3b416507286 100644
--- a/hw/i386/pc_piix.c
+++ b/hw/i386/pc_piix.c
@@ -235,7 +235,7 @@ static void pc_init1(MachineState *machine,
     }
 
     /* init basic PC hardware */
-    pc_basic_device_init(isa_bus, x86ms->gsi, &rtc_state, true,
+    pc_basic_device_init(pcms, isa_bus, x86ms->gsi, &rtc_state, true,
                          (pcms->vmport != ON_OFF_AUTO_ON), pcms->pit_enabled,
                          0x4);
 
diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c
index 047ea8db28ea..b16e22c6cccd 100644
--- a/hw/i386/pc_q35.c
+++ b/hw/i386/pc_q35.c
@@ -275,7 +275,7 @@ static void pc_q35_init(MachineState *machine)
     }
 
     /* init basic PC hardware */
-    pc_basic_device_init(isa_bus, x86ms->gsi, &rtc_state, !mc->no_floppy,
+    pc_basic_device_init(pcms, isa_bus, x86ms->gsi, &rtc_state, !mc->no_floppy,
                          (pcms->vmport != ON_OFF_AUTO_ON), pcms->pit_enabled,
                          0xff0104);
 
-- 
2.18.4



  parent reply	other threads:[~2020-07-06 19:41 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-06 19:29 [PULL 00/20] Audio 20200706 patches Gerd Hoffmann
2020-07-06 19:29 ` [PULL 01/20] stubs: add isa_create_simple Gerd Hoffmann
2020-07-06 19:29 ` [PULL 02/20] stubs: add pci_create_simple Gerd Hoffmann
2020-07-06 19:29 ` [PULL 03/20] audio: add deprecated_register_soundhw Gerd Hoffmann
2020-07-06 19:29 ` [PULL 04/20] audio: deprecate -soundhw ac97 Gerd Hoffmann
2020-07-06 19:29 ` [PULL 05/20] audio: deprecate -soundhw es1370 Gerd Hoffmann
2020-07-06 19:29 ` [PULL 06/20] audio: deprecate -soundhw adlib Gerd Hoffmann
2020-07-06 19:29 ` [PULL 07/20] audio: deprecate -soundhw cs4231a Gerd Hoffmann
2020-07-06 19:29 ` [PULL 08/20] audio: deprecate -soundhw gus Gerd Hoffmann
2020-07-06 19:29 ` [PULL 09/20] audio: deprecate -soundhw sb16 Gerd Hoffmann
2020-07-06 19:29 ` [PULL 10/20] audio: deprecate -soundhw hda Gerd Hoffmann
2020-07-06 19:29 ` Gerd Hoffmann [this message]
2020-07-06 19:29 ` [PULL 12/20] pc_basic_device_init: drop has_pit arg Gerd Hoffmann
2020-07-06 19:29 ` [PULL 13/20] pc_basic_device_init: drop no_vmport arg Gerd Hoffmann
2020-07-06 19:29 ` [PULL 14/20] softmmu: initialize spice and audio earlier Gerd Hoffmann
2020-07-06 19:29 ` [PULL 15/20] audio: rework pcspk_init() Gerd Hoffmann
2020-07-06 19:29 ` [PULL 16/20] audio: create pcspk device early Gerd Hoffmann
2020-07-06 19:29 ` [PULL 17/20] audio: deprecate -soundhw pcspk Gerd Hoffmann
2020-07-06 19:29 ` [PULL 18/20] audio: add soundhw deprecation notice Gerd Hoffmann
2020-07-06 19:29 ` [PULL 19/20] pcspk: update docs/system/target-i386-desc.rst.inc Gerd Hoffmann
2020-07-06 19:29 ` [PULL 20/20] audio: set default value for pcspk.iobase property Gerd Hoffmann
2020-07-08 20:38 ` [PULL 00/20] Audio 20200706 patches Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200706192921.1154-12-kraxel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=aleksandar.qemu.devel@gmail.com \
    --cc=aleksandar.rikalo@syrmia.com \
    --cc=aurelien@aurel32.net \
    --cc=berrange@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=hpoussin@reactos.org \
    --cc=libvir-list@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.