All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Bulekov <alxndr@bu.edu>
To: qemu-devel@nongnu.org
Cc: Alexander Bulekov <alxndr@bu.edu>,
	bsd@redhat.com, philmd@redhat.com, stefanha@redhat.com
Subject: [PATCH 1/4] fuzz: build without AddressSanitizer, by default
Date: Mon,  6 Jul 2020 15:55:31 -0400	[thread overview]
Message-ID: <20200706195534.14962-2-alxndr@bu.edu> (raw)
In-Reply-To: <20200706195534.14962-1-alxndr@bu.edu>

We already have a nice --enable-sanitizers option to enable
AddressSanitizer. There is no reason to duplicate and force this
functionality in --enable-fuzzing. In the future, if more sanitizers are
added to --enable-sanitizers, it might be impossible to build with both
--enable-sanitizers and --enable-fuzzing, since not all sanitizers are
compatible with libFuzzer. In that case, we could enable ASAN with
--extra-cflags="-fsanitize=address"

Signed-off-by: Alexander Bulekov <alxndr@bu.edu>
---
 configure | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/configure b/configure
index 8a65240d4a..010c0ca479 100755
--- a/configure
+++ b/configure
@@ -6319,7 +6319,7 @@ fi
 # checks for fuzzer
 if test "$fuzzing" = "yes" ; then
   write_c_fuzzer_skeleton
-  if compile_prog "$CPU_CFLAGS -Werror -fsanitize=address,fuzzer" ""; then
+  if compile_prog "$CPU_CFLAGS -Werror -fsanitize=fuzzer" ""; then
       have_fuzzer=yes
   fi
 fi
@@ -7858,11 +7858,11 @@ if test "$sheepdog" = "yes" ; then
 fi
 if test "$fuzzing" = "yes" ; then
   if test "$have_fuzzer" = "yes"; then
-    FUZZ_LDFLAGS=" -fsanitize=address,fuzzer"
-    FUZZ_CFLAGS=" -fsanitize=address,fuzzer"
-    CFLAGS=" -fsanitize=address,fuzzer-no-link"
+    FUZZ_LDFLAGS=" -fsanitize=fuzzer"
+    FUZZ_CFLAGS=" -fsanitize=fuzzer"
+    CFLAGS=" -fsanitize=fuzzer-no-link"
   else
-    error_exit "Your compiler doesn't support -fsanitize=address,fuzzer"
+    error_exit "Your compiler doesn't support -fsanitize=fuzzer"
     exit 1
   fi
 fi
-- 
2.26.2



  reply	other threads:[~2020-07-06 19:57 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-06 19:55 [PATCH 0/4] fuzz: misc patches Alexander Bulekov
2020-07-06 19:55 ` Alexander Bulekov [this message]
2020-07-07  4:30   ` [PATCH 1/4] fuzz: build without AddressSanitizer, by default Philippe Mathieu-Daudé
2020-07-20 16:49   ` Thomas Huth
2020-07-06 19:55 ` [PATCH 2/4] docs/fuzz: describe building fuzzers with enable-sanitizers Alexander Bulekov
2020-07-07  4:31   ` Philippe Mathieu-Daudé
2020-07-21  5:26   ` Thomas Huth
2020-07-06 19:55 ` [PATCH 3/4] docs/fuzz: add information about useful libFuzzer flags Alexander Bulekov
2020-07-06 19:55 ` [PATCH 4/4] docs/fuzz: add instructions for generating a coverage report Alexander Bulekov
2020-07-07  4:41   ` Alexander Bulekov
2020-07-21  5:31     ` Thomas Huth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200706195534.14962-2-alxndr@bu.edu \
    --to=alxndr@bu.edu \
    --cc=bsd@redhat.com \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.