From: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
To: linux-media@vger.kernel.org, laurent.pinchart@ideasonboard.com
Cc: dafna.hirschfeld@collabora.com, helen.koike@collabora.com,
ezequiel@collabora.com, hverkuil@xs4all.nl, kernel@collabora.com,
dafna3@gmail.com, sakari.ailus@linux.intel.com,
linux-rockchip@lists.infradead.org, mchehab@kernel.org,
tfiga@chromium.org
Subject: [PATCH] media: staging: rkisp1: comment each define (RKISP1_CIF_ISP_MODULE_*), explaining what the abbreviation means
Date: Tue, 7 Jul 2020 19:34:13 +0200 [thread overview]
Message-ID: <20200707173413.13977-1-dafna.hirschfeld@collabora.com> (raw)
Add one line comment before each module
define 'RKISP1_CIF_ISP_MODULE_*' explaining what the
abbreviation means.
Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
---
.../staging/media/rkisp1/uapi/rkisp1-config.h | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/drivers/staging/media/rkisp1/uapi/rkisp1-config.h b/drivers/staging/media/rkisp1/uapi/rkisp1-config.h
index 57f5035d62a4..b2923b2833d3 100644
--- a/drivers/staging/media/rkisp1/uapi/rkisp1-config.h
+++ b/drivers/staging/media/rkisp1/uapi/rkisp1-config.h
@@ -18,23 +18,41 @@
#define V4L2_META_FMT_RK_ISP1_PARAMS v4l2_fourcc('R', 'K', '1', 'P') /* Rockchip ISP1 params */
#define V4L2_META_FMT_RK_ISP1_STAT_3A v4l2_fourcc('R', 'K', '1', 'S') /* Rockchip ISP1 3A statistics */
+/* Defect Pixel Cluster Detection */
#define RKISP1_CIF_ISP_MODULE_DPCC BIT(0)
+/* Black Level Subtraction */
#define RKISP1_CIF_ISP_MODULE_BLS BIT(1)
+/* Sensor De-gamma */
#define RKISP1_CIF_ISP_MODULE_SDG BIT(2)
+/* Histogram */
#define RKISP1_CIF_ISP_MODULE_HST BIT(3)
+/* Lens Shade Control */
#define RKISP1_CIF_ISP_MODULE_LSC BIT(4)
+/* Auto White Balance Gain */
#define RKISP1_CIF_ISP_MODULE_AWB_GAIN BIT(5)
+/* Filter */
#define RKISP1_CIF_ISP_MODULE_FLT BIT(6)
+/* Bayer Demosaic */
#define RKISP1_CIF_ISP_MODULE_BDM BIT(7)
+/* Cross Talk */
#define RKISP1_CIF_ISP_MODULE_CTK BIT(8)
+/* Gamma Out Curve */
#define RKISP1_CIF_ISP_MODULE_GOC BIT(9)
+/* Color Processing */
#define RKISP1_CIF_ISP_MODULE_CPROC BIT(10)
+/* Auto Focus Control */
#define RKISP1_CIF_ISP_MODULE_AFC BIT(11)
+/* Auto White Balancing */
#define RKISP1_CIF_ISP_MODULE_AWB BIT(12)
+/* Image Effect */
#define RKISP1_CIF_ISP_MODULE_IE BIT(13)
+/* Auto Exposure Control */
#define RKISP1_CIF_ISP_MODULE_AEC BIT(14)
+/* Wide Dynamic Range */
#define RKISP1_CIF_ISP_MODULE_WDR BIT(15)
+/* Denoise Pre-Filter */
#define RKISP1_CIF_ISP_MODULE_DPF BIT(16)
+/* Denoise Pre-Filter Strength */
#define RKISP1_CIF_ISP_MODULE_DPF_STRENGTH BIT(17)
#define RKISP1_CIF_ISP_CTK_COEFF_MAX 0x100
--
2.17.1
next reply other threads:[~2020-07-07 17:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-07 17:34 Dafna Hirschfeld [this message]
2020-08-03 19:51 ` [PATCH] media: staging: rkisp1: comment each define (RKISP1_CIF_ISP_MODULE_*), explaining what the abbreviation means Helen Koike
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200707173413.13977-1-dafna.hirschfeld@collabora.com \
--to=dafna.hirschfeld@collabora.com \
--cc=dafna3@gmail.com \
--cc=ezequiel@collabora.com \
--cc=helen.koike@collabora.com \
--cc=hverkuil@xs4all.nl \
--cc=kernel@collabora.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=tfiga@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.