All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: alsa-devel@alsa-project.org
Cc: tiwai@suse.de, broonie@kernel.org,
	Lee Jones <lee.jones@linaro.org>,
	Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
	Oder Chiou <oder_chiou@realtek.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	linux-kernel@vger.kernel.org (open list)
Subject: [PATCH v3 07/10] ASoC: codecs: rt5631: fix kernel-doc
Date: Tue,  7 Jul 2020 14:16:12 -0500	[thread overview]
Message-ID: <20200707191615.98296-8-pierre-louis.bossart@linux.intel.com> (raw)
In-Reply-To: <20200707191615.98296-1-pierre-louis.bossart@linux.intel.com>

Fix W=1 warning, spurious kernel-doc start and missing arguments

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
 sound/soc/codecs/rt5631.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/sound/soc/codecs/rt5631.c b/sound/soc/codecs/rt5631.c
index b5184f0e10e3..653da3eaf355 100644
--- a/sound/soc/codecs/rt5631.c
+++ b/sound/soc/codecs/rt5631.c
@@ -64,7 +64,7 @@ static const struct reg_default rt5631_reg[] = {
 	{ RT5631_PSEUDO_SPATL_CTRL, 0x0553 },
 };
 
-/**
+/*
  * rt5631_write_index - write index register of 2nd layer
  */
 static void rt5631_write_index(struct snd_soc_component *component,
@@ -74,7 +74,7 @@ static void rt5631_write_index(struct snd_soc_component *component,
 	snd_soc_component_write(component, RT5631_INDEX_DATA, value);
 }
 
-/**
+/*
  * rt5631_read_index - read index register of 2nd layer
  */
 static unsigned int rt5631_read_index(struct snd_soc_component *component,
@@ -359,6 +359,7 @@ static int check_adcr_select(struct snd_soc_dapm_widget *source,
 
 /**
  * onebit_depop_power_stage - auto depop in power stage.
+ * @component: ASoC component
  * @enable: power on/off
  *
  * When power on/off headphone, the depop sequence is done by hardware.
@@ -397,6 +398,7 @@ static void onebit_depop_power_stage(struct snd_soc_component *component, int en
 
 /**
  * onebit_depop_mute_stage - auto depop in mute stage.
+ * @component: ASoC component
  * @enable: mute/unmute
  *
  * When mute/unmute headphone, the depop sequence is done by hardware.
@@ -435,6 +437,7 @@ static void onebit_depop_mute_stage(struct snd_soc_component *component, int ena
 
 /**
  * onebit_depop_power_stage - step by step depop sequence in power stage.
+ * @component: ASoC component
  * @enable: power on/off
  *
  * When power on/off headphone, the depop sequence is done in step by step.
@@ -507,6 +510,7 @@ static void depop_seq_power_stage(struct snd_soc_component *component, int enabl
 
 /**
  * depop_seq_mute_stage - step by step depop sequence in mute stage.
+ * @component: ASoC component
  * @enable: mute/unmute
  *
  * When mute/unmute headphone, the depop sequence is done in step by step.
-- 
2.25.1


WARNING: multiple messages have this Message-ID (diff)
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: alsa-devel@alsa-project.org
Cc: Oder Chiou <oder_chiou@realtek.com>,
	tiwai@suse.de, open list <linux-kernel@vger.kernel.org>,
	Takashi Iwai <tiwai@suse.com>,
	Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	broonie@kernel.org, Lee Jones <lee.jones@linaro.org>
Subject: [PATCH v3 07/10] ASoC: codecs: rt5631: fix kernel-doc
Date: Tue,  7 Jul 2020 14:16:12 -0500	[thread overview]
Message-ID: <20200707191615.98296-8-pierre-louis.bossart@linux.intel.com> (raw)
In-Reply-To: <20200707191615.98296-1-pierre-louis.bossart@linux.intel.com>

Fix W=1 warning, spurious kernel-doc start and missing arguments

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
 sound/soc/codecs/rt5631.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/sound/soc/codecs/rt5631.c b/sound/soc/codecs/rt5631.c
index b5184f0e10e3..653da3eaf355 100644
--- a/sound/soc/codecs/rt5631.c
+++ b/sound/soc/codecs/rt5631.c
@@ -64,7 +64,7 @@ static const struct reg_default rt5631_reg[] = {
 	{ RT5631_PSEUDO_SPATL_CTRL, 0x0553 },
 };
 
-/**
+/*
  * rt5631_write_index - write index register of 2nd layer
  */
 static void rt5631_write_index(struct snd_soc_component *component,
@@ -74,7 +74,7 @@ static void rt5631_write_index(struct snd_soc_component *component,
 	snd_soc_component_write(component, RT5631_INDEX_DATA, value);
 }
 
-/**
+/*
  * rt5631_read_index - read index register of 2nd layer
  */
 static unsigned int rt5631_read_index(struct snd_soc_component *component,
@@ -359,6 +359,7 @@ static int check_adcr_select(struct snd_soc_dapm_widget *source,
 
 /**
  * onebit_depop_power_stage - auto depop in power stage.
+ * @component: ASoC component
  * @enable: power on/off
  *
  * When power on/off headphone, the depop sequence is done by hardware.
@@ -397,6 +398,7 @@ static void onebit_depop_power_stage(struct snd_soc_component *component, int en
 
 /**
  * onebit_depop_mute_stage - auto depop in mute stage.
+ * @component: ASoC component
  * @enable: mute/unmute
  *
  * When mute/unmute headphone, the depop sequence is done by hardware.
@@ -435,6 +437,7 @@ static void onebit_depop_mute_stage(struct snd_soc_component *component, int ena
 
 /**
  * onebit_depop_power_stage - step by step depop sequence in power stage.
+ * @component: ASoC component
  * @enable: power on/off
  *
  * When power on/off headphone, the depop sequence is done in step by step.
@@ -507,6 +510,7 @@ static void depop_seq_power_stage(struct snd_soc_component *component, int enabl
 
 /**
  * depop_seq_mute_stage - step by step depop sequence in mute stage.
+ * @component: ASoC component
  * @enable: mute/unmute
  *
  * When mute/unmute headphone, the depop sequence is done in step by step.
-- 
2.25.1


  parent reply	other threads:[~2020-07-07 19:16 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-07 19:16 [PATCH v3 00/10] ASoC: Clean-up W=1 build warnings​ - part2 Pierre-Louis Bossart
2020-07-07 19:16 ` [PATCH v3 01/10] ASoC: qcom: q6asm: fix kernel-doc Pierre-Louis Bossart
2020-07-07 19:16   ` Pierre-Louis Bossart
2020-07-07 19:16 ` [PATCH v3 02/10] ASoC: sunxi: sun4i-i2s: " Pierre-Louis Bossart
2020-07-07 19:16   ` Pierre-Louis Bossart
2020-07-07 19:16   ` Pierre-Louis Bossart
2020-07-08  8:11   ` Maxime Ripard
2020-07-08  8:11     ` Maxime Ripard
2020-07-08  8:11     ` Maxime Ripard
2020-07-07 19:16 ` [PATCH v3 03/10] ASoC: sunxi: sun4i-spdif: " Pierre-Louis Bossart
2020-07-07 19:16   ` Pierre-Louis Bossart
2020-07-07 19:16   ` Pierre-Louis Bossart
2020-07-08  8:12   ` Maxime Ripard
2020-07-08  8:12     ` Maxime Ripard
2020-07-08  8:12     ` Maxime Ripard
2020-07-07 19:16 ` [PATCH v3 04/10] ASoC: pxa: pxa-ssp: Demote seemingly unintentional kerneldoc header Pierre-Louis Bossart
2020-07-07 19:16   ` Pierre-Louis Bossart
2020-07-07 19:16   ` Pierre-Louis Bossart
2020-07-07 19:16 ` [PATCH v3 05/10] ASoC: ux500: ux500_msp_i2s: Remove unused variables 'reg_val_DR' and 'reg_val_TSTDR' Pierre-Louis Bossart
2020-07-07 19:16   ` Pierre-Louis Bossart
2020-07-07 19:16 ` [PATCH v3 06/10] ASoC: sti: uniperif: fix 'defined by not used' warning Pierre-Louis Bossart
2020-07-07 19:16   ` Pierre-Louis Bossart
2020-07-08  9:11   ` Arnaud POULIQUEN
2020-07-08  9:11     ` Arnaud POULIQUEN
2020-07-08 12:55     ` Pierre-Louis Bossart
2020-07-08 12:55       ` Pierre-Louis Bossart
2020-07-08 13:33       ` Arnaud POULIQUEN
2020-07-08 13:33         ` Arnaud POULIQUEN
2020-07-07 19:16 ` Pierre-Louis Bossart [this message]
2020-07-07 19:16   ` [PATCH v3 07/10] ASoC: codecs: rt5631: fix kernel-doc Pierre-Louis Bossart
2020-07-07 19:16 ` [PATCH v3 08/10] ASoC: codecs: rt5659: Remove many unused const variables Pierre-Louis Bossart
2020-07-07 19:16   ` Pierre-Louis Bossart
2020-07-07 19:16 ` [PATCH v3 09/10] ASoC: codecs: tlv320aic26: fix kernel-doc warning Pierre-Louis Bossart
2020-07-07 19:16   ` Pierre-Louis Bossart
2020-07-07 19:16 ` [PATCH v3 10/10] ASoC: codecs: ak4458: Remove set but never checked variable 'ret' Pierre-Louis Bossart
2020-07-07 19:16   ` Pierre-Louis Bossart
2020-07-08  6:39 ` [PATCH v3 00/10] ASoC: Clean-up W=1 build warnings​ - part2 Lee Jones
2020-07-08 12:59   ` Pierre-Louis Bossart
2020-07-08 13:06     ` Lee Jones
2020-07-08 13:38       ` Mark Brown
2020-07-08 13:50         ` Lee Jones
2020-07-08 14:42           ` Mark Brown
2020-07-10 15:39 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200707191615.98296-8-pierre-louis.bossart@linux.intel.com \
    --to=pierre-louis.bossart@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=lee.jones@linaro.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oder_chiou@realtek.com \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.