From: Wei Yongjun <weiyongjun1@huawei.com>
To: Hulk Robot <hulkci@huawei.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Daniel Colascione <dancol@google.com>
Cc: Wei Yongjun <weiyongjun1@huawei.com>, <linux-fsdevel@vger.kernel.org>
Subject: [PATCH -next] vfs: Make _anon_inode_getfile() static
Date: Wed, 8 Jul 2020 23:28:17 +0800 [thread overview]
Message-ID: <20200708152817.13534-1-weiyongjun1@huawei.com> (raw)
The sparse tool complains as follows:
fs/anon_inodes.c:80:13: warning:
symbol '_anon_inode_getfile' was not declared. Should it be static?
_anon_inode_getfile() is not used outside of anon_inodes.c,
so marks it static.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
fs/anon_inodes.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/fs/anon_inodes.c b/fs/anon_inodes.c
index 25d92c64411e..90b022960027 100644
--- a/fs/anon_inodes.c
+++ b/fs/anon_inodes.c
@@ -77,11 +77,11 @@ static struct inode *anon_inode_make_secure_inode(
return inode;
}
-struct file *_anon_inode_getfile(const char *name,
- const struct file_operations *fops,
- void *priv, int flags,
- const struct inode *context_inode,
- bool secure)
+static struct file *_anon_inode_getfile(const char *name,
+ const struct file_operations *fops,
+ void *priv, int flags,
+ const struct inode *context_inode,
+ bool secure)
{
struct inode *inode;
struct file *file;
reply other threads:[~2020-07-08 15:18 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200708152817.13534-1-weiyongjun1@huawei.com \
--to=weiyongjun1@huawei.com \
--cc=dancol@google.com \
--cc=hulkci@huawei.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.