All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: alsa-devel@alsa-project.org
Cc: "Gustavo A . R . Silva" <gustavoars@kernel.org>
Subject: [PATCH 2/3] ALSA: xen: Remove superfluous fall through comments
Date: Thu,  9 Jul 2020 13:17:49 +0200	[thread overview]
Message-ID: <20200709111750.8337-3-tiwai@suse.de> (raw)
In-Reply-To: <20200709111750.8337-1-tiwai@suse.de>

The "fall through" comments found in switch-cases in ALSA xen driver
are all superfluous.  The kernel coding style allows the multiple
cases in a row.  Let's remove them.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
 sound/xen/xen_snd_front.c         | 4 ----
 sound/xen/xen_snd_front_evtchnl.c | 4 ----
 2 files changed, 8 deletions(-)

diff --git a/sound/xen/xen_snd_front.c b/sound/xen/xen_snd_front.c
index e21d0bfafeae..228d82031297 100644
--- a/sound/xen/xen_snd_front.c
+++ b/sound/xen/xen_snd_front.c
@@ -246,11 +246,8 @@ static void sndback_changed(struct xenbus_device *xb_dev,
 
 	switch (backend_state) {
 	case XenbusStateReconfiguring:
-		/* fall through */
 	case XenbusStateReconfigured:
-		/* fall through */
 	case XenbusStateInitialised:
-		/* fall through */
 		break;
 
 	case XenbusStateInitialising:
@@ -289,7 +286,6 @@ static void sndback_changed(struct xenbus_device *xb_dev,
 		break;
 
 	case XenbusStateUnknown:
-		/* fall through */
 	case XenbusStateClosed:
 		if (xb_dev->state == XenbusStateClosed)
 			break;
diff --git a/sound/xen/xen_snd_front_evtchnl.c b/sound/xen/xen_snd_front_evtchnl.c
index 102d6e096cc8..29e0f0ea67eb 100644
--- a/sound/xen/xen_snd_front_evtchnl.c
+++ b/sound/xen/xen_snd_front_evtchnl.c
@@ -46,13 +46,9 @@ static irqreturn_t evtchnl_interrupt_req(int irq, void *dev_id)
 			continue;
 		switch (resp->operation) {
 		case XENSND_OP_OPEN:
-			/* fall through */
 		case XENSND_OP_CLOSE:
-			/* fall through */
 		case XENSND_OP_READ:
-			/* fall through */
 		case XENSND_OP_WRITE:
-			/* fall through */
 		case XENSND_OP_TRIGGER:
 			channel->u.req.resp_status = resp->status;
 			complete(&channel->u.req.completion);
-- 
2.16.4


  parent reply	other threads:[~2020-07-09 11:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-09 11:17 [PATCH 0/3] ALSA: Convert remaining fall through comments Takashi Iwai
2020-07-09 11:17 ` [PATCH 1/3] ALSA: atmel: Remove invalid "fall through" comments Takashi Iwai
2020-07-09 16:33   ` Gustavo A. R. Silva
2020-07-09 11:17 ` Takashi Iwai [this message]
2020-07-09 16:33   ` [PATCH 2/3] ALSA: xen: Remove superfluous fall through comments Gustavo A. R. Silva
2020-07-09 11:17 ` [PATCH 3/3] ALSA: Replace with fallthrough pseudo keyword in the remaining places Takashi Iwai
2020-07-09 16:32   ` Gustavo A. R. Silva

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200709111750.8337-3-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=gustavoars@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.