All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: alsa-devel@alsa-project.org
Cc: tiwai@suse.de, broonie@kernel.org,
	Lee Jones <lee.jones@linaro.org>,
	Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
	Arnaud Pouliquen <arnaud.pouliquen@st.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	linux-kernel@vger.kernel.org (open list)
Subject: [PATCH v4 01/10] ASoC: sti: uniperif: fix 'defined by not used' warning
Date: Thu,  9 Jul 2020 11:23:18 -0500	[thread overview]
Message-ID: <20200709162328.259586-2-pierre-louis.bossart@linux.intel.com> (raw)
In-Reply-To: <20200709162328.259586-1-pierre-louis.bossart@linux.intel.com>

Fix W=1 warning. The table uni_tdm_hw is declared in a header included
by multiple C file. This isn't really a good practice but for now
using __maybe_unused makes the following warning go away.

sound/soc/sti/sti_uniperif.c:12:
sound/soc/sti/uniperif.h:1351:38: warning: ‘uni_tdm_hw’ defined but
not used [-Wunused-const-variable=]
 1351 | static const struct snd_pcm_hardware uni_tdm_hw = {
      |                                      ^~~~~~~~~~

Acked-by: Arnaud Pouliquen <arnaud.pouliquen@st.com>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
 sound/soc/sti/uniperif.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/sti/uniperif.h b/sound/soc/sti/uniperif.h
index 2dc2da5d458b..a16adeb7c1e9 100644
--- a/sound/soc/sti/uniperif.h
+++ b/sound/soc/sti/uniperif.h
@@ -1348,7 +1348,7 @@ struct sti_uniperiph_data {
 	struct sti_uniperiph_dai dai_data;
 };
 
-static const struct snd_pcm_hardware uni_tdm_hw = {
+static __maybe_unused const struct snd_pcm_hardware uni_tdm_hw = {
 	.info = SNDRV_PCM_INFO_INTERLEAVED | SNDRV_PCM_INFO_BLOCK_TRANSFER |
 		SNDRV_PCM_INFO_PAUSE | SNDRV_PCM_INFO_MMAP |
 		SNDRV_PCM_INFO_MMAP_VALID,
-- 
2.25.1


WARNING: multiple messages have this Message-ID (diff)
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: alsa-devel@alsa-project.org
Cc: tiwai@suse.de, open list <linux-kernel@vger.kernel.org>,
	Takashi Iwai <tiwai@suse.com>,
	Arnaud Pouliquen <arnaud.pouliquen@st.com>,
	Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	broonie@kernel.org, Lee Jones <lee.jones@linaro.org>
Subject: [PATCH v4 01/10] ASoC: sti: uniperif: fix 'defined by not used' warning
Date: Thu,  9 Jul 2020 11:23:18 -0500	[thread overview]
Message-ID: <20200709162328.259586-2-pierre-louis.bossart@linux.intel.com> (raw)
In-Reply-To: <20200709162328.259586-1-pierre-louis.bossart@linux.intel.com>

Fix W=1 warning. The table uni_tdm_hw is declared in a header included
by multiple C file. This isn't really a good practice but for now
using __maybe_unused makes the following warning go away.

sound/soc/sti/sti_uniperif.c:12:
sound/soc/sti/uniperif.h:1351:38: warning: ‘uni_tdm_hw’ defined but
not used [-Wunused-const-variable=]
 1351 | static const struct snd_pcm_hardware uni_tdm_hw = {
      |                                      ^~~~~~~~~~

Acked-by: Arnaud Pouliquen <arnaud.pouliquen@st.com>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
 sound/soc/sti/uniperif.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/sti/uniperif.h b/sound/soc/sti/uniperif.h
index 2dc2da5d458b..a16adeb7c1e9 100644
--- a/sound/soc/sti/uniperif.h
+++ b/sound/soc/sti/uniperif.h
@@ -1348,7 +1348,7 @@ struct sti_uniperiph_data {
 	struct sti_uniperiph_dai dai_data;
 };
 
-static const struct snd_pcm_hardware uni_tdm_hw = {
+static __maybe_unused const struct snd_pcm_hardware uni_tdm_hw = {
 	.info = SNDRV_PCM_INFO_INTERLEAVED | SNDRV_PCM_INFO_BLOCK_TRANSFER |
 		SNDRV_PCM_INFO_PAUSE | SNDRV_PCM_INFO_MMAP |
 		SNDRV_PCM_INFO_MMAP_VALID,
-- 
2.25.1


  reply	other threads:[~2020-07-09 16:23 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-09 16:23 [PATCH v4 00/10] ASoC: Clean-up W=1 build warnings​ - part2 Pierre-Louis Bossart
2020-07-09 16:23 ` Pierre-Louis Bossart [this message]
2020-07-09 16:23   ` [PATCH v4 01/10] ASoC: sti: uniperif: fix 'defined by not used' warning Pierre-Louis Bossart
2020-07-09 16:23 ` [PATCH v4 02/10] ASoC: qcom: qdsp6: q6asm: Provide documentation for 'codec_profile' Pierre-Louis Bossart
2020-07-09 16:23   ` Pierre-Louis Bossart
2020-07-09 16:23 ` [PATCH v4 03/10] ASoC: sunxi: sun4i-i2s: add missing clock and format arguments in kernel-doc Pierre-Louis Bossart
2020-07-09 16:23   ` Pierre-Louis Bossart
2020-07-09 16:23   ` Pierre-Louis Bossart
2020-07-09 16:23 ` [PATCH v4 04/10] ASoC: sunxi: sun4i-spdif: Fix misspelling of 'reg_dac_txdata' " Pierre-Louis Bossart
2020-07-09 16:23   ` Pierre-Louis Bossart
2020-07-09 16:23   ` Pierre-Louis Bossart
2020-07-09 16:23 ` [PATCH v4 05/10] ASoC: pxa: pxa-ssp: Demote seemingly unintentional kerneldoc header Pierre-Louis Bossart
2020-07-09 16:23   ` Pierre-Louis Bossart
2020-07-09 16:23   ` Pierre-Louis Bossart
2020-07-09 16:23 ` [PATCH v4 06/10] ASoC: ux500: ux500_msp_i2s: Remove unused variables 'reg_val_DR' and 'reg_val_TSTDR' Pierre-Louis Bossart
2020-07-09 16:23   ` Pierre-Louis Bossart
2020-07-09 16:23 ` [PATCH v4 07/10] ASoC: codecs: rt5631: fix spurious kernel-doc start and missing arguments Pierre-Louis Bossart
2020-07-09 16:23   ` Pierre-Louis Bossart
2020-07-09 16:23 ` [PATCH v4 08/10] ASoC: codecs: rt5659: Remove many unused const variables Pierre-Louis Bossart
2020-07-09 16:23   ` Pierre-Louis Bossart
2020-07-09 16:23 ` [PATCH v4 09/10] ASoC: codecs: tlv320aic26: Demote seemingly unintentional kerneldoc header Pierre-Louis Bossart
2020-07-09 16:23   ` Pierre-Louis Bossart
2020-07-09 16:23 ` [PATCH v4 10/10] ASoC: codecs: ak4458: Remove set but never checked variable 'ret' Pierre-Louis Bossart
2020-07-09 16:23   ` Pierre-Louis Bossart
2020-07-10 15:39 ` [PATCH v4 00/10] ASoC: Clean-up W=1 build warnings​ - part2 Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200709162328.259586-2-pierre-louis.bossart@linux.intel.com \
    --to=pierre-louis.bossart@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=arnaud.pouliquen@st.com \
    --cc=broonie@kernel.org \
    --cc=lee.jones@linaro.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.