All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Murphy <dmurphy@ti.com>
To: <jacek.anaszewski@gmail.com>, <pavel@ucw.cz>, <robh@kernel.org>,
	<marek.behun@nic.cz>
Cc: <devicetree@vger.kernel.org>, <linux-leds@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	Dan Murphy <dmurphy@ti.com>
Subject: [PATCH v30 02/16] leds: lp5523: Fix various formatting issues in the code
Date: Mon, 13 Jul 2020 10:45:30 -0500	[thread overview]
Message-ID: <20200713154544.1683-3-dmurphy@ti.com> (raw)
In-Reply-To: <20200713154544.1683-1-dmurphy@ti.com>

Fix checkpatch errors and warnings for the LP5523.c device
driver.

Acked-by: Pavel Machek <pavel@ucw.cz>
Acked-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
Signed-off-by: Dan Murphy <dmurphy@ti.com>
---
 drivers/leds/leds-lp5523.c | 19 ++++++++++---------
 1 file changed, 10 insertions(+), 9 deletions(-)

diff --git a/drivers/leds/leds-lp5523.c b/drivers/leds/leds-lp5523.c
index d0b931a136b9..8518de957b48 100644
--- a/drivers/leds/leds-lp5523.c
+++ b/drivers/leds/leds-lp5523.c
@@ -23,13 +23,13 @@
 
 #define LP5523_PROGRAM_LENGTH		32	/* bytes */
 /* Memory is used like this:
-   0x00 engine 1 program
-   0x10 engine 2 program
-   0x20 engine 3 program
-   0x30 engine 1 muxing info
-   0x40 engine 2 muxing info
-   0x50 engine 3 muxing info
-*/
+ * 0x00 engine 1 program
+ * 0x10 engine 2 program
+ * 0x20 engine 3 program
+ * 0x30 engine 1 muxing info
+ * 0x40 engine 2 muxing info
+ * 0x50 engine 3 muxing info
+ */
 #define LP5523_MAX_LEDS			9
 
 /* Registers */
@@ -326,7 +326,7 @@ static int lp5523_update_program_memory(struct lp55xx_chip *chip,
 					const u8 *data, size_t size)
 {
 	u8 pattern[LP5523_PROGRAM_LENGTH] = {0};
-	unsigned cmd;
+	unsigned int cmd;
 	char c[3];
 	int nrchars;
 	int ret;
@@ -468,6 +468,7 @@ static int lp5523_mux_parse(const char *buf, u16 *mux, size_t len)
 static void lp5523_mux_to_array(u16 led_mux, char *array)
 {
 	int i, pos = 0;
+
 	for (i = 0; i < LP5523_MAX_LEDS; i++)
 		pos += sprintf(array + pos, "%x", LED_ACTIVE(led_mux, i));
 
@@ -506,7 +507,7 @@ static int lp5523_load_mux(struct lp55xx_chip *chip, u16 mux, int nr)
 	if (ret)
 		return ret;
 
-	ret = lp55xx_write(chip, LP5523_REG_PROG_MEM , (u8)(mux >> 8));
+	ret = lp55xx_write(chip, LP5523_REG_PROG_MEM, (u8)(mux >> 8));
 	if (ret)
 		return ret;
 
-- 
2.27.0


WARNING: multiple messages have this Message-ID (diff)
From: Dan Murphy <dmurphy@ti.com>
To: <jacek.anaszewski@gmail.com>, <pavel@ucw.cz>, <robh@kernel.org>,
	<marek.behun@nic.cz>
Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org,
	Dan Murphy <dmurphy@ti.com>
Subject: [PATCH v30 02/16] leds: lp5523: Fix various formatting issues in the code
Date: Mon, 13 Jul 2020 10:45:30 -0500	[thread overview]
Message-ID: <20200713154544.1683-3-dmurphy@ti.com> (raw)
In-Reply-To: <20200713154544.1683-1-dmurphy@ti.com>

Fix checkpatch errors and warnings for the LP5523.c device
driver.

Acked-by: Pavel Machek <pavel@ucw.cz>
Acked-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
Signed-off-by: Dan Murphy <dmurphy@ti.com>
---
 drivers/leds/leds-lp5523.c | 19 ++++++++++---------
 1 file changed, 10 insertions(+), 9 deletions(-)

diff --git a/drivers/leds/leds-lp5523.c b/drivers/leds/leds-lp5523.c
index d0b931a136b9..8518de957b48 100644
--- a/drivers/leds/leds-lp5523.c
+++ b/drivers/leds/leds-lp5523.c
@@ -23,13 +23,13 @@
 
 #define LP5523_PROGRAM_LENGTH		32	/* bytes */
 /* Memory is used like this:
-   0x00 engine 1 program
-   0x10 engine 2 program
-   0x20 engine 3 program
-   0x30 engine 1 muxing info
-   0x40 engine 2 muxing info
-   0x50 engine 3 muxing info
-*/
+ * 0x00 engine 1 program
+ * 0x10 engine 2 program
+ * 0x20 engine 3 program
+ * 0x30 engine 1 muxing info
+ * 0x40 engine 2 muxing info
+ * 0x50 engine 3 muxing info
+ */
 #define LP5523_MAX_LEDS			9
 
 /* Registers */
@@ -326,7 +326,7 @@ static int lp5523_update_program_memory(struct lp55xx_chip *chip,
 					const u8 *data, size_t size)
 {
 	u8 pattern[LP5523_PROGRAM_LENGTH] = {0};
-	unsigned cmd;
+	unsigned int cmd;
 	char c[3];
 	int nrchars;
 	int ret;
@@ -468,6 +468,7 @@ static int lp5523_mux_parse(const char *buf, u16 *mux, size_t len)
 static void lp5523_mux_to_array(u16 led_mux, char *array)
 {
 	int i, pos = 0;
+
 	for (i = 0; i < LP5523_MAX_LEDS; i++)
 		pos += sprintf(array + pos, "%x", LED_ACTIVE(led_mux, i));
 
@@ -506,7 +507,7 @@ static int lp5523_load_mux(struct lp55xx_chip *chip, u16 mux, int nr)
 	if (ret)
 		return ret;
 
-	ret = lp55xx_write(chip, LP5523_REG_PROG_MEM , (u8)(mux >> 8));
+	ret = lp55xx_write(chip, LP5523_REG_PROG_MEM, (u8)(mux >> 8));
 	if (ret)
 		return ret;
 
-- 
2.27.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2020-07-13 15:46 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-13 15:45 [PATCH v30 00/16] Multicolor Framework v30 Dan Murphy
2020-07-13 15:45 ` Dan Murphy
2020-07-13 15:45 ` [PATCH v30 01/16] leds: lp55xx: Fix file permissions to use DEVICE_ATTR macros Dan Murphy
2020-07-13 15:45   ` Dan Murphy
2020-07-15 13:19   ` Marek Behún
2020-07-15 13:19     ` Marek Behún
2020-07-13 15:45 ` Dan Murphy [this message]
2020-07-13 15:45   ` [PATCH v30 02/16] leds: lp5523: Fix various formatting issues in the code Dan Murphy
2020-07-15 13:20   ` Marek Behún
2020-07-15 13:20     ` Marek Behún
2020-07-13 15:45 ` [PATCH v30 03/16] dt: bindings: Add multicolor class dt bindings documention Dan Murphy
2020-07-13 15:45   ` Dan Murphy
2020-07-15 13:20   ` Marek Behún
2020-07-15 13:20     ` Marek Behún
2020-07-13 15:45 ` [PATCH v30 04/16] leds: Add multicolor ID to the color ID list Dan Murphy
2020-07-13 15:45   ` Dan Murphy
2020-07-15 13:20   ` Marek Behún
2020-07-15 13:20     ` Marek Behún
2020-07-15 17:36     ` Pavel Machek
2020-07-15 17:36       ` Pavel Machek
2020-07-15 17:59       ` Marek Behún
2020-07-15 17:59         ` Marek Behún
2020-07-13 15:45 ` [PATCH v30 05/16] leds: multicolor: Introduce a multicolor class definition Dan Murphy
2020-07-13 15:45   ` Dan Murphy
2020-07-15 13:21   ` Marek Behún
2020-07-15 13:21     ` Marek Behún
2020-07-16  8:31   ` Pavel Machek
2020-07-16  8:31     ` Pavel Machek
2020-07-16 15:03     ` Dan Murphy
2020-07-16 15:03       ` Dan Murphy
2020-07-16 15:06       ` Dan Murphy
2020-07-16 15:06         ` Dan Murphy
2020-07-13 15:45 ` [PATCH v30 06/16] dt: bindings: lp50xx: Introduce the lp50xx family of RGB drivers Dan Murphy
2020-07-13 15:45   ` Dan Murphy
2020-07-13 15:45 ` [PATCH v30 07/16] leds: lp50xx: Add the LP50XX family of the RGB LED driver Dan Murphy
2020-07-13 15:45   ` Dan Murphy
2020-07-13 15:45 ` [PATCH v30 08/16] dt-bindings: leds: Convert leds-lp55xx to yaml Dan Murphy
2020-07-13 15:45   ` Dan Murphy
2020-07-13 15:45 ` [PATCH v30 09/16] leds: lp55xx: Convert LED class registration to devm_* Dan Murphy
2020-07-13 15:45   ` Dan Murphy
2020-07-13 15:45 ` [PATCH v30 10/16] leds: lp55xx: Add multicolor framework support to lp55xx Dan Murphy
2020-07-13 15:45   ` Dan Murphy
2020-07-13 15:45 ` [PATCH v30 11/16] ARM: defconfig: u8500: Add LP55XX_COMMON config flag Dan Murphy
2020-07-13 15:45   ` Dan Murphy
2020-07-13 15:45 ` [PATCH v30 12/16] leds: lp5523: Update the lp5523 code to add multicolor brightness function Dan Murphy
2020-07-13 15:45   ` Dan Murphy
2020-07-13 15:45 ` [PATCH v30 13/16] leds: lp5521: Add multicolor framework multicolor brightness support Dan Murphy
2020-07-13 15:45   ` Dan Murphy
2020-07-13 15:45 ` [PATCH v30 14/16] ARM: dts: n900: Add reg property to the LP5523 channel node Dan Murphy
2020-07-13 15:45   ` Dan Murphy
2020-07-13 15:45 ` [PATCH v30 15/16] ARM: dts: imx6dl-yapp4: Add reg property to the lp5562 " Dan Murphy
2020-07-13 15:45   ` Dan Murphy
2020-07-13 15:45 ` [PATCH v30 16/16] ARM: dts: ste-href: Add reg property to the LP5521 channel nodes Dan Murphy
2020-07-13 15:45   ` Dan Murphy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200713154544.1683-3-dmurphy@ti.com \
    --to=dmurphy@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jacek.anaszewski@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=marek.behun@nic.cz \
    --cc=pavel@ucw.cz \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.