All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thiago Jung Bauermann <bauerman@linux.ibm.com>
To: qemu-ppc@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
	"David Hildenbrand" <david@redhat.com>,
	"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
	qemu-devel@nongnu.org,
	"Aleksandar Markovic" <aleksandar.qemu.devel@gmail.com>,
	"Thomas Huth" <thuth@redhat.com>,
	"David Gibson" <david@gibson.dropbear.id.au>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Artyom Tarasenko" <atar4qemu@gmail.com>,
	"Aleksandar Rikalo" <aleksandar.rikalo@syrmia.com>,
	"Eduardo Habkost" <ehabkost@redhat.com>,
	"Greg Kurz" <groug@kaod.org>,
	qemu-s390x@nongnu.org, qemu-arm@nongnu.org,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Richard Henderson" <rth@twiddle.net>,
	"Cornelia Huck" <cohuck@redhat.com>,
	"Aurelien Jarno" <aurelien@aurel32.net>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Thiago Jung Bauermann" <bauerman@linux.ibm.com>
Subject: [PATCH v3 5/8] mips/cps: Use start-powered-off CPUState property
Date: Wed, 22 Jul 2020 23:56:54 -0300	[thread overview]
Message-ID: <20200723025657.644724-6-bauerman@linux.ibm.com> (raw)
In-Reply-To: <20200723025657.644724-1-bauerman@linux.ibm.com>

Instead of setting CPUState::halted to 1 in main_cpu_reset(), use the
start-powered-off property which makes cpu_common_reset() initialize it
to 1 in common code.

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Thiago Jung Bauermann <bauerman@linux.ibm.com>
---
 hw/mips/cps.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

NB: I was only able to test that this patch builds. I wasn't able to
run it.

diff --git a/hw/mips/cps.c b/hw/mips/cps.c
index 615e1a1ad2..d5b6c78019 100644
--- a/hw/mips/cps.c
+++ b/hw/mips/cps.c
@@ -52,9 +52,6 @@ static void main_cpu_reset(void *opaque)
     CPUState *cs = CPU(cpu);
 
     cpu_reset(cs);
-
-    /* All VPs are halted on reset. Leave powering up to CPC. */
-    cs->halted = 1;
 }
 
 static bool cpu_mips_itu_supported(CPUMIPSState *env)
@@ -89,6 +86,9 @@ static void mips_cps_realize(DeviceState *dev, Error **errp)
             env->itc_tag = mips_itu_get_tag_region(&s->itu);
             env->itu = &s->itu;
         }
+        /* All VPs are halted on reset. Leave powering up to CPC. */
+        object_property_set_bool(OBJECT(cpu), "start-powered-off", true,
+                                 &error_abort);
         qemu_register_reset(main_cpu_reset, cpu);
     }
 


  parent reply	other threads:[~2020-07-23  2:59 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-23  2:56 [PATCH v3 0/8] Generalize start-powered-off property from ARM Thiago Jung Bauermann
2020-07-23  2:56 ` [PATCH v3 1/8] target/arm: Move start-powered-off property to generic CPUState Thiago Jung Bauermann
2020-07-23  3:06   ` David Gibson
2020-07-23  3:33     ` Thiago Jung Bauermann
2020-07-27 12:36     ` Greg Kurz
2020-07-28 23:00       ` Thiago Jung Bauermann
2020-07-23  2:56 ` [PATCH v3 2/8] target/arm: Move setting of CPU halted state to generic code Thiago Jung Bauermann
2020-07-23  3:06   ` David Gibson
2020-07-27 12:39   ` Greg Kurz
2020-07-23  2:56 ` [PATCH v3 3/8] ppc/spapr: Use start-powered-off CPUState property Thiago Jung Bauermann
2020-07-23  3:06   ` David Gibson
2020-07-27 13:28   ` Greg Kurz
2020-07-28 23:03     ` Thiago Jung Bauermann
2020-07-27 14:25   ` Philippe Mathieu-Daudé
2020-07-23  2:56 ` [PATCH v3 4/8] ppc/e500: " Thiago Jung Bauermann
2020-07-23  3:07   ` David Gibson
2020-07-23  2:56 ` Thiago Jung Bauermann [this message]
2020-07-23  3:07   ` [PATCH v3 5/8] mips/cps: " David Gibson
2020-07-23  2:56 ` [PATCH v3 6/8] sparc/sun4m: Remove main_cpu_reset() Thiago Jung Bauermann
2020-07-23  3:08   ` David Gibson
2020-07-23  2:56 ` [PATCH v3 7/8] sparc/sun4m: Use start-powered-off CPUState property Thiago Jung Bauermann
2020-07-23  3:08   ` David Gibson
2020-07-27 14:15   ` Philippe Mathieu-Daudé
2020-07-23  2:56 ` [RFC PATCH v3 8/8] target/s390x: " Thiago Jung Bauermann
2020-07-27 12:43   ` Cornelia Huck
2020-07-29  0:51     ` Thiago Jung Bauermann
2020-07-30  9:45       ` Cornelia Huck
2020-08-11 11:04         ` Cornelia Huck
2020-08-13  1:25           ` Thiago Jung Bauermann
2020-07-29  0:56 ` [PATCH v3 0/8] Generalize start-powered-off property from ARM Thiago Jung Bauermann
2020-07-30  0:59   ` David Gibson
2020-07-30 11:05     ` Philippe Mathieu-Daudé
2020-07-30 15:04       ` Thiago Jung Bauermann
2020-08-05 17:01         ` Thiago Jung Bauermann
2020-08-05 19:04           ` Peter Maydell
2020-08-05 20:22             ` Thiago Jung Bauermann
2020-08-06  5:13             ` David Gibson
2020-08-06  9:17               ` Peter Maydell
2020-07-30 15:47 ` Peter Maydell
2020-08-17  4:47 ` David Gibson
2020-08-17  5:24   ` Philippe Mathieu-Daudé
2020-08-17  5:43     ` David Gibson
2020-08-18  1:43       ` Thiago Jung Bauermann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200723025657.644724-6-bauerman@linux.ibm.com \
    --to=bauerman@linux.ibm.com \
    --cc=aleksandar.qemu.devel@gmail.com \
    --cc=aleksandar.rikalo@syrmia.com \
    --cc=alex.bennee@linaro.org \
    --cc=atar4qemu@gmail.com \
    --cc=aurelien@aurel32.net \
    --cc=cohuck@redhat.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=david@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=groug@kaod.org \
    --cc=mark.cave-ayland@ilande.co.uk \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@redhat.com \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.