From: Allison Collins <allison.henderson@oracle.com>
To: linux-xfs@vger.kernel.org
Subject: [PATCH v2 2/2] xfs: Fix compiler warning in xfs_attr_shortform_add
Date: Sun, 26 Jul 2020 19:26:08 -0700 [thread overview]
Message-ID: <20200727022608.18535-3-allison.henderson@oracle.com> (raw)
In-Reply-To: <20200727022608.18535-1-allison.henderson@oracle.com>
Fix compiler warning warning: variable 'error' set but not used in
xfs_attr_shortform_add. error is used only in an ASSERT so only declare
error when DEBUG is set.
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Allison Collins <allison.henderson@oracle.com>
---
fs/xfs/libxfs/xfs_attr_leaf.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/fs/xfs/libxfs/xfs_attr_leaf.c b/fs/xfs/libxfs/xfs_attr_leaf.c
index ad7b351..db985b8 100644
--- a/fs/xfs/libxfs/xfs_attr_leaf.c
+++ b/fs/xfs/libxfs/xfs_attr_leaf.c
@@ -715,7 +715,10 @@ xfs_attr_shortform_add(
{
struct xfs_attr_shortform *sf;
struct xfs_attr_sf_entry *sfe;
- int offset, size, error;
+ int offset, size;
+#if DEBUG
+ int error;
+#endif
struct xfs_mount *mp;
struct xfs_inode *dp;
struct xfs_ifork *ifp;
--
2.7.4
prev parent reply other threads:[~2020-07-27 2:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-27 2:26 [PATCH v2 0/2] xfs: Fix compiler warnings Allison Collins
2020-07-27 2:26 ` [PATCH v2 1/2] xfs: Fix compiler warning in xfs_attr_node_removename_setup Allison Collins
2020-07-27 15:46 ` Darrick J. Wong
2020-07-27 16:42 ` Allison Collins
2020-07-27 16:51 ` Allison Collins
2020-07-27 18:50 ` Darrick J. Wong
2020-07-27 19:20 ` Allison Collins
2020-07-27 2:26 ` Allison Collins [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200727022608.18535-3-allison.henderson@oracle.com \
--to=allison.henderson@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.