All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Rapoport <rppt@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-sh@vger.kernel.org, Peter Zijlstra <peterz@infradead.org>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	linux-mips@vger.kernel.org, Max Filippov <jcmvbkbc@gmail.com>,
	Paul Mackerras <paulus@samba.org>,
	sparclinux@vger.kernel.org, linux-riscv@lists.infradead.org,
	Will Deacon <will@kernel.org>, Stafford Horne <shorne@gmail.com>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	linux-s390@vger.kernel.org, linux-c6x-dev@linux-c6x.org,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Michael Ellerman <mpe@ellerman.id.au>,
	x86@kernel.org, Russell King <linux@armlinux.org.uk>,
	Mike Rapoport <rppt@linux.ibm.com>,
	clang-built-linux@googlegroups.com,
	Ingo Molnar <mingo@redhat.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	uclinux-h8-devel@lists.sourceforge.jp,
	linux-xtensa@linux-xtensa.org, openrisc@lists.librecores.org,
	Borislav Petkov <bp@alien8.de>, Andy Lutomirski <luto@kernel.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	linux-arm-kernel@lists.infradead.org,
	Michal Simek <monstr@monstr.eu>,
	linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org,
	linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Christoph Hellwig <hch@lst.de>, Mike Rapoport <rppt@kernel.org>
Subject: [PATCH 04/15] arm64: numa: simplify dummy_numa_init()
Date: Tue, 28 Jul 2020 05:11:42 +0000	[thread overview]
Message-ID: <20200728051153.1590-5-rppt@kernel.org> (raw)
In-Reply-To: <20200728051153.1590-1-rppt@kernel.org>

From: Mike Rapoport <rppt@linux.ibm.com>

dummy_numa_init() loops over memblock.memory and passes nid=0 to
numa_add_memblk() which essentially wraps memblock_set_node(). However,
memblock_set_node() can cope with entire memory span itself, so the loop
over memblock.memory regions is redundant.

Replace the loop with a single call to memblock_set_node() to the entire
memory.

Signed-off-by: Mike Rapoport <rppt@linux.ibm.com>
---
 arch/arm64/mm/numa.c | 13 +++++--------
 1 file changed, 5 insertions(+), 8 deletions(-)

diff --git a/arch/arm64/mm/numa.c b/arch/arm64/mm/numa.c
index aafcee3e3f7e..0cbdbcc885fb 100644
--- a/arch/arm64/mm/numa.c
+++ b/arch/arm64/mm/numa.c
@@ -423,19 +423,16 @@ static int __init numa_init(int (*init_func)(void))
  */
 static int __init dummy_numa_init(void)
 {
+	phys_addr_t start = memblock_start_of_DRAM();
+	phys_addr_t end = memblock_end_of_DRAM();
 	int ret;
-	struct memblock_region *mblk;
 
 	if (numa_off)
 		pr_info("NUMA disabled\n"); /* Forced off on command line. */
-	pr_info("Faking a node at [mem %#018Lx-%#018Lx]\n",
-		memblock_start_of_DRAM(), memblock_end_of_DRAM() - 1);
-
-	for_each_memblock(memory, mblk) {
-		ret = numa_add_memblk(0, mblk->base, mblk->base + mblk->size);
-		if (!ret)
-			continue;
+	pr_info("Faking a node at [mem %#018Lx-%#018Lx]\n", start, end - 1);
 
+	ret = numa_add_memblk(0, start, end);
+	if (ret) {
 		pr_err("NUMA init failed\n");
 		return ret;
 	}
-- 
2.26.2

WARNING: multiple messages have this Message-ID (diff)
From: Mike Rapoport <rppt@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Andy Lutomirski <luto@kernel.org>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Borislav Petkov <bp@alien8.de>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Christoph Hellwig <hch@lst.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	Ingo Molnar <mingo@redhat.com>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Max Filippov <jcmvbkbc@gmail.com>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Michal Simek <monstr@monstr.eu>,
	Mike Rapoport <rppt@linux.ibm.com>,
	Mike Rapoport <rppt@kernel.org>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Paul Mackerras <paulus@samba.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Russell King <linux@armlinux.org.uk>,
	Stafford Horne <shorne@gmail.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Will Deacon <will@kernel.org>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	clang-built-linux@googlegroups.com,
	iommu@lists.linux-foundation.org,
	linux-arm-kernel@lists.infradead.org,
	linux-c6x-dev@linux-c6x.org, linux-kernel@vger.kernel.org,
	linux-mips@vger.kernel.org, linux-mm@kvack.org,
	linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org,
	linux-sh@vger.kernel.org, linux-xtensa@linux-xtensa.org,
	linuxppc-dev@lists.ozlabs.org, openrisc@lists.librecores.org,
	sparclinux@vger.kernel.org,
	uclinux-h8-devel@lists.sourceforge.jp, x86@kernel.org
Subject: [PATCH 04/15] arm64: numa: simplify dummy_numa_init()
Date: Tue, 28 Jul 2020 08:11:42 +0300	[thread overview]
Message-ID: <20200728051153.1590-5-rppt@kernel.org> (raw)
In-Reply-To: <20200728051153.1590-1-rppt@kernel.org>

From: Mike Rapoport <rppt@linux.ibm.com>

dummy_numa_init() loops over memblock.memory and passes nid=0 to
numa_add_memblk() which essentially wraps memblock_set_node(). However,
memblock_set_node() can cope with entire memory span itself, so the loop
over memblock.memory regions is redundant.

Replace the loop with a single call to memblock_set_node() to the entire
memory.

Signed-off-by: Mike Rapoport <rppt@linux.ibm.com>
---
 arch/arm64/mm/numa.c | 13 +++++--------
 1 file changed, 5 insertions(+), 8 deletions(-)

diff --git a/arch/arm64/mm/numa.c b/arch/arm64/mm/numa.c
index aafcee3e3f7e..0cbdbcc885fb 100644
--- a/arch/arm64/mm/numa.c
+++ b/arch/arm64/mm/numa.c
@@ -423,19 +423,16 @@ static int __init numa_init(int (*init_func)(void))
  */
 static int __init dummy_numa_init(void)
 {
+	phys_addr_t start = memblock_start_of_DRAM();
+	phys_addr_t end = memblock_end_of_DRAM();
 	int ret;
-	struct memblock_region *mblk;
 
 	if (numa_off)
 		pr_info("NUMA disabled\n"); /* Forced off on command line. */
-	pr_info("Faking a node at [mem %#018Lx-%#018Lx]\n",
-		memblock_start_of_DRAM(), memblock_end_of_DRAM() - 1);
-
-	for_each_memblock(memory, mblk) {
-		ret = numa_add_memblk(0, mblk->base, mblk->base + mblk->size);
-		if (!ret)
-			continue;
+	pr_info("Faking a node at [mem %#018Lx-%#018Lx]\n", start, end - 1);
 
+	ret = numa_add_memblk(0, start, end);
+	if (ret) {
 		pr_err("NUMA init failed\n");
 		return ret;
 	}
-- 
2.26.2


WARNING: multiple messages have this Message-ID (diff)
From: Mike Rapoport <rppt@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-sh@vger.kernel.org, Peter Zijlstra <peterz@infradead.org>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	linux-mips@vger.kernel.org, Max Filippov <jcmvbkbc@gmail.com>,
	Paul Mackerras <paulus@samba.org>,
	sparclinux@vger.kernel.org, linux-riscv@lists.infradead.org,
	Will Deacon <will@kernel.org>, Stafford Horne <shorne@gmail.com>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	linux-s390@vger.kernel.org, linux-c6x-dev@linux-c6x.org,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Michael Ellerman <mpe@ellerman.id.au>,
	x86@kernel.org, Russell King <linux@armlinux.org.uk>,
	Mike Rapoport <rppt@linux.ibm.com>,
	clang-built-linux@googlegroups.com,
	Ingo Molnar <mingo@redhat.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	uclinux-h8-devel@lists.sourceforge.jp,
	linux-xtensa@linux-xtensa.org, openrisc@lists.librecores.org,
	Borislav Petkov <bp@alien8.de>, Andy Lutomirski <luto@kernel.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	linux-arm-kernel@lists.infradead.org,
	Michal Simek <monstr@monstr.eu>,
	linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org,
	linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Christoph Hellwig <hch@lst.de>, Mike Rapoport <rppt@kernel.org>
Subject: [PATCH 04/15] arm64: numa: simplify dummy_numa_init()
Date: Tue, 28 Jul 2020 08:11:42 +0300	[thread overview]
Message-ID: <20200728051153.1590-5-rppt@kernel.org> (raw)
In-Reply-To: <20200728051153.1590-1-rppt@kernel.org>

From: Mike Rapoport <rppt@linux.ibm.com>

dummy_numa_init() loops over memblock.memory and passes nid=0 to
numa_add_memblk() which essentially wraps memblock_set_node(). However,
memblock_set_node() can cope with entire memory span itself, so the loop
over memblock.memory regions is redundant.

Replace the loop with a single call to memblock_set_node() to the entire
memory.

Signed-off-by: Mike Rapoport <rppt@linux.ibm.com>
---
 arch/arm64/mm/numa.c | 13 +++++--------
 1 file changed, 5 insertions(+), 8 deletions(-)

diff --git a/arch/arm64/mm/numa.c b/arch/arm64/mm/numa.c
index aafcee3e3f7e..0cbdbcc885fb 100644
--- a/arch/arm64/mm/numa.c
+++ b/arch/arm64/mm/numa.c
@@ -423,19 +423,16 @@ static int __init numa_init(int (*init_func)(void))
  */
 static int __init dummy_numa_init(void)
 {
+	phys_addr_t start = memblock_start_of_DRAM();
+	phys_addr_t end = memblock_end_of_DRAM();
 	int ret;
-	struct memblock_region *mblk;
 
 	if (numa_off)
 		pr_info("NUMA disabled\n"); /* Forced off on command line. */
-	pr_info("Faking a node at [mem %#018Lx-%#018Lx]\n",
-		memblock_start_of_DRAM(), memblock_end_of_DRAM() - 1);
-
-	for_each_memblock(memory, mblk) {
-		ret = numa_add_memblk(0, mblk->base, mblk->base + mblk->size);
-		if (!ret)
-			continue;
+	pr_info("Faking a node at [mem %#018Lx-%#018Lx]\n", start, end - 1);
 
+	ret = numa_add_memblk(0, start, end);
+	if (ret) {
 		pr_err("NUMA init failed\n");
 		return ret;
 	}
-- 
2.26.2


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

WARNING: multiple messages have this Message-ID (diff)
From: Mike Rapoport <rppt@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-sh@vger.kernel.org, Peter Zijlstra <peterz@infradead.org>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	linux-mips@vger.kernel.org, Max Filippov <jcmvbkbc@gmail.com>,
	Paul Mackerras <paulus@samba.org>,
	sparclinux@vger.kernel.org, linux-riscv@lists.infradead.org,
	Will Deacon <will@kernel.org>, Stafford Horne <shorne@gmail.com>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	linux-s390@vger.kernel.org, linux-c6x-dev@linux-c6x.org,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	x86@kernel.org, Russell King <linux@armlinux.org.uk>,
	Mike Rapoport <rppt@linux.ibm.com>,
	clang-built-linux@googlegroups.com,
	Ingo Molnar <mingo@redhat.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	uclinux-h8-devel@lists.sourceforge.jp,
	linux-xtensa@linux-xtensa.org, openrisc@lists.librecores.org,
	Borislav Petkov <bp@alien8.de>, Andy Lutomirski <luto@kernel.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	linux-arm-kernel@lists.infradead.org,
	Michal Simek <monstr@monstr.eu>,
	linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org,
	linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Christoph Hellwig <hch@lst.de>, Mike Rapoport <rppt@kernel.org>
Subject: [PATCH 04/15] arm64: numa: simplify dummy_numa_init()
Date: Tue, 28 Jul 2020 08:11:42 +0300	[thread overview]
Message-ID: <20200728051153.1590-5-rppt@kernel.org> (raw)
In-Reply-To: <20200728051153.1590-1-rppt@kernel.org>

From: Mike Rapoport <rppt@linux.ibm.com>

dummy_numa_init() loops over memblock.memory and passes nid=0 to
numa_add_memblk() which essentially wraps memblock_set_node(). However,
memblock_set_node() can cope with entire memory span itself, so the loop
over memblock.memory regions is redundant.

Replace the loop with a single call to memblock_set_node() to the entire
memory.

Signed-off-by: Mike Rapoport <rppt@linux.ibm.com>
---
 arch/arm64/mm/numa.c | 13 +++++--------
 1 file changed, 5 insertions(+), 8 deletions(-)

diff --git a/arch/arm64/mm/numa.c b/arch/arm64/mm/numa.c
index aafcee3e3f7e..0cbdbcc885fb 100644
--- a/arch/arm64/mm/numa.c
+++ b/arch/arm64/mm/numa.c
@@ -423,19 +423,16 @@ static int __init numa_init(int (*init_func)(void))
  */
 static int __init dummy_numa_init(void)
 {
+	phys_addr_t start = memblock_start_of_DRAM();
+	phys_addr_t end = memblock_end_of_DRAM();
 	int ret;
-	struct memblock_region *mblk;
 
 	if (numa_off)
 		pr_info("NUMA disabled\n"); /* Forced off on command line. */
-	pr_info("Faking a node at [mem %#018Lx-%#018Lx]\n",
-		memblock_start_of_DRAM(), memblock_end_of_DRAM() - 1);
-
-	for_each_memblock(memory, mblk) {
-		ret = numa_add_memblk(0, mblk->base, mblk->base + mblk->size);
-		if (!ret)
-			continue;
+	pr_info("Faking a node at [mem %#018Lx-%#018Lx]\n", start, end - 1);
 
+	ret = numa_add_memblk(0, start, end);
+	if (ret) {
 		pr_err("NUMA init failed\n");
 		return ret;
 	}
-- 
2.26.2


WARNING: multiple messages have this Message-ID (diff)
From: Mike Rapoport <rppt@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-sh@vger.kernel.org, Peter Zijlstra <peterz@infradead.org>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	linux-mips@vger.kernel.org, Max Filippov <jcmvbkbc@gmail.com>,
	Paul Mackerras <paulus@samba.org>,
	sparclinux@vger.kernel.org, linux-riscv@lists.infradead.org,
	Will Deacon <will@kernel.org>, Stafford Horne <shorne@gmail.com>,
	linux-s390@vger.kernel.org, linux-c6x-dev@linux-c6x.org,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Michael Ellerman <mpe@ellerman.id.au>,
	x86@kernel.org, Russell King <linux@armlinux.org.uk>,
	Mike Rapoport <rppt@linux.ibm.com>,
	clang-built-linux@googlegroups.com,
	Ingo Molnar <mingo@redhat.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	uclinux-h8-devel@lists.sourceforge.jp,
	linux-xtensa@linux-xtensa.org, openrisc@lists.librecores.org,
	Borislav Petkov <bp@alien8.de>, Andy Lutomirski <luto@kernel.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	linux-arm-kernel@lists.infradead.org,
	Michal Simek <monstr@monstr.eu>,
	linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org,
	linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Christoph Hellwig <hch@lst.de>, Mike Rapoport <rppt@kernel.org>
Subject: [PATCH 04/15] arm64: numa: simplify dummy_numa_init()
Date: Tue, 28 Jul 2020 08:11:42 +0300	[thread overview]
Message-ID: <20200728051153.1590-5-rppt@kernel.org> (raw)
In-Reply-To: <20200728051153.1590-1-rppt@kernel.org>

From: Mike Rapoport <rppt@linux.ibm.com>

dummy_numa_init() loops over memblock.memory and passes nid=0 to
numa_add_memblk() which essentially wraps memblock_set_node(). However,
memblock_set_node() can cope with entire memory span itself, so the loop
over memblock.memory regions is redundant.

Replace the loop with a single call to memblock_set_node() to the entire
memory.

Signed-off-by: Mike Rapoport <rppt@linux.ibm.com>
---
 arch/arm64/mm/numa.c | 13 +++++--------
 1 file changed, 5 insertions(+), 8 deletions(-)

diff --git a/arch/arm64/mm/numa.c b/arch/arm64/mm/numa.c
index aafcee3e3f7e..0cbdbcc885fb 100644
--- a/arch/arm64/mm/numa.c
+++ b/arch/arm64/mm/numa.c
@@ -423,19 +423,16 @@ static int __init numa_init(int (*init_func)(void))
  */
 static int __init dummy_numa_init(void)
 {
+	phys_addr_t start = memblock_start_of_DRAM();
+	phys_addr_t end = memblock_end_of_DRAM();
 	int ret;
-	struct memblock_region *mblk;
 
 	if (numa_off)
 		pr_info("NUMA disabled\n"); /* Forced off on command line. */
-	pr_info("Faking a node at [mem %#018Lx-%#018Lx]\n",
-		memblock_start_of_DRAM(), memblock_end_of_DRAM() - 1);
-
-	for_each_memblock(memory, mblk) {
-		ret = numa_add_memblk(0, mblk->base, mblk->base + mblk->size);
-		if (!ret)
-			continue;
+	pr_info("Faking a node at [mem %#018Lx-%#018Lx]\n", start, end - 1);
 
+	ret = numa_add_memblk(0, start, end);
+	if (ret) {
 		pr_err("NUMA init failed\n");
 		return ret;
 	}
-- 
2.26.2

_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

WARNING: multiple messages have this Message-ID (diff)
From: Mike Rapoport <rppt@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-sh@vger.kernel.org, Peter Zijlstra <peterz@infradead.org>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	linux-mips@vger.kernel.org, Max Filippov <jcmvbkbc@gmail.com>,
	Paul Mackerras <paulus@samba.org>,
	sparclinux@vger.kernel.org, linux-riscv@lists.infradead.org,
	Will Deacon <will@kernel.org>, Stafford Horne <shorne@gmail.com>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	linux-s390@vger.kernel.org, linux-c6x-dev@linux-c6x.org,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Michael Ellerman <mpe@ellerman.id.au>,
	x86@kernel.org, Russell King <linux@armlinux.org.uk>,
	Mike Rapoport <rppt@linux.ibm.com>,
	clang-built-linux@googlegroups.com,
	Ingo Molnar <mingo@redhat.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	uclinux-h8-devel@lists.sourceforge.jp,
	linux-xtensa@linux-xtensa.org, openrisc@lists.librecores.org,
	Borislav Petkov <bp@alien8.de>, Andy Lutomirski <luto@kernel.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	linux-arm-kernel@lists.infradead.org,
	Michal Simek <monstr@monstr.eu>,
	linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org,
	linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Christoph Hellwig <hch@lst.de>, Mike Rapoport <rppt@kernel.org>
Subject: [PATCH 04/15] arm64: numa: simplify dummy_numa_init()
Date: Tue, 28 Jul 2020 08:11:42 +0300	[thread overview]
Message-ID: <20200728051153.1590-5-rppt@kernel.org> (raw)
In-Reply-To: <20200728051153.1590-1-rppt@kernel.org>

From: Mike Rapoport <rppt@linux.ibm.com>

dummy_numa_init() loops over memblock.memory and passes nid=0 to
numa_add_memblk() which essentially wraps memblock_set_node(). However,
memblock_set_node() can cope with entire memory span itself, so the loop
over memblock.memory regions is redundant.

Replace the loop with a single call to memblock_set_node() to the entire
memory.

Signed-off-by: Mike Rapoport <rppt@linux.ibm.com>
---
 arch/arm64/mm/numa.c | 13 +++++--------
 1 file changed, 5 insertions(+), 8 deletions(-)

diff --git a/arch/arm64/mm/numa.c b/arch/arm64/mm/numa.c
index aafcee3e3f7e..0cbdbcc885fb 100644
--- a/arch/arm64/mm/numa.c
+++ b/arch/arm64/mm/numa.c
@@ -423,19 +423,16 @@ static int __init numa_init(int (*init_func)(void))
  */
 static int __init dummy_numa_init(void)
 {
+	phys_addr_t start = memblock_start_of_DRAM();
+	phys_addr_t end = memblock_end_of_DRAM();
 	int ret;
-	struct memblock_region *mblk;
 
 	if (numa_off)
 		pr_info("NUMA disabled\n"); /* Forced off on command line. */
-	pr_info("Faking a node at [mem %#018Lx-%#018Lx]\n",
-		memblock_start_of_DRAM(), memblock_end_of_DRAM() - 1);
-
-	for_each_memblock(memory, mblk) {
-		ret = numa_add_memblk(0, mblk->base, mblk->base + mblk->size);
-		if (!ret)
-			continue;
+	pr_info("Faking a node at [mem %#018Lx-%#018Lx]\n", start, end - 1);
 
+	ret = numa_add_memblk(0, start, end);
+	if (ret) {
 		pr_err("NUMA init failed\n");
 		return ret;
 	}
-- 
2.26.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Mike Rapoport <rppt@kernel.org>
To: openrisc@lists.librecores.org
Subject: [OpenRISC] [PATCH 04/15] arm64: numa: simplify dummy_numa_init()
Date: Tue, 28 Jul 2020 05:12:54 -0000	[thread overview]
Message-ID: <20200728051153.1590-5-rppt@kernel.org> (raw)
In-Reply-To: <20200728051153.1590-1-rppt@kernel.org>

From: Mike Rapoport <rppt@linux.ibm.com>

dummy_numa_init() loops over memblock.memory and passes nid=0 to
numa_add_memblk() which essentially wraps memblock_set_node(). However,
memblock_set_node() can cope with entire memory span itself, so the loop
over memblock.memory regions is redundant.

Replace the loop with a single call to memblock_set_node() to the entire
memory.

Signed-off-by: Mike Rapoport <rppt@linux.ibm.com>
---
 arch/arm64/mm/numa.c | 13 +++++--------
 1 file changed, 5 insertions(+), 8 deletions(-)

diff --git a/arch/arm64/mm/numa.c b/arch/arm64/mm/numa.c
index aafcee3e3f7e..0cbdbcc885fb 100644
--- a/arch/arm64/mm/numa.c
+++ b/arch/arm64/mm/numa.c
@@ -423,19 +423,16 @@ static int __init numa_init(int (*init_func)(void))
  */
 static int __init dummy_numa_init(void)
 {
+	phys_addr_t start = memblock_start_of_DRAM();
+	phys_addr_t end = memblock_end_of_DRAM();
 	int ret;
-	struct memblock_region *mblk;
 
 	if (numa_off)
 		pr_info("NUMA disabled\n"); /* Forced off on command line. */
-	pr_info("Faking a node at [mem %#018Lx-%#018Lx]\n",
-		memblock_start_of_DRAM(), memblock_end_of_DRAM() - 1);
-
-	for_each_memblock(memory, mblk) {
-		ret = numa_add_memblk(0, mblk->base, mblk->base + mblk->size);
-		if (!ret)
-			continue;
+	pr_info("Faking a node at [mem %#018Lx-%#018Lx]\n", start, end - 1);
 
+	ret = numa_add_memblk(0, start, end);
+	if (ret) {
 		pr_err("NUMA init failed\n");
 		return ret;
 	}
-- 
2.26.2


  parent reply	other threads:[~2020-07-28  5:11 UTC|newest]

Thread overview: 247+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-28  5:11 [PATCH 00/15] memblock: seasonal cleaning^w cleanup Mike Rapoport
2020-07-28  5:12 ` [OpenRISC] " Mike Rapoport
2020-07-28  5:11 ` Mike Rapoport
2020-07-28  5:11 ` Mike Rapoport
2020-07-28  5:11 ` Mike Rapoport
2020-07-28  5:11 ` Mike Rapoport
2020-07-28  5:11 ` Mike Rapoport
2020-07-28  5:11 ` [PATCH 01/15] KVM: PPC: Book3S HV: simplify kvm_cma_reserve() Mike Rapoport
2020-07-28  5:12   ` [OpenRISC] " Mike Rapoport
2020-07-28  5:11   ` Mike Rapoport
2020-07-28  5:11   ` Mike Rapoport
2020-07-28  5:11   ` Mike Rapoport
2020-07-28  5:11   ` Mike Rapoport
2020-07-28  5:11   ` Mike Rapoport
2020-07-28  5:11 ` [PATCH 02/15] dma-contiguous: simplify cma_early_percent_memory() Mike Rapoport
2020-07-28  5:12   ` [OpenRISC] " Mike Rapoport
2020-07-28  5:11   ` Mike Rapoport
2020-07-28  5:11   ` Mike Rapoport
2020-07-28  5:11   ` Mike Rapoport
2020-07-28  5:11   ` Mike Rapoport
2020-07-28  5:11   ` Mike Rapoport
2020-07-28  6:37   ` Christoph Hellwig
2020-07-28  6:37     ` [OpenRISC] " Christoph Hellwig
2020-07-28  6:37     ` Christoph Hellwig
2020-07-28  6:37     ` Christoph Hellwig
2020-07-28  6:37     ` Christoph Hellwig
2020-07-28  6:37     ` Christoph Hellwig
2020-07-28  6:37     ` Christoph Hellwig
2020-07-28  5:11 ` [PATCH 03/15] arm, xtensa: simplify initialization of high memory pages Mike Rapoport
2020-07-28  5:12   ` [OpenRISC] " Mike Rapoport
2020-07-28  5:11   ` Mike Rapoport
2020-07-28  5:11   ` Mike Rapoport
2020-07-28  5:11   ` Mike Rapoport
2020-07-28  5:11   ` Mike Rapoport
2020-07-28  5:11   ` Mike Rapoport
2020-07-28  8:09   ` Max Filippov
2020-07-28  8:09     ` [OpenRISC] " Max Filippov
2020-07-28  8:09     ` Max Filippov
2020-07-28  8:09     ` Max Filippov
2020-07-28  8:09     ` Max Filippov
2020-07-28  8:09     ` Max Filippov
2020-07-28  8:09     ` Max Filippov
2020-07-28  8:09     ` Max Filippov
2020-07-28  8:09     ` Max Filippov
2020-07-28  5:11 ` Mike Rapoport [this message]
2020-07-28  5:12   ` [OpenRISC] [PATCH 04/15] arm64: numa: simplify dummy_numa_init() Mike Rapoport
2020-07-28  5:11   ` Mike Rapoport
2020-07-28  5:11   ` Mike Rapoport
2020-07-28  5:11   ` Mike Rapoport
2020-07-28  5:11   ` Mike Rapoport
2020-07-28  5:11   ` Mike Rapoport
2020-07-29  8:30   ` Jonathan Cameron
2020-07-29  8:31     ` [OpenRISC] " Jonathan Cameron
2020-07-29  8:30     ` Jonathan Cameron
2020-07-29  8:30     ` Jonathan Cameron
2020-07-29  8:30     ` Jonathan Cameron
2020-07-29  8:30     ` Jonathan Cameron
2020-07-29  8:30     ` Jonathan Cameron
2020-07-29  8:30     ` Jonathan Cameron
2020-07-30 12:03   ` Catalin Marinas
2020-07-30 12:04     ` [OpenRISC] " Catalin Marinas
2020-07-30 12:03     ` Catalin Marinas
2020-07-30 12:03     ` Catalin Marinas
2020-07-30 12:03     ` Catalin Marinas
2020-07-30 12:03     ` Catalin Marinas
2020-07-30 12:03     ` Catalin Marinas
2020-07-28  5:11 ` [PATCH 05/15] h8300, nds32, openrisc: simplify detection of memory extents Mike Rapoport
2020-07-28  5:13   ` [OpenRISC] " Mike Rapoport
2020-07-28  5:11   ` Mike Rapoport
2020-07-28  5:11   ` Mike Rapoport
2020-07-28  5:11   ` Mike Rapoport
2020-07-28  5:11   ` Mike Rapoport
2020-07-28  5:11   ` Mike Rapoport
2020-07-29 11:41   ` Stafford Horne
2020-07-29 11:42     ` [OpenRISC] " Stafford Horne
2020-07-29 11:41     ` Stafford Horne
2020-07-29 11:41     ` Stafford Horne
2020-07-29 11:41     ` Stafford Horne
2020-07-29 11:41     ` Stafford Horne
2020-07-29 11:41     ` Stafford Horne
2020-07-28  5:11 ` [PATCH 06/15] powerpc: fadamp: simplify fadump_reserve_crash_area() Mike Rapoport
2020-07-28  5:13   ` [OpenRISC] " Mike Rapoport
2020-07-28  5:11   ` Mike Rapoport
2020-07-28  5:11   ` Mike Rapoport
2020-07-28  5:11   ` Mike Rapoport
2020-07-28  5:11   ` Mike Rapoport
2020-07-28  5:11   ` Mike Rapoport
2020-07-30 12:15   ` Michael Ellerman
2020-07-30 12:15     ` [OpenRISC] " Michael Ellerman
2020-07-30 12:15     ` Michael Ellerman
2020-07-30 12:15     ` Michael Ellerman
2020-07-30 12:15     ` Michael Ellerman
2020-07-30 12:15     ` Michael Ellerman
2020-07-30 12:15     ` Michael Ellerman
2020-07-30 12:15     ` Michael Ellerman
2020-08-01 10:18     ` Mike Rapoport
2020-08-01 10:19       ` [OpenRISC] " Mike Rapoport
2020-08-01 10:18       ` Mike Rapoport
2020-08-01 10:18       ` Mike Rapoport
2020-08-01 10:18       ` Mike Rapoport
2020-08-01 10:18       ` Mike Rapoport
2020-08-01 10:18       ` Mike Rapoport
2020-08-01 10:53       ` Hari Bathini
2020-08-01 10:55         ` Hari Bathini
2020-08-01 10:54         ` [OpenRISC] " Hari Bathini
2020-08-01 10:53         ` Hari Bathini
2020-08-01 10:53         ` Hari Bathini
2020-08-01 10:53         ` Hari Bathini
2020-08-01 10:53         ` Hari Bathini
2020-08-02 13:14       ` Michael Ellerman
2020-08-02 13:14         ` [OpenRISC] " Michael Ellerman
2020-08-02 13:14         ` Michael Ellerman
2020-08-02 13:14         ` Michael Ellerman
2020-08-02 13:14         ` Michael Ellerman
2020-08-02 13:14         ` Michael Ellerman
2020-08-02 13:14         ` Michael Ellerman
2020-07-28  5:11 ` [PATCH 07/15] riscv: drop unneeded node initialization Mike Rapoport
2020-07-28  5:13   ` [OpenRISC] " Mike Rapoport
2020-07-28  5:11   ` Mike Rapoport
2020-07-28  5:11   ` Mike Rapoport
2020-07-28  5:11   ` Mike Rapoport
2020-07-28  5:11   ` Mike Rapoport
2020-07-28  5:11   ` Mike Rapoport
2020-07-28  5:11 ` [PATCH 08/15] mircoblaze: drop unneeded NUMA and sparsemem initializations Mike Rapoport
2020-07-28  5:13   ` [OpenRISC] " Mike Rapoport
2020-07-28  5:11   ` Mike Rapoport
2020-07-28  5:11   ` Mike Rapoport
2020-07-28  5:11   ` Mike Rapoport
2020-07-28  5:11   ` Mike Rapoport
2020-07-28  5:11   ` Mike Rapoport
2020-07-28  5:11 ` [PATCH 09/15] memblock: make for_each_memblock_type() iterator private Mike Rapoport
2020-07-28  5:13   ` [OpenRISC] " Mike Rapoport
2020-07-28  5:11   ` Mike Rapoport
2020-07-28  5:11   ` Mike Rapoport
2020-07-28  5:11   ` Mike Rapoport
2020-07-28  5:11   ` Mike Rapoport
2020-07-28  5:11   ` Mike Rapoport
2020-07-30  1:52   ` Baoquan He
2020-07-30  1:52     ` [OpenRISC] " Baoquan He
2020-07-30  1:52     ` Baoquan He
2020-07-30  1:52     ` Baoquan He
2020-07-30  1:52     ` Baoquan He
2020-07-30  1:52     ` Baoquan He
2020-07-30  1:52     ` Baoquan He
2020-07-28  5:11 ` [PATCH 10/15] memblock: make memblock_debug and related functionality private Mike Rapoport
2020-07-28  5:13   ` [OpenRISC] " Mike Rapoport
2020-07-28  5:11   ` Mike Rapoport
2020-07-28  5:11   ` Mike Rapoport
2020-07-28  5:11   ` Mike Rapoport
2020-07-28  5:11   ` Mike Rapoport
2020-07-28  5:11   ` Mike Rapoport
2020-07-30  1:54   ` Baoquan He
2020-07-30  1:54     ` [OpenRISC] " Baoquan He
2020-07-30  1:54     ` Baoquan He
2020-07-30  1:54     ` Baoquan He
2020-07-30  1:54     ` Baoquan He
2020-07-30  1:54     ` Baoquan He
2020-07-30  1:54     ` Baoquan He
2020-07-28  5:11 ` [PATCH 11/15] memblock: reduce number of parameters in for_each_mem_range() Mike Rapoport
2020-07-28  5:14   ` [OpenRISC] " Mike Rapoport
2020-07-28  5:11   ` Mike Rapoport
2020-07-28  5:11   ` Mike Rapoport
2020-07-28  5:11   ` Mike Rapoport
2020-07-28  5:11   ` Mike Rapoport
2020-07-28  5:11   ` Mike Rapoport
2020-07-30  2:22   ` Baoquan He
2020-07-30  2:22     ` [OpenRISC] " Baoquan He
2020-07-30  2:22     ` Baoquan He
2020-07-30  2:22     ` Baoquan He
2020-07-30  2:22     ` Baoquan He
2020-07-30  2:22     ` Baoquan He
2020-07-30  2:22     ` Baoquan He
2020-07-28  5:11 ` [PATCH 12/15] arch, mm: replace for_each_memblock() with for_each_mem_pfn_range() Mike Rapoport
2020-07-28  5:14   ` [OpenRISC] " Mike Rapoport
2020-07-28  5:11   ` Mike Rapoport
2020-07-28  5:11   ` Mike Rapoport
2020-07-28  5:11   ` Mike Rapoport
2020-07-28  5:11   ` Mike Rapoport
2020-07-28  5:11   ` Mike Rapoport
2020-07-28  5:11 ` [PATCH 13/15] arch, drivers: replace for_each_membock() with for_each_mem_range() Mike Rapoport
2020-07-28  5:14   ` [OpenRISC] " Mike Rapoport
2020-07-28  5:11   ` Mike Rapoport
2020-07-28  5:11   ` Mike Rapoport
2020-07-28  5:11   ` Mike Rapoport
2020-07-28  5:11   ` Mike Rapoport
2020-07-28  5:11   ` Mike Rapoport
2020-07-28 15:02   ` Emil Renner Berthing
2020-07-28 15:03     ` [OpenRISC] " Emil Renner Berthing
2020-07-28 15:02     ` Emil Renner Berthing
2020-07-28 15:02     ` Emil Renner Berthing
2020-07-28 15:26   ` kernel test robot
2020-07-28  5:11 ` [PATCH 14/15] x86/numa: remove redundant iteration over memblock.reserved Mike Rapoport
2020-07-28  5:14   ` [OpenRISC] " Mike Rapoport
2020-07-28  5:11   ` Mike Rapoport
2020-07-28  5:11   ` Mike Rapoport
2020-07-28  5:11   ` Mike Rapoport
2020-07-28  5:11   ` Mike Rapoport
2020-07-28  5:11   ` Mike Rapoport
2020-07-28 10:44   ` Ingo Molnar
2020-07-28 10:44     ` [OpenRISC] " Ingo Molnar
2020-07-28 10:44     ` Ingo Molnar
2020-07-28 10:44     ` Ingo Molnar
2020-07-28 10:44     ` Ingo Molnar
2020-07-28 10:44     ` Ingo Molnar
2020-07-28 10:44     ` Ingo Molnar
2020-07-28 10:56     ` Mike Rapoport
2020-07-28 10:56       ` [OpenRISC] " Mike Rapoport
2020-07-28 10:56       ` Mike Rapoport
2020-07-28 10:56       ` Mike Rapoport
2020-07-28 10:56       ` Mike Rapoport
2020-07-28 10:56       ` Mike Rapoport
2020-07-28 10:56       ` Mike Rapoport
2020-07-28 11:31       ` Ingo Molnar
2020-07-28 11:31         ` [OpenRISC] " Ingo Molnar
2020-07-28 11:31         ` Ingo Molnar
2020-07-28 11:31         ` Ingo Molnar
2020-07-28 11:31         ` Ingo Molnar
2020-07-28 11:31         ` Ingo Molnar
2020-07-28 11:31         ` Ingo Molnar
2020-07-28 11:02   ` Baoquan He
2020-07-28 11:03     ` [OpenRISC] " Baoquan He
2020-07-28 11:02     ` Baoquan He
2020-07-28 11:02     ` Baoquan He
2020-07-28 11:02     ` Baoquan He
2020-07-28 11:02     ` Baoquan He
2020-07-28 11:02     ` Baoquan He
2020-07-28 14:15     ` Mike Rapoport
2020-07-28 14:15       ` [OpenRISC] " Mike Rapoport
2020-07-28 14:15       ` Mike Rapoport
2020-07-28 14:15       ` Mike Rapoport
2020-07-28 14:15       ` Mike Rapoport
2020-07-28 14:15       ` Mike Rapoport
2020-07-28 14:15       ` Mike Rapoport
2020-07-28 14:23       ` Baoquan He
2020-07-28 14:24         ` [OpenRISC] " Baoquan He
2020-07-28 14:23         ` Baoquan He
2020-07-28 14:23         ` Baoquan He
2020-07-28 14:23         ` Baoquan He
2020-07-28 14:23         ` Baoquan He
2020-07-28 14:23         ` Baoquan He
2020-07-28  5:11 ` [PATCH 15/15] memblock: remove 'type' parameter from for_each_memblock() Mike Rapoport
2020-07-28  5:14   ` [OpenRISC] " Mike Rapoport
2020-07-28  5:11   ` Mike Rapoport
2020-07-28  5:11   ` Mike Rapoport
2020-07-28  5:11   ` Mike Rapoport
2020-07-28  5:11   ` Mike Rapoport
2020-07-28  5:11   ` Mike Rapoport

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200728051153.1590-5-rppt@kernel.org \
    --to=rppt@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=benh@kernel.crashing.org \
    --cc=bp@alien8.de \
    --cc=catalin.marinas@arm.com \
    --cc=clang-built-linux@googlegroups.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=hch@lst.de \
    --cc=iommu@lists.linux-foundation.org \
    --cc=jcmvbkbc@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-c6x-dev@linux-c6x.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=linux-xtensa@linux-xtensa.org \
    --cc=linux@armlinux.org.uk \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=luto@kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=mingo@redhat.com \
    --cc=monstr@monstr.eu \
    --cc=mpe@ellerman.id.au \
    --cc=openrisc@lists.librecores.org \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=paulus@samba.org \
    --cc=peterz@infradead.org \
    --cc=rppt@linux.ibm.com \
    --cc=shorne@gmail.com \
    --cc=sparclinux@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=uclinux-h8-devel@lists.sourceforge.jp \
    --cc=will@kernel.org \
    --cc=x86@kernel.org \
    --cc=ysato@users.sourceforge.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.