From: fam@euphon.net
To: xen-devel@lists.xenproject.org
Cc: fam@euphon.net, "Wei Liu" <wl@xen.org>,
"Andrew Cooper" <andrew.cooper3@citrix.com>,
"Jan Beulich" <jbeulich@suse.com>,
famzheng@amazon.com, "Roger Pau Monné" <roger.pau@citrix.com>
Subject: [PATCH] x86/cpuid: Fix APIC bit clearing
Date: Wed, 29 Jul 2020 17:33:41 +0100 [thread overview]
Message-ID: <20200729163341.5662-1-fam@euphon.net> (raw)
From: Fam Zheng <famzheng@amazon.com>
The bug is obvious here, other places in this function used
"cpufeat_mask" correctly.
Signed-off-by: Fam Zheng <famzheng@amazon.com>
Fixes: 46df8a65 ("x86/cpuid: Effectively remove pv_cpuid() and hvm_cpuid()")
---
xen/arch/x86/cpuid.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/arch/x86/cpuid.c b/xen/arch/x86/cpuid.c
index 6a4a787b68..63a03ef1e5 100644
--- a/xen/arch/x86/cpuid.c
+++ b/xen/arch/x86/cpuid.c
@@ -1057,7 +1057,7 @@ void guest_cpuid(const struct vcpu *v, uint32_t leaf,
{
/* Fast-forward MSR_APIC_BASE.EN. */
if ( vlapic_hw_disabled(vcpu_vlapic(v)) )
- res->d &= ~cpufeat_bit(X86_FEATURE_APIC);
+ res->d &= ~cpufeat_mask(X86_FEATURE_APIC);
/*
* PSE36 is not supported in shadow mode. This bit should be
--
2.17.1
next reply other threads:[~2020-07-30 4:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-29 16:33 fam [this message]
2020-07-29 17:12 ` [PATCH] x86/cpuid: Fix APIC bit clearing Roger Pau Monné
2020-07-29 18:04 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200729163341.5662-1-fam@euphon.net \
--to=fam@euphon.net \
--cc=andrew.cooper3@citrix.com \
--cc=famzheng@amazon.com \
--cc=jbeulich@suse.com \
--cc=roger.pau@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.