All of lore.kernel.org
 help / color / mirror / Atom feed
From: Xia Jiang <xia.jiang@mediatek.com>
To: Hans Verkuil <hverkuil-cisco@xs4all.nl>,
	Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Rick Chang <rick.chang@mediatek.com>
Cc: <linux-media@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-mediatek@lists.infradead.org>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Tomasz Figa <tfiga@chromium.org>, <srv_heupstream@mediatek.com>,
	<senozhatsky@chromium.org>, <mojahsu@chromium.org>,
	<drinkcat@chromium.org>, <maoguang.meng@mediatek.com>,
	Xia Jiang <xia.jiang@mediatek.com>
Subject: [PATCH v11 03/28] media: platform: Improve getting and requesting irq flow for bug fixing
Date: Tue, 4 Aug 2020 11:40:37 +0800	[thread overview]
Message-ID: <20200804034102.22983-4-xia.jiang@mediatek.com> (raw)
In-Reply-To: <20200804034102.22983-1-xia.jiang@mediatek.com>

Delete platform_get_resource operation for irq.
Return actual value rather than EINVAL when fail to get and request
irq.

Reviewed-by: Tomasz Figa <tfiga@chromium.org>
Signed-off-by: Xia Jiang <xia.jiang@mediatek.com>
---
v11: no changes
---
 drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
index 67a022d04df7..2677580941b0 100644
--- a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
+++ b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
@@ -1103,12 +1103,10 @@ static int mtk_jpeg_probe(struct platform_device *pdev)
 		return ret;
 	}
 
-	res = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
 	dec_irq = platform_get_irq(pdev, 0);
-	if (!res || dec_irq < 0) {
+	if (dec_irq < 0) {
 		dev_err(&pdev->dev, "Failed to get dec_irq %d.\n", dec_irq);
-		ret = -EINVAL;
-		return ret;
+		return dec_irq;
 	}
 
 	ret = devm_request_irq(&pdev->dev, dec_irq, mtk_jpeg_dec_irq, 0,
@@ -1116,7 +1114,6 @@ static int mtk_jpeg_probe(struct platform_device *pdev)
 	if (ret) {
 		dev_err(&pdev->dev, "Failed to request dec_irq %d (%d)\n",
 			dec_irq, ret);
-		ret = -EINVAL;
 		goto err_req_irq;
 	}
 
-- 
2.18.0

WARNING: multiple messages have this Message-ID (diff)
From: Xia Jiang <xia.jiang@mediatek.com>
To: Hans Verkuil <hverkuil-cisco@xs4all.nl>,
	Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	"Matthias Brugger" <matthias.bgg@gmail.com>,
	Rick Chang <rick.chang@mediatek.com>
Cc: maoguang.meng@mediatek.com, devicetree@vger.kernel.org,
	mojahsu@chromium.org, srv_heupstream@mediatek.com,
	linux-kernel@vger.kernel.org, Tomasz Figa <tfiga@chromium.org>,
	senozhatsky@chromium.org, drinkcat@chromium.org,
	linux-mediatek@lists.infradead.org,
	Xia Jiang <xia.jiang@mediatek.com>,
	linux-media@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Marek Szyprowski <m.szyprowski@samsung.com>
Subject: [PATCH v11 03/28] media: platform: Improve getting and requesting irq flow for bug fixing
Date: Tue, 4 Aug 2020 11:40:37 +0800	[thread overview]
Message-ID: <20200804034102.22983-4-xia.jiang@mediatek.com> (raw)
In-Reply-To: <20200804034102.22983-1-xia.jiang@mediatek.com>

Delete platform_get_resource operation for irq.
Return actual value rather than EINVAL when fail to get and request
irq.

Reviewed-by: Tomasz Figa <tfiga@chromium.org>
Signed-off-by: Xia Jiang <xia.jiang@mediatek.com>
---
v11: no changes
---
 drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
index 67a022d04df7..2677580941b0 100644
--- a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
+++ b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
@@ -1103,12 +1103,10 @@ static int mtk_jpeg_probe(struct platform_device *pdev)
 		return ret;
 	}
 
-	res = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
 	dec_irq = platform_get_irq(pdev, 0);
-	if (!res || dec_irq < 0) {
+	if (dec_irq < 0) {
 		dev_err(&pdev->dev, "Failed to get dec_irq %d.\n", dec_irq);
-		ret = -EINVAL;
-		return ret;
+		return dec_irq;
 	}
 
 	ret = devm_request_irq(&pdev->dev, dec_irq, mtk_jpeg_dec_irq, 0,
@@ -1116,7 +1114,6 @@ static int mtk_jpeg_probe(struct platform_device *pdev)
 	if (ret) {
 		dev_err(&pdev->dev, "Failed to request dec_irq %d (%d)\n",
 			dec_irq, ret);
-		ret = -EINVAL;
 		goto err_req_irq;
 	}
 
-- 
2.18.0
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

WARNING: multiple messages have this Message-ID (diff)
From: Xia Jiang <xia.jiang@mediatek.com>
To: Hans Verkuil <hverkuil-cisco@xs4all.nl>,
	Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	"Matthias Brugger" <matthias.bgg@gmail.com>,
	Rick Chang <rick.chang@mediatek.com>
Cc: maoguang.meng@mediatek.com, devicetree@vger.kernel.org,
	mojahsu@chromium.org, srv_heupstream@mediatek.com,
	linux-kernel@vger.kernel.org, Tomasz Figa <tfiga@chromium.org>,
	senozhatsky@chromium.org, drinkcat@chromium.org,
	linux-mediatek@lists.infradead.org,
	Xia Jiang <xia.jiang@mediatek.com>,
	linux-media@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Marek Szyprowski <m.szyprowski@samsung.com>
Subject: [PATCH v11 03/28] media: platform: Improve getting and requesting irq flow for bug fixing
Date: Tue, 4 Aug 2020 11:40:37 +0800	[thread overview]
Message-ID: <20200804034102.22983-4-xia.jiang@mediatek.com> (raw)
In-Reply-To: <20200804034102.22983-1-xia.jiang@mediatek.com>

Delete platform_get_resource operation for irq.
Return actual value rather than EINVAL when fail to get and request
irq.

Reviewed-by: Tomasz Figa <tfiga@chromium.org>
Signed-off-by: Xia Jiang <xia.jiang@mediatek.com>
---
v11: no changes
---
 drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
index 67a022d04df7..2677580941b0 100644
--- a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
+++ b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
@@ -1103,12 +1103,10 @@ static int mtk_jpeg_probe(struct platform_device *pdev)
 		return ret;
 	}
 
-	res = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
 	dec_irq = platform_get_irq(pdev, 0);
-	if (!res || dec_irq < 0) {
+	if (dec_irq < 0) {
 		dev_err(&pdev->dev, "Failed to get dec_irq %d.\n", dec_irq);
-		ret = -EINVAL;
-		return ret;
+		return dec_irq;
 	}
 
 	ret = devm_request_irq(&pdev->dev, dec_irq, mtk_jpeg_dec_irq, 0,
@@ -1116,7 +1114,6 @@ static int mtk_jpeg_probe(struct platform_device *pdev)
 	if (ret) {
 		dev_err(&pdev->dev, "Failed to request dec_irq %d (%d)\n",
 			dec_irq, ret);
-		ret = -EINVAL;
 		goto err_req_irq;
 	}
 
-- 
2.18.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2020-08-04  3:43 UTC|newest]

Thread overview: 93+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-04  3:40 [PATCH v11 00/28] Add support for mt2701 JPEG ENC support Xia Jiang
2020-08-04  3:40 ` Xia Jiang
2020-08-04  3:40 ` Xia Jiang
2020-08-04  3:40 ` [PATCH v11 01/28] media: platform: Improve subscribe event flow for bug fixing Xia Jiang
2020-08-04  3:40   ` Xia Jiang
2020-08-04  3:40   ` Xia Jiang
2020-08-04  3:40 ` [PATCH v11 02/28] media: platform: Improve queue set up " Xia Jiang
2020-08-04  3:40   ` Xia Jiang
2020-08-04  3:40   ` Xia Jiang
2020-08-04  3:40 ` Xia Jiang [this message]
2020-08-04  3:40   ` [PATCH v11 03/28] media: platform: Improve getting and requesting irq " Xia Jiang
2020-08-04  3:40   ` Xia Jiang
2020-08-04  3:40 ` [PATCH v11 04/28] media: platform: Change the fixed device node number to unfixed value Xia Jiang
2020-08-04  3:40   ` Xia Jiang
2020-08-04  3:40   ` Xia Jiang
2020-08-04  3:40 ` [PATCH v11 05/28] media: platform: Improve power on and power off flow Xia Jiang
2020-08-04  3:40   ` Xia Jiang
2020-08-04  3:40   ` Xia Jiang
2020-08-04  3:40 ` [PATCH v11 06/28] media: platform: Delete the resetting hardware flow in the system PM ops Xia Jiang
2020-08-04  3:40   ` Xia Jiang
2020-08-04  3:40   ` Xia Jiang
2020-08-04  3:40 ` [PATCH v11 07/28] media: platform: Improve the implementation of " Xia Jiang
2020-08-04  3:40   ` Xia Jiang
2020-08-04  3:40   ` Xia Jiang
2020-08-04  3:40 ` [PATCH v11 08/28] media: platform: Add mechanism to handle jpeg hardware's locking up Xia Jiang
2020-08-04  3:40   ` Xia Jiang
2020-08-04  3:40   ` Xia Jiang
2020-08-04  3:40 ` [PATCH v11 09/28] media: platform: Cancel the last frame handling flow Xia Jiang
2020-08-04  3:40   ` Xia Jiang
2020-08-04  3:40   ` Xia Jiang
2020-08-04  3:40 ` [PATCH v11 10/28] media: platform: Delete zeroing the reserved fields Xia Jiang
2020-08-04  3:40   ` Xia Jiang
2020-08-04  3:40   ` Xia Jiang
2020-08-04  3:40 ` [PATCH v11 11/28] media: platform: Stylistic changes for improving code quality Xia Jiang
2020-08-04  3:40   ` Xia Jiang
2020-08-04  3:40   ` Xia Jiang
2020-08-04  3:40 ` [PATCH v11 12/28] media: platform: Use generic rounding helpers Xia Jiang
2020-08-04  3:40   ` Xia Jiang
2020-08-04  3:40   ` Xia Jiang
2020-08-04  3:40 ` [PATCH v11 13/28] media: platform: Change MTK_JPEG_COMP_MAX macro definition location Xia Jiang
2020-08-04  3:40   ` Xia Jiang
2020-08-04  3:40   ` Xia Jiang
2020-08-04  3:40 ` [PATCH v11 14/28] media: platform: Delete redundant code and add annotation for an enum Xia Jiang
2020-08-04  3:40   ` Xia Jiang
2020-08-04  3:40   ` Xia Jiang
2020-08-04  3:40 ` [PATCH v11 15/28] media: platform: Delete vidioc_s_selection ioctl of jpeg dec Xia Jiang
2020-08-04  3:40   ` Xia Jiang
2020-08-04  3:40   ` Xia Jiang
2020-08-04  3:40 ` [PATCH v11 16/28] media: platform: Change the maximum width and height supported by JPEG dec Xia Jiang
2020-08-04  3:40   ` Xia Jiang
2020-08-04  3:40   ` Xia Jiang
2020-08-04  3:40 ` [PATCH v11 17/28] media: platform: Refactor mtk_jpeg_try_fmt_mplane() Xia Jiang
2020-08-04  3:40   ` Xia Jiang
2020-08-04  3:40   ` Xia Jiang
2020-08-04  3:40 ` [PATCH v11 18/28] media: platform: Refactor mtk_jpeg_find_format() Xia Jiang
2020-08-04  3:40   ` Xia Jiang
2020-08-04  3:40   ` Xia Jiang
2020-08-04  3:40 ` [PATCH v11 19/28] media: platform: Redefinition of mtk_jpeg_q_data structure Xia Jiang
2020-08-04  3:40   ` Xia Jiang
2020-08-04  3:40   ` Xia Jiang
2020-08-04  3:40 ` [PATCH v11 20/28] media: platform: Change the colorspace of jpeg to the fixed value Xia Jiang
2020-08-04  3:40   ` Xia Jiang
2020-08-04  3:40   ` Xia Jiang
2020-08-04  3:40 ` [PATCH v11 21/28] media: platform: Refactor mtk_jpeg_set_default_params() Xia Jiang
2020-08-04  3:40   ` Xia Jiang
2020-08-04  3:40   ` Xia Jiang
2020-08-04  3:40 ` [PATCH v11 22/28] media: platform: Change the call functions of getting/enable/disable the jpeg's clock Xia Jiang
2020-08-04  3:40   ` Xia Jiang
2020-08-04  3:40   ` Xia Jiang
2020-08-05 13:55   ` Tomasz Figa
2020-08-05 13:55     ` Tomasz Figa
2020-08-05 13:55     ` Tomasz Figa
2020-08-04  3:40 ` [PATCH v11 23/28] media: dt-bindings: Add jpeg enc device tree node document Xia Jiang
2020-08-04  3:40   ` Xia Jiang
2020-08-04  3:40   ` Xia Jiang
2020-08-04  3:40 ` [PATCH v11 24/28] arm: dts: mt2701: Add jpeg enc device tree node Xia Jiang
2020-08-04  3:40   ` Xia Jiang
2020-08-04  3:40   ` Xia Jiang
2020-08-04  3:40 ` [PATCH v11 25/28] media: platform: Rename jpeg dec file name Xia Jiang
2020-08-04  3:40   ` Xia Jiang
2020-08-04  3:40   ` Xia Jiang
2020-08-04  3:41 ` [PATCH v11 26/28] media: platform: Rename existing functions/defines/variables Xia Jiang
2020-08-04  3:41   ` Xia Jiang
2020-08-04  3:41   ` Xia Jiang
2020-08-04  3:41 ` [PATCH v11 27/28] media: platform: Using the variant structure to contain the varability between dec and enc Xia Jiang
2020-08-04  3:41   ` Xia Jiang
2020-08-04  3:41   ` Xia Jiang
2020-08-04  3:41 ` [PATCH v11 28/28] media: platform: Add jpeg enc feature Xia Jiang
2020-08-04  3:41   ` Xia Jiang
2020-08-04  3:41   ` Xia Jiang
2020-08-05  8:45 ` [PATCH v11 00/28] Add support for mt2701 JPEG ENC support Hans Verkuil
2020-08-05  8:45   ` Hans Verkuil
2020-08-05  8:45   ` Hans Verkuil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200804034102.22983-4-xia.jiang@mediatek.com \
    --to=xia.jiang@mediatek.com \
    --cc=devicetree@vger.kernel.org \
    --cc=drinkcat@chromium.org \
    --cc=hverkuil-cisco@xs4all.nl \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=m.szyprowski@samsung.com \
    --cc=maoguang.meng@mediatek.com \
    --cc=matthias.bgg@gmail.com \
    --cc=mchehab+samsung@kernel.org \
    --cc=mojahsu@chromium.org \
    --cc=rick.chang@mediatek.com \
    --cc=robh+dt@kernel.org \
    --cc=senozhatsky@chromium.org \
    --cc=srv_heupstream@mediatek.com \
    --cc=tfiga@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.