All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nilesh Javali <njavali@marvell.com>
To: <martin.petersen@oracle.com>
Cc: <linux-scsi@vger.kernel.org>, <GR-QLogic-Storage-Upstream@marvell.com>
Subject: [PATCH v2 10/11] Revert "scsi: qla2xxx: Fix crash on qla2x00_mailbox_command"
Date: Thu, 6 Aug 2020 04:10:13 -0700	[thread overview]
Message-ID: <20200806111014.28434-11-njavali@marvell.com> (raw)
In-Reply-To: <20200806111014.28434-1-njavali@marvell.com>

FCoE adapter initialization failed for ISP8021.

This reverts commit 3cb182b3fa8b7a61f05c671525494697cba39c6a.

Signed-off-by: Saurav Kashyap <skashyap@marvell.com>
Signed-off-by: Nilesh Javali <njavali@marvell.com>
---
 drivers/scsi/qla2xxx/qla_mbx.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/drivers/scsi/qla2xxx/qla_mbx.c b/drivers/scsi/qla2xxx/qla_mbx.c
index 73883435ab58..93aafef7f21c 100644
--- a/drivers/scsi/qla2xxx/qla_mbx.c
+++ b/drivers/scsi/qla2xxx/qla_mbx.c
@@ -334,14 +334,6 @@ qla2x00_mailbox_command(scsi_qla_host_t *vha, mbx_cmd_t *mcp)
 			if (time_after(jiffies, wait_time))
 				break;
 
-			/*
-			 * Check if it's UNLOADING, cause we cannot poll in
-			 * this case, or else a NULL pointer dereference
-			 * is triggered.
-			 */
-			if (unlikely(test_bit(UNLOADING, &base_vha->dpc_flags)))
-				return QLA_FUNCTION_TIMEOUT;
-
 			/* Check for pending interrupts. */
 			qla2x00_poll(ha->rsp_q_map[0]);
 
-- 
2.19.0.rc0


  parent reply	other threads:[~2020-08-06 12:41 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-06 11:10 [PATCH v2 00/11] qla2xxx driver bug fixes Nilesh Javali
2020-08-06 11:10 ` [PATCH v2 01/11] qla2xxx: flush all sessions on zone disable Nilesh Javali
2020-08-12 19:38   ` Himanshu Madhani
2020-08-06 11:10 ` [PATCH v2 02/11] qla2xxx: flush IO " Nilesh Javali
2020-08-12 19:39   ` Himanshu Madhani
2020-08-06 11:10 ` [PATCH v2 03/11] qla2xxx: Indicate correct supported speeds for Mezz card Nilesh Javali
2020-08-12 19:40   ` Himanshu Madhani
2020-08-06 11:10 ` [PATCH v2 04/11] qla2xxx: fix login timeout Nilesh Javali
2020-08-12 19:42   ` Himanshu Madhani
2020-08-06 11:10 ` [PATCH v2 05/11] qla2xxx: reduce noisy debug message Nilesh Javali
2020-08-12 19:44   ` Himanshu Madhani
2020-08-06 11:10 ` [PATCH v2 06/11] qla2xxx: Allow ql2xextended_error_logging special value 1 to be set anytime Nilesh Javali
2020-08-12 19:43   ` Himanshu Madhani
2020-08-06 11:10 ` [PATCH v2 07/11] qla2xxx: Fix WARN_ON in qla_nvme_register_hba Nilesh Javali
2020-08-12 19:46   ` Himanshu Madhani
2020-08-06 11:10 ` [PATCH v2 08/11] qla2xxx: Check if FW supports MQ before enabling Nilesh Javali
2020-08-12 19:46   ` Himanshu Madhani
2020-08-06 11:10 ` [PATCH v2 09/11] qla2xxx: fix null pointer access while connections disconnect from subsystem Nilesh Javali
2020-08-12 19:47   ` Himanshu Madhani
2020-08-06 11:10 ` Nilesh Javali [this message]
2020-08-07  7:54   ` [PATCH v2 10/11] Revert "scsi: qla2xxx: Fix crash on qla2x00_mailbox_command" Daniel Wagner
2020-08-10  9:55     ` Saurav Kashyap
2020-08-12 19:31       ` Himanshu Madhani
2020-08-24  8:04         ` Daniel Wagner
2020-08-24 10:49           ` [EXT] " Saurav Kashyap
2020-08-06 11:10 ` [PATCH v2 11/11] qla2xxx: Revert: Disable T10-DIF feature with FC-NVMe during probe Nilesh Javali
2020-08-12 19:47   ` Himanshu Madhani
2020-08-18  3:12 ` [PATCH v2 00/11] qla2xxx driver bug fixes Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200806111014.28434-11-njavali@marvell.com \
    --to=njavali@marvell.com \
    --cc=GR-QLogic-Storage-Upstream@marvell.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.