All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Szyprowski <m.szyprowski@samsung.com>
To: linux-clk@vger.kernel.org, linux-pm@vger.kernel.org,
	linux-samsung-soc@vger.kernel.org
Cc: Marek Szyprowski <m.szyprowski@samsung.com>,
	Sylwester Nawrocki <snawrocki@kernel.org>,
	Chanwoo Choi <cw00.choi@samsung.com>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	Lukasz Luba <lukasz.luba@arm.com>,
	Stephen Boyd <sboyd@kernel.org>
Subject: [PATCH v2] clk: samsung: Keep top BPLL mux on Exynos542x enabled
Date: Fri,  7 Aug 2020 15:31:43 +0200	[thread overview]
Message-ID: <20200807133143.22748-1-m.szyprowski@samsung.com> (raw)
In-Reply-To: CGME20200807133152eucas1p1d83611a984f5c5d875192d08e2f5711f@eucas1p1.samsung.com

BPLL clock must not be disabled because it is needed for proper DRAM
operation. This is normally handled by respective memory devfreq driver,
but when that driver is not yet probed or its probe has been deferred the
clock might got disabled what causes board hang. Fix this by calling
clk_prepare_enable() directly from the clock provider driver.

Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>
Tested-by: Lukasz Luba <lukasz.luba@arm.com>
Acked-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 drivers/clk/samsung/clk-exynos5420.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/clk/samsung/clk-exynos5420.c b/drivers/clk/samsung/clk-exynos5420.c
index fea33399a632..521cbbfc0987 100644
--- a/drivers/clk/samsung/clk-exynos5420.c
+++ b/drivers/clk/samsung/clk-exynos5420.c
@@ -1655,6 +1655,11 @@ static void __init exynos5x_clk_init(struct device_node *np,
 	 * main G3D clock enablement status.
 	 */
 	clk_prepare_enable(__clk_lookup("mout_sw_aclk_g3d"));
+	/*
+	 * Keep top BPLL mux enabled permanently to ensure that DRAM operates
+	 * properly.
+	 */
+	clk_prepare_enable(__clk_lookup("mout_bpll"));
 
 	samsung_clk_of_add_provider(np, ctx);
 }
-- 
2.17.1


       reply	other threads:[~2020-08-07 13:31 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20200807133152eucas1p1d83611a984f5c5d875192d08e2f5711f@eucas1p1.samsung.com>
2020-08-07 13:31 ` Marek Szyprowski [this message]
2020-08-10  2:58   ` [PATCH v2] clk: samsung: Keep top BPLL mux on Exynos542x enabled Chanwoo Choi
2020-08-11  8:49   ` [clk] a2499eff4b: BUG:kernel_NULL_pointer_dereference,address kernel test robot
2020-08-11  8:49     ` kernel test robot
2020-08-19  3:13     ` Stephen Boyd
2020-08-19  3:13       ` [clk] a2499eff4b: BUG:kernel_NULL_pointer_dereference, address Stephen Boyd
2020-08-20  5:03       ` [clk] a2499eff4b: BUG:kernel_NULL_pointer_dereference,address Rong Chen
2020-08-20  5:03         ` [clk] a2499eff4b: BUG:kernel_NULL_pointer_dereference, address Rong Chen
2020-08-11 11:31   ` [PATCH v2] clk: samsung: Keep top BPLL mux on Exynos542x enabled Sylwester Nawrocki
2020-08-19  3:12     ` Stephen Boyd
2020-08-19  3:14   ` Stephen Boyd
2020-08-23 10:12     ` Sylwester Nawrocki
2020-08-24 10:28       ` Sylwester Nawrocki
2020-08-24 10:31         ` Krzysztof Kozlowski
2020-09-02  9:24           ` Sylwester Nawrocki
2020-09-15 12:43             ` Sylwester Nawrocki
2020-09-15 16:17               ` Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200807133143.22748-1-m.szyprowski@samsung.com \
    --to=m.szyprowski@samsung.com \
    --cc=b.zolnierkie@samsung.com \
    --cc=cw00.choi@samsung.com \
    --cc=krzk@kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=lukasz.luba@arm.com \
    --cc=sboyd@kernel.org \
    --cc=snawrocki@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.