All of lore.kernel.org
 help / color / mirror / Atom feed
From: Havard Skinnemoen <hskinnemoen@google.com>
To: peter.maydell@linaro.org, f4bug@amsat.org, clg@kaod.org, joel@jms.id.au
Cc: qemu-arm@nongnu.org, qemu-devel@nongnu.org,
	Avi.Fishman@nuvoton.com,  kfting@nuvoton.com,
	Havard Skinnemoen <hskinnemoen@google.com>
Subject: [PATCH v7 07/13] hw/arm: Load -bios image as a boot ROM for npcm7xx
Date: Tue, 11 Aug 2020 00:46:01 +0000	[thread overview]
Message-ID: <20200811004607.2133149-8-hskinnemoen@google.com> (raw)
In-Reply-To: <20200811004607.2133149-1-hskinnemoen@google.com>

If a -bios option is specified on the command line, load the image into
the internal ROM memory region, which contains the first instructions
run by the CPU after reset.

If -bios is not specified, the vbootrom included with qemu is loaded by
default.

Reviewed-by: Tyrone Ting <kfting@nuvoton.com>
Reviewed-by: Cédric Le Goater <clg@kaod.org>
Signed-off-by: Havard Skinnemoen <hskinnemoen@google.com>
---
 hw/arm/npcm7xx_boards.c | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/hw/arm/npcm7xx_boards.c b/hw/arm/npcm7xx_boards.c
index 0b9dce2b35..26ea97072b 100644
--- a/hw/arm/npcm7xx_boards.c
+++ b/hw/arm/npcm7xx_boards.c
@@ -18,12 +18,38 @@
 
 #include "hw/arm/npcm7xx.h"
 #include "hw/core/cpu.h"
+#include "hw/loader.h"
 #include "qapi/error.h"
+#include "qemu-common.h"
 #include "qemu/units.h"
+#include "sysemu/sysemu.h"
 
 #define NPCM750_EVB_POWER_ON_STRAPS 0x00001ff7
 #define QUANTA_GSJ_POWER_ON_STRAPS 0x00001fff
 
+static const char npcm7xx_default_bootrom[] = "npcm7xx_bootrom.bin";
+
+static void npcm7xx_load_bootrom(NPCM7xxState *soc)
+{
+    g_autofree char *filename = NULL;
+    int ret;
+
+    if (!bios_name) {
+        bios_name = npcm7xx_default_bootrom;
+    }
+
+    filename = qemu_find_file(QEMU_FILE_TYPE_BIOS, bios_name);
+    if (!filename) {
+        error_report("Could not find ROM image '%s'", bios_name);
+        exit(1);
+    }
+    ret = load_image_mr(filename, &soc->irom);
+    if (ret < 0) {
+        error_report("Failed to load ROM image '%s'", filename);
+        exit(1);
+    }
+}
+
 static void npcm7xx_connect_dram(NPCM7xxState *soc, MemoryRegion *dram)
 {
     memory_region_add_subregion(get_system_memory(), NPCM7XX_DRAM_BA, dram);
@@ -60,6 +86,7 @@ static void npcm750_evb_init(MachineState *machine)
     npcm7xx_connect_dram(soc, machine->ram);
     qdev_realize(DEVICE(soc), NULL, &error_fatal);
 
+    npcm7xx_load_bootrom(soc);
     npcm7xx_load_kernel(machine, soc);
 }
 
@@ -71,6 +98,7 @@ static void quanta_gsj_init(MachineState *machine)
     npcm7xx_connect_dram(soc, machine->ram);
     qdev_realize(DEVICE(soc), NULL, &error_fatal);
 
+    npcm7xx_load_bootrom(soc);
     npcm7xx_load_kernel(machine, soc);
 }
 
-- 
2.28.0.236.gb10cc79966-goog



  parent reply	other threads:[~2020-08-11  0:50 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-11  0:45 [PATCH v7 00/13] Add Nuvoton NPCM730/NPCM750 SoCs and two BMC machines Havard Skinnemoen
2020-08-11  0:45 ` [PATCH v7 01/13] hw/misc: Add NPCM7xx System Global Control Registers device model Havard Skinnemoen
2020-08-11  0:45 ` [PATCH v7 02/13] hw/misc: Add NPCM7xx Clock Controller " Havard Skinnemoen
2020-08-12 10:31   ` Philippe Mathieu-Daudé
2020-08-11  0:45 ` [PATCH v7 03/13] hw/timer: Add NPCM7xx Timer " Havard Skinnemoen
2020-08-11  0:45 ` [PATCH v7 04/13] hw/arm: Add NPCM730 and NPCM750 SoC models Havard Skinnemoen
2020-08-11  0:45 ` [PATCH v7 05/13] hw/arm: Add two NPCM7xx-based machines Havard Skinnemoen
2020-08-11  0:46 ` [PATCH v7 06/13] roms: Add virtual Boot ROM for NPCM7xx SoCs Havard Skinnemoen
2020-08-11  0:46 ` Havard Skinnemoen [this message]
2020-08-11  8:38   ` [PATCH v7 07/13] hw/arm: Load -bios image as a boot ROM for npcm7xx Philippe Mathieu-Daudé
2020-08-11  0:46 ` [PATCH v7 08/13] hw/nvram: NPCM7xx OTP device model Havard Skinnemoen
2020-08-11  0:46 ` [PATCH v7 09/13] hw/mem: Stubbed out NPCM7xx Memory Controller model Havard Skinnemoen
2020-08-11  0:46 ` [PATCH v7 10/13] hw/ssi: NPCM7xx Flash Interface Unit device model Havard Skinnemoen
2020-08-11  0:46 ` [PATCH v7 11/13] hw/arm: Wire up BMC boot flash for npcm750-evb and quanta-gsj Havard Skinnemoen
2020-08-11  0:46 ` [PATCH v7 12/13] docs/system: Add Nuvoton machine documentation Havard Skinnemoen
2020-08-11  0:46 ` [PATCH v7 13/13] tests/acceptance: console boot tests for quanta-gsj Havard Skinnemoen
2020-08-11  8:48   ` Philippe Mathieu-Daudé
2020-08-12  3:26     ` Havard Skinnemoen
2020-08-20  1:53       ` Havard Skinnemoen
2020-08-20  5:29         ` Philippe Mathieu-Daudé
2020-08-20  5:38           ` Philippe Mathieu-Daudé
2020-08-20 16:24           ` Havard Skinnemoen
2020-08-20 17:46             ` Philippe Mathieu-Daudé
2020-08-20 20:30               ` Havard Skinnemoen
2020-08-22 21:40                 ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200811004607.2133149-8-hskinnemoen@google.com \
    --to=hskinnemoen@google.com \
    --cc=Avi.Fishman@nuvoton.com \
    --cc=clg@kaod.org \
    --cc=f4bug@amsat.org \
    --cc=joel@jms.id.au \
    --cc=kfting@nuvoton.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.