All of lore.kernel.org
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert+renesas@glider.be>
To: Alessandro Zummo <a.zummo@towertech.it>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>,
	kogiidena <kogiidena@eggplant.ddo.jp>,
	Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
	linux-rtc@vger.kernel.org, linux-sh@vger.kernel.org,
	Geert Uytterhoeven <geert+renesas@glider.be>
Subject: [PATCH 1/3] rtc: rtc-rs5c313: Drop obsolete platform_set_drvdata() call
Date: Fri, 14 Aug 2020 11:07:29 +0000	[thread overview]
Message-ID: <20200814110731.29029-2-geert+renesas@glider.be> (raw)
In-Reply-To: <20200814110731.29029-1-geert+renesas@glider.be>

Commit 284e2fa1da00a998 ("rtc: rtc-rs5c313: use
devm_rtc_device_register()"), removed the last user of the
driver-specific data.  Hence there is no longer a need to set it.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/rtc/rtc-rs5c313.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/drivers/rtc/rtc-rs5c313.c b/drivers/rtc/rtc-rs5c313.c
index 89f38e3e917d3d11..00b5ef753935ec8a 100644
--- a/drivers/rtc/rtc-rs5c313.c
+++ b/drivers/rtc/rtc-rs5c313.c
@@ -369,12 +369,7 @@ static int rs5c313_rtc_probe(struct platform_device *pdev)
 	struct rtc_device *rtc = devm_rtc_device_register(&pdev->dev, "rs5c313",
 				&rs5c313_rtc_ops, THIS_MODULE);
 
-	if (IS_ERR(rtc))
-		return PTR_ERR(rtc);
-
-	platform_set_drvdata(pdev, rtc);
-
-	return 0;
+	return PTR_ERR_OR_ZERO(rtc);
 }
 
 static struct platform_driver rs5c313_rtc_platform_driver = {
-- 
2.17.1

WARNING: multiple messages have this Message-ID (diff)
From: Geert Uytterhoeven <geert+renesas@glider.be>
To: Alessandro Zummo <a.zummo@towertech.it>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>,
	kogiidena <kogiidena@eggplant.ddo.jp>,
	Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
	linux-rtc@vger.kernel.org, linux-sh@vger.kernel.org,
	Geert Uytterhoeven <geert+renesas@glider.be>
Subject: [PATCH 1/3] rtc: rtc-rs5c313: Drop obsolete platform_set_drvdata() call
Date: Fri, 14 Aug 2020 13:07:29 +0200	[thread overview]
Message-ID: <20200814110731.29029-2-geert+renesas@glider.be> (raw)
In-Reply-To: <20200814110731.29029-1-geert+renesas@glider.be>

Commit 284e2fa1da00a998 ("rtc: rtc-rs5c313: use
devm_rtc_device_register()"), removed the last user of the
driver-specific data.  Hence there is no longer a need to set it.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/rtc/rtc-rs5c313.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/drivers/rtc/rtc-rs5c313.c b/drivers/rtc/rtc-rs5c313.c
index 89f38e3e917d3d11..00b5ef753935ec8a 100644
--- a/drivers/rtc/rtc-rs5c313.c
+++ b/drivers/rtc/rtc-rs5c313.c
@@ -369,12 +369,7 @@ static int rs5c313_rtc_probe(struct platform_device *pdev)
 	struct rtc_device *rtc = devm_rtc_device_register(&pdev->dev, "rs5c313",
 				&rs5c313_rtc_ops, THIS_MODULE);
 
-	if (IS_ERR(rtc))
-		return PTR_ERR(rtc);
-
-	platform_set_drvdata(pdev, rtc);
-
-	return 0;
+	return PTR_ERR_OR_ZERO(rtc);
 }
 
 static struct platform_driver rs5c313_rtc_platform_driver = {
-- 
2.17.1


  reply	other threads:[~2020-08-14 11:07 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-14 11:07 [PATCH 0/3] rtc: rtc-rs5c313: Fix and cleanups Geert Uytterhoeven
2020-08-14 11:07 ` Geert Uytterhoeven
2020-08-14 11:07 ` Geert Uytterhoeven [this message]
2020-08-14 11:07   ` [PATCH 1/3] rtc: rtc-rs5c313: Drop obsolete platform_set_drvdata() call Geert Uytterhoeven
2020-08-14 11:07 ` [PATCH 2/3] rtc: rtc-rs5c313: Fix late hardware init Geert Uytterhoeven
2020-08-14 11:07   ` Geert Uytterhoeven
2020-08-14 11:07 ` [PATCH 3/3] rtc: rtc-rs5c313: Convert to module_platform_driver() Geert Uytterhoeven
2020-08-14 11:07   ` Geert Uytterhoeven
2020-08-20 22:14 ` [PATCH 0/3] rtc: rtc-rs5c313: Fix and cleanups Alexandre Belloni
2020-08-20 22:14   ` Alexandre Belloni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200814110731.29029-2-geert+renesas@glider.be \
    --to=geert+renesas@glider.be \
    --cc=a.zummo@towertech.it \
    --cc=alexandre.belloni@bootlin.com \
    --cc=glaubitz@physik.fu-berlin.de \
    --cc=iwamatsu@nigauri.org \
    --cc=kogiidena@eggplant.ddo.jp \
    --cc=linux-rtc@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.